From: Frederick Giasson <fred@curbside.com>
To: numbchild@gmail.com
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: ob-clojure with tangling current broken
Date: Tue, 22 Jan 2019 08:01:48 -0500 [thread overview]
Message-ID: <CADjL5rXq0cxOxZx41URO+RvGK+pQQVppiFsmq7SNycb99BS+Og@mail.gmail.com> (raw)
In-Reply-To: <8736plxh7j.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1867 bytes --]
Hi,
That's why I added a patch recently. Now Nicolas already applied my
> patch. You should already seen it now.
>
Yeah I just received that email right after I sent mine. Didn't know it was
in the pipeline, I just re-subscribed to the mailing list.
> >
> > It turns out that the culprit is the following line:
> > https://code.orgmode.org/bzg/org-mode/src/master/lisp/ob-clojure.el#L108
> >
> > I am wondering why is there such code injection in
> > "org-babel-expand-body:clojure". It looks like to be related to the
> Clojure code
> > block execution, but it also appears to be called from the tangling
> function.
> > Clearly those two different use cases needs to be properly handled at
> the level
> > of "ob-clojure.el"
> >
>
> Expanding clojure code is necessary to tangling, because when user have
> noweb reference etc in source block, expanding here is necessary.
>
Yes, that is right. What I was referring to I guess is to handle that case
(tangling vs. code block execution within Emacs), which is what this patch
is about, thanks!
>
> > I didn't follow all the changes to the "ob-clojure" mode in the last
> year or so,
> > so please pardon my ignorance if the module is taking a different
> direction than
> > I am used to. Is there a rational behind this behaviour or is there a
> new feature
> > that I am not aware of which properly handle those two use cases?
> >
>
> Which part you don't understand, I might can answer your question,
> because I did most of those changes in last year.
>
The only thing I meant here is that the last time I looked into this code,
it was quite different, you guys appears to have worked a lot on it.
Another thing I discovered is the =ob-clojure-literate=, but even after
reading its [sparse] doc and its code, I am not sure what it concretely
adds to =ob-clojure=
Thanks for this work!
Take care,
Fred
[-- Attachment #2: Type: text/html, Size: 2863 bytes --]
next prev parent reply other threads:[~2019-01-22 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 20:05 ob-clojure with tangling current broken Frederick Giasson
2019-01-22 7:52 ` stardiviner
2019-01-22 13:01 ` Frederick Giasson [this message]
2019-01-23 6:38 ` stardiviner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADjL5rXq0cxOxZx41URO+RvGK+pQQVppiFsmq7SNycb99BS+Og@mail.gmail.com \
--to=fred@curbside.com \
--cc=emacs-orgmode@gnu.org \
--cc=numbchild@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).