emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Frederick Giasson <fred@curbside.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-detangle seems broken
Date: Tue, 5 Jun 2018 08:18:34 -0400	[thread overview]
Message-ID: <CADjL5rURioNueu-Pk9CvyN-yfGS=iHNDhs0t32jvBw6dKx49Qg@mail.gmail.com> (raw)
In-Reply-To: <87o9gp7dwb.fsf@nicolasgoaziou.fr>

[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]

Hi Nicolas,

> Here it is. If you =detangle= the =broken-detangle--working.el= file, it
> > will work as expected.
> >
> > However, if you try to detangle the =broken-detangle--NOT-working.el=
> file,
> > you should get a "Not in a source block" error in *message*.
>
> This is fixed in "master".
>

That is great! Working perfectly no, thanks!



> > Another thing I noted while creating the ECM is if there is only *one*
> code
> > block in the =.org= file, then it throws a =End of Buffer= error.
>
> I couldn't reproduce this. If the fix below doesn't solve it, could you
> provide a dedicated ECM?
>

Yes, that fixed it as well.



There is one last thing related to =org-babel-detangle= that seems "broken"
is that as far as I can see, the top =save-excursion= should save the
position of the cursor of the source file and keep the buffer at that
position when we perform a detangling on it, no?

Right now, the behavior is that when we do a detangle from a source file,
the org file get opened in the buffer of the source file.

However, I think that the right behavior is that when we detangle that the
remain at the same position in the source file otherwise this gets
confusing in my opinion.

Is that a bug or the expected behavior?

Thanks!

Take care

Fred

[-- Attachment #2: Type: text/html, Size: 2198 bytes --]

next prev parent reply	other threads:[~2018-06-05 12:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 17:27 org-detangle seems broken Frederick Giasson
2018-06-02 10:17 ` Nicolas Goaziou
2018-06-04 12:42   ` Frederick Giasson
2018-06-05  9:59     ` Nicolas Goaziou
2018-06-05 12:18       ` Frederick Giasson [this message]
2018-06-05 23:19         ` Grant Rettke
2018-06-06 12:31           ` Frederick Giasson
2018-06-06 16:04             ` Grant Rettke
2018-06-06 16:18               ` Frederick Giasson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADjL5rURioNueu-Pk9CvyN-yfGS=iHNDhs0t32jvBw6dKx49Qg@mail.gmail.com' \
    --to=fred@curbside.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).