emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Benjamin Beckwith <bnbeckwith@gmail.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] Columnview: Fix the case of #+ content present
Date: Tue, 17 Sep 2013 15:13:30 -0400	[thread overview]
Message-ID: <CADhi4W3zebL2MxTSNdB5tk64J5h5RUxV4oCHd2CO3QANWB0SYw@mail.gmail.com> (raw)

* lisp/org-colview.el (org-dblock-write:columnview): Change the
  capture of pos to after inserting the original content

The problem is with a block that has content preceding the table.
Upon recreating the content, the `pos' gets set to the beginning of
this content instead of the table.  Later calls to
`org-table-recalculate' or `org-table-align' will fail because the
point is not at a table.

This patch moves the capture of `pos' to right before the insertion of
the table.

TINYCHANGE
---
 lisp/org-colview.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-colview.el b/lisp/org-colview.el
index f3b8e42..8790ad4 100644
--- a/lisp/org-colview.el
+++ b/lisp/org-colview.el
@@ -1306,10 +1306,10 @@ PARAMS is a property list of parameters:
                            (if (eq 'hline x) x (cons "" x)))
                          tbl))
        (setq tbl (append tbl (list (cons "/" (make-list nfields "<>"))))))
-      (setq pos (point))
       (when content-lines
        (while (string-match "^#" (car content-lines))
          (insert (pop content-lines) "\n")))
+      (setq pos (point))
       (insert (org-listtable-to-string tbl))
       (when (plist-get params :width)
        (insert "\n|" (mapconcat (lambda (x) (format "<%d>" (max 3 x)))
--
1.8.1.2

next             reply	other threads:[~2013-09-17 19:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-17 19:13 Benjamin Beckwith [this message]
2013-09-22  6:08 ` [PATCH] Columnview: Fix the case of #+ content present Carsten Dominik

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:f3b8e42 dfblob:8790ad4
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADhi4W3zebL2MxTSNdB5tk64J5h5RUxV4oCHd2CO3QANWB0SYw@mail.gmail.com \
    --to=bnbeckwith@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).