From: Nikolai Weibull <now@disu.se>
To: Nikolai Weibull <now@disu.se>, emacs-orgmode@gnu.org
Subject: Re: [PATCH 2/2] Allow inserting diary entries last in date tree
Date: Sun, 23 Aug 2015 19:11:05 +0200 [thread overview]
Message-ID: <CADdV=MuWouP2BRUPPXmsUZqn2QMYvDrQJ_Job_6e66xTNhyDLg@mail.gmail.com> (raw)
In-Reply-To: <878u92lag3.fsf@nicolasgoaziou.fr>
On Sun, Aug 23, 2015 at 9:40 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>> + (let ((last (eq org-agenda-insert-diary-strategy 'date-tree-last))
>> + (has-children (save-excursion (org-goto-first-child))))
>> + (if (not (and last has-children))
>> + (outline-next-heading)
>> + (org-goto-first-child)
>> + (while (org-get-next-sibling)))
>> + (org-back-over-empty-lines)
>> + (unless (looking-at "[ \t]*$") (save-excursion (insert "\n")))
>> + (org-insert-heading nil t)
>> + (unless has-children
>> + (org-do-demote)))
>
> This part is incorrect, when tree is ill-formed, and slightly
> inefficient when there are many children.
>
> Assuming point is on the parent headline, I think a faster way to do
> this would be
>
> (org-end-of-subtree t t)
> (org-insert-heading nil t)
> (org-do-demote)
That’s what I used first, but that doesn’t work if the subtree has
children that has children.
next prev parent reply other threads:[~2015-08-23 17:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 9:03 org-agenda-insert-diary-make-new-entry adds entry as first child? Nikolai Weibull
2014-05-30 12:10 ` Bastien
2014-05-30 14:02 ` Nikolai Weibull
2014-05-30 14:04 ` Bastien
2014-05-30 14:47 ` Nikolai Weibull
2014-05-30 15:24 ` Bastien
2014-05-30 16:12 ` Nikolai Weibull
2014-07-28 14:20 ` Bastien
2015-03-07 21:49 ` Nikolai Weibull
2015-04-11 19:05 ` Nicolas Goaziou
2015-08-20 11:51 ` Nikolai Weibull
2015-08-20 11:51 ` [PATCH 2/2] Allow inserting diary entries last in date tree Nikolai Weibull
2015-08-23 7:40 ` Nicolas Goaziou
2015-08-23 17:11 ` Nikolai Weibull [this message]
2015-08-23 20:42 ` Nicolas Goaziou
2015-08-24 8:40 ` [PATCH] " Nikolai Weibull
2015-08-24 20:39 ` Nicolas Goaziou
2015-08-24 20:55 ` Nicolas Goaziou
2015-08-25 5:52 ` [PATCH] Add news about org-agenda-insert-diary-strategy Nikolai Weibull
2015-08-25 6:05 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADdV=MuWouP2BRUPPXmsUZqn2QMYvDrQJ_Job_6e66xTNhyDLg@mail.gmail.com' \
--to=now@disu.se \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).