* Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock
@ 2014-12-22 18:10 Nikolai Weibull
2015-01-07 17:51 ` Nikolai Weibull
0 siblings, 1 reply; 18+ messages in thread
From: Nikolai Weibull @ 2014-12-22 18:10 UTC (permalink / raw)
To: emacs-orgmode
Hi!
It seems that agendas created when org-agenda-sticky-mode is t aren’t
automatically redone when calling
org-agenda-(set|remove)-restriction-lock. The reason is that
(org-agenda-maybe-redo) checks whether there’s a window displaying a
buffer named org-agenda-buffer-name. Org-agenda-buffer-name is, for
some reason, not set to the (buffer-name) for these sticky agendas
(which get the key that was selected as a suffix, for example, “*Org
Agenda(p)*”).
I don’t know whether there’s a reason for this, but it seems like it’s
a bug. Either org-agenda-buffer-name isn’t being set correctly or
(org-agenda-maybe-redo) should be using (buffer-name) instead of
org-agenda-buffer-name.
If there’s a reason for this, I’d really like to know what it is, so
that I can begin to try to remember to press g whenever I’ve updated
the restriction lock.
Thanks!
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock
2014-12-22 18:10 Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock Nikolai Weibull
@ 2015-01-07 17:51 ` Nikolai Weibull
2015-01-18 9:55 ` Nikolai Weibull
0 siblings, 1 reply; 18+ messages in thread
From: Nikolai Weibull @ 2015-01-07 17:51 UTC (permalink / raw)
To: emacs-orgmode
Hi!
Anyone else experiencing this? Or is my configuration wrong in some way?
On Mon, Dec 22, 2014 at 7:10 PM, Nikolai Weibull <now@disu.se> wrote:
> Hi!
>
> It seems that agendas created when org-agenda-sticky-mode is t aren’t
> automatically redone when calling
> org-agenda-(set|remove)-restriction-lock. The reason is that
> (org-agenda-maybe-redo) checks whether there’s a window displaying a
> buffer named org-agenda-buffer-name. Org-agenda-buffer-name is, for
> some reason, not set to the (buffer-name) for these sticky agendas
> (which get the key that was selected as a suffix, for example, “*Org
> Agenda(p)*”).
>
> I don’t know whether there’s a reason for this, but it seems like it’s
> a bug. Either org-agenda-buffer-name isn’t being set correctly or
> (org-agenda-maybe-redo) should be using (buffer-name) instead of
> org-agenda-buffer-name.
>
> If there’s a reason for this, I’d really like to know what it is, so
> that I can begin to try to remember to press g whenever I’ve updated
> the restriction lock.
>
> Thanks!
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock
2015-01-07 17:51 ` Nikolai Weibull
@ 2015-01-18 9:55 ` Nikolai Weibull
2015-01-18 10:26 ` Nicolas Goaziou
0 siblings, 1 reply; 18+ messages in thread
From: Nikolai Weibull @ 2015-01-18 9:55 UTC (permalink / raw)
To: emacs-orgmode
I’m bumping this again, as this feels like a bug and I’m surprised
that no one has at least responded to it.
On Wed, Jan 7, 2015 at 6:51 PM, Nikolai Weibull <now@disu.se> wrote:
> Hi!
>
> Anyone else experiencing this? Or is my configuration wrong in some way?
>
> On Mon, Dec 22, 2014 at 7:10 PM, Nikolai Weibull <now@disu.se> wrote:
>> Hi!
>>
>> It seems that agendas created when org-agenda-sticky-mode is t aren’t
>> automatically redone when calling
>> org-agenda-(set|remove)-restriction-lock. The reason is that
>> (org-agenda-maybe-redo) checks whether there’s a window displaying a
>> buffer named org-agenda-buffer-name. Org-agenda-buffer-name is, for
>> some reason, not set to the (buffer-name) for these sticky agendas
>> (which get the key that was selected as a suffix, for example, “*Org
>> Agenda(p)*”).
>>
>> I don’t know whether there’s a reason for this, but it seems like it’s
>> a bug. Either org-agenda-buffer-name isn’t being set correctly or
>> (org-agenda-maybe-redo) should be using (buffer-name) instead of
>> org-agenda-buffer-name.
>>
>> If there’s a reason for this, I’d really like to know what it is, so
>> that I can begin to try to remember to press g whenever I’ve updated
>> the restriction lock.
>>
>> Thanks!
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock
2015-01-18 9:55 ` Nikolai Weibull
@ 2015-01-18 10:26 ` Nicolas Goaziou
2015-01-18 13:27 ` Nikolai Weibull
0 siblings, 1 reply; 18+ messages in thread
From: Nicolas Goaziou @ 2015-01-18 10:26 UTC (permalink / raw)
To: Nikolai Weibull; +Cc: emacs-orgmode
Hello,
Nikolai Weibull <now@disu.se> writes:
> I’m bumping this again, as this feels like a bug and I’m surprised
> that no one has at least responded to it.
>
> On Wed, Jan 7, 2015 at 6:51 PM, Nikolai Weibull <now@disu.se> wrote:
>> Hi!
>>
>> Anyone else experiencing this? Or is my configuration wrong in some way?
>>
>> On Mon, Dec 22, 2014 at 7:10 PM, Nikolai Weibull <now@disu.se> wrote:
>>> Hi!
>>>
>>> It seems that agendas created when org-agenda-sticky-mode is t aren’t
>>> automatically redone when calling
>>> org-agenda-(set|remove)-restriction-lock. The reason is that
>>> (org-agenda-maybe-redo) checks whether there’s a window displaying a
>>> buffer named org-agenda-buffer-name. Org-agenda-buffer-name is, for
>>> some reason, not set to the (buffer-name) for these sticky agendas
>>> (which get the key that was selected as a suffix, for example, “*Org
>>> Agenda(p)*”).
>>>
>>> I don’t know whether there’s a reason for this, but it seems like it’s
>>> a bug. Either org-agenda-buffer-name isn’t being set correctly or
>>> (org-agenda-maybe-redo) should be using (buffer-name) instead of
>>> org-agenda-buffer-name.
>>>
>>> If there’s a reason for this, I’d really like to know what it is, so
>>> that I can begin to try to remember to press g whenever I’ve updated
>>> the restriction lock.
According to the manual
By default, Org maintains only a single agenda buffer and rebuilds
it each time you change the view, to make sure everything is always
up to date. If you often switch between agenda views and the build
time bothers you, you can turn on sticky agenda buffers or make
this the default by customizing the variable ‘org-agenda-sticky’.
With sticky agendas, the agenda dispatcher will not recreate agenda
views from scratch, it will only switch to the selected one, and
you need to update the agenda by hand with ‘r’ or ‘g’ when needed.
You can toggle sticky agenda view any time with
‘org-toggle-sticky-agenda’.
So the whole point of sticky agenda is that you need to update it
manually.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock
2015-01-18 10:26 ` Nicolas Goaziou
@ 2015-01-18 13:27 ` Nikolai Weibull
2015-01-18 22:39 ` Nicolas Goaziou
0 siblings, 1 reply; 18+ messages in thread
From: Nikolai Weibull @ 2015-01-18 13:27 UTC (permalink / raw)
To: Nikolai Weibull, emacs-orgmode
On Sun, Jan 18, 2015 at 11:26 AM, Nicolas Goaziou
<mail@nicolasgoaziou.fr> wrote:
> Nikolai Weibull <now@disu.se> writes:
>
>> I’m bumping this again, as this feels like a bug and I’m surprised
>> that no one has at least responded to it.
>>
>> On Wed, Jan 7, 2015 at 6:51 PM, Nikolai Weibull <now@disu.se> wrote:
>>> Hi!
>>>
>>> Anyone else experiencing this? Or is my configuration wrong in some way?
>>>
>>> On Mon, Dec 22, 2014 at 7:10 PM, Nikolai Weibull <now@disu.se> wrote:
>>>> Hi!
>>>>
>>>> It seems that agendas created when org-agenda-sticky-mode is t aren’t
>>>> automatically redone when calling
>>>> org-agenda-(set|remove)-restriction-lock. The reason is that
>>>> (org-agenda-maybe-redo) checks whether there’s a window displaying a
>>>> buffer named org-agenda-buffer-name. Org-agenda-buffer-name is, for
>>>> some reason, not set to the (buffer-name) for these sticky agendas
>>>> (which get the key that was selected as a suffix, for example, “*Org
>>>> Agenda(p)*”).
>>>>
>>>> I don’t know whether there’s a reason for this, but it seems like it’s
>>>> a bug. Either org-agenda-buffer-name isn’t being set correctly or
>>>> (org-agenda-maybe-redo) should be using (buffer-name) instead of
>>>> org-agenda-buffer-name.
>>>>
>>>> If there’s a reason for this, I’d really like to know what it is, so
>>>> that I can begin to try to remember to press g whenever I’ve updated
>>>> the restriction lock.
>
> According to the manual
I realize that you have to update it manually, but wouldn’t it make
sense to have it be updated automatically when you call
org-agenda-(set|remove)-restriction-lock? At least when you do so
from the Agenda itself?
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock
2015-01-18 13:27 ` Nikolai Weibull
@ 2015-01-18 22:39 ` Nicolas Goaziou
2015-01-19 9:33 ` Nikolai Weibull
0 siblings, 1 reply; 18+ messages in thread
From: Nicolas Goaziou @ 2015-01-18 22:39 UTC (permalink / raw)
To: Nikolai Weibull; +Cc: emacs-orgmode
Nikolai Weibull <now@disu.se> writes:
> I realize that you have to update it manually, but wouldn’t it make
> sense to have it be updated automatically when you call
> org-agenda-(set|remove)-restriction-lock? At least when you do so
> from the Agenda itself?
It could make sense, but the current behaviour is simple and
consistent : always refresh manually, no exception.
The other solution is to have all actions started from the agenda
trigger an automatic update. I don't know if that's the spirit of the
original sticky agenda feature, but it is certainly more work for little
benefit.
Regards,
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock
2015-01-18 22:39 ` Nicolas Goaziou
@ 2015-01-19 9:33 ` Nikolai Weibull
2015-01-19 17:38 ` Nicolas Goaziou
0 siblings, 1 reply; 18+ messages in thread
From: Nikolai Weibull @ 2015-01-19 9:33 UTC (permalink / raw)
To: Nikolai Weibull, emacs-orgmode
On Sun, Jan 18, 2015 at 11:39 PM, Nicolas Goaziou
<mail@nicolasgoaziou.fr> wrote:
> Nikolai Weibull <now@disu.se> writes:
>
>> I realize that you have to update it manually, but wouldn’t it make
>> sense to have it be updated automatically when you call
>> org-agenda-(set|remove)-restriction-lock? At least when you do so
>> from the Agenda itself?
> It could make sense, but the current behaviour is simple and
> consistent : always refresh manually, no exception.
I don’t agree that this is consistent at all. The Agenda is refreshed
when you run, for example, org-agenda-filter-by-category, which, in my
mind, is similar to setting a restriction.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock
2015-01-19 9:33 ` Nikolai Weibull
@ 2015-01-19 17:38 ` Nicolas Goaziou
2015-02-15 21:54 ` Nikolai Weibull
0 siblings, 1 reply; 18+ messages in thread
From: Nicolas Goaziou @ 2015-01-19 17:38 UTC (permalink / raw)
To: Nikolai Weibull; +Cc: emacs-orgmode
Nikolai Weibull <now@disu.se> writes:
> On Sun, Jan 18, 2015 at 11:39 PM, Nicolas Goaziou
>> It could make sense, but the current behaviour is simple and
>> consistent : always refresh manually, no exception.
>
> I don’t agree that this is consistent at all. The Agenda is refreshed
> when you run, for example, org-agenda-filter-by-category, which, in my
> mind, is similar to setting a restriction.
I didn't know an exception existed. Do you want to provide a patch for
this, then?
Regards,
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock
2015-01-19 17:38 ` Nicolas Goaziou
@ 2015-02-15 21:54 ` Nikolai Weibull
2015-02-16 9:05 ` Nicolas Goaziou
0 siblings, 1 reply; 18+ messages in thread
From: Nikolai Weibull @ 2015-02-15 21:54 UTC (permalink / raw)
To: Nikolai Weibull, emacs-orgmode
On Mon, Jan 19, 2015 at 6:38 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Nikolai Weibull <now@disu.se> writes:
>
>> On Sun, Jan 18, 2015 at 11:39 PM, Nicolas Goaziou
>
>>> It could make sense, but the current behaviour is simple and
>>> consistent : always refresh manually, no exception.
>>
>> I don’t agree that this is consistent at all. The Agenda is refreshed
>> when you run, for example, org-agenda-filter-by-category, which, in my
>> mind, is similar to setting a restriction.
>
> I didn't know an exception existed. Do you want to provide a patch for
> this, then?
Hi!
Sorry for the late reply. Here’s a patch that should work:
diff -u org-agenda.el.orig org-agenda.el
--- org-agenda.el.orig 2015-01-18 10:31:12.000000000 +0100
+++ org-agenda.el 2015-02-15 22:25:41.000000000 +0100
@@ -7135,7 +7135,9 @@
(defun org-agenda-maybe-redo ()
"If there is any window showing the agenda view, update it."
- (let ((w (get-buffer-window org-agenda-buffer-name t))
+ (let ((w (get-buffer-window (or org-agenda-this-buffer-name
+ org-agenda-buffer-name)
+ t))
(w0 (selected-window)))
(when w
(select-window w)
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock
2015-02-15 21:54 ` Nikolai Weibull
@ 2015-02-16 9:05 ` Nicolas Goaziou
2015-08-19 23:37 ` Nikolai Weibull
` (3 more replies)
0 siblings, 4 replies; 18+ messages in thread
From: Nicolas Goaziou @ 2015-02-16 9:05 UTC (permalink / raw)
To: Nikolai Weibull; +Cc: emacs-orgmode
Hello,
Nikolai Weibull <now@disu.se> writes:
> Sorry for the late reply. Here’s a patch that should work:
Thank you.
Could you provide an appropriate commit message and send it using git
format-patch? If you haven't signed FSF papers yet, you also need to add
TINYCHANGE at the end of the commit message.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock
2015-02-16 9:05 ` Nicolas Goaziou
@ 2015-08-19 23:37 ` Nikolai Weibull
2015-08-20 17:02 ` Nikolai Weibull
` (2 subsequent siblings)
3 siblings, 0 replies; 18+ messages in thread
From: Nikolai Weibull @ 2015-08-19 23:37 UTC (permalink / raw)
To: Nikolai Weibull, emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 516 bytes --]
Attached, finally. My FSF papers are signed.
On Mon, Feb 16, 2015 at 10:05 AM, Nicolas Goaziou
<mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Nikolai Weibull <now@disu.se> writes:
>
>> Sorry for the late reply. Here’s a patch that should work:
>
> Thank you.
>
> Could you provide an appropriate commit message and send it using git
> format-patch? If you haven't signed FSF papers yet, you also need to add
> TINYCHANGE at the end of the commit message.
>
> Regards,
>
> --
> Nicolas Goaziou
[-- Attachment #2: 0001-Redo-Agenda-in-more-cases-even-in-sticky-mode.patch --]
[-- Type: application/octet-stream, Size: 1262 bytes --]
From 452641e5f9d4d6f98ef3302178f990dfdffaecd3 Mon Sep 17 00:00:00 2001
From: Nikolai Weibull <now@disu.se>
Date: Wed, 19 Aug 2015 22:48:54 +0200
Subject: [PATCH] Redo Agenda in more cases even in sticky mode
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* org-agenda.el (org-agenda-maybe-redo): Test for
org-agenda-this-buffer-name as well.
The Agenda buffer will have a different name if it’s in sticky mode,
but some commands that alter the agenda should still redo it, for
example, org-agenda-remove-restriction-lock, just like
org-agenda-filter-by-category does.
---
lisp/org-agenda.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 07b77ac..5fd1cd4 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7169,7 +7169,9 @@ in the file. Otherwise, restriction will be to the current subtree."
(defun org-agenda-maybe-redo ()
"If there is any window showing the agenda view, update it."
- (let ((w (get-buffer-window org-agenda-buffer-name t))
+ (let ((w (get-buffer-window (or org-agenda-this-buffer-name
+ org-agenda-buffer-name)
+ t))
(w0 (selected-window)))
(when w
(select-window w)
--
2.5.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock
2015-02-16 9:05 ` Nicolas Goaziou
2015-08-19 23:37 ` Nikolai Weibull
@ 2015-08-20 17:02 ` Nikolai Weibull
2015-08-20 17:02 ` [PATCH 1/2] Redo Agenda in more cases even in sticky mode Nikolai Weibull
2015-08-20 17:21 ` Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock Bastien
2015-08-20 18:22 ` [PATCH 1/2] Redo Agenda in more cases even in sticky mode Nikolai Weibull
2015-08-20 18:25 ` Nikolai Weibull
3 siblings, 2 replies; 18+ messages in thread
From: Nikolai Weibull @ 2015-08-20 17:02 UTC (permalink / raw)
To: emacs-orgmode
Here’s the patch again, as I don’t think the one I sent yesterday got
through. My FSF papers are signed, by the way.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/2] Redo Agenda in more cases even in sticky mode
2015-08-20 17:02 ` Nikolai Weibull
@ 2015-08-20 17:02 ` Nikolai Weibull
2015-08-20 17:21 ` Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock Bastien
1 sibling, 0 replies; 18+ messages in thread
From: Nikolai Weibull @ 2015-08-20 17:02 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Nikolai Weibull
* org-agenda.el (org-agenda-maybe-redo): Test for
org-agenda-this-buffer-name as well.
The Agenda buffer will have a different name if it’s in sticky mode,
but some commands that alter the agenda should still redo it, for
example, org-agenda-remove-restriction-lock, just like
org-agenda-filter-by-category does.
---
lisp/org-agenda.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 07b77ac..5fd1cd4 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7169,7 +7169,9 @@ in the file. Otherwise, restriction will be to the current subtree."
(defun org-agenda-maybe-redo ()
"If there is any window showing the agenda view, update it."
- (let ((w (get-buffer-window org-agenda-buffer-name t))
+ (let ((w (get-buffer-window (or org-agenda-this-buffer-name
+ org-agenda-buffer-name)
+ t))
(w0 (selected-window)))
(when w
(select-window w)
--
2.5.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock
2015-08-20 17:02 ` Nikolai Weibull
2015-08-20 17:02 ` [PATCH 1/2] Redo Agenda in more cases even in sticky mode Nikolai Weibull
@ 2015-08-20 17:21 ` Bastien
2015-08-20 18:31 ` Nikolai Weibull
1 sibling, 1 reply; 18+ messages in thread
From: Bastien @ 2015-08-20 17:21 UTC (permalink / raw)
To: Nikolai Weibull; +Cc: emacs-orgmode
Hi Nikolai,
> Here’s the patch again, as I don’t think the one I sent yesterday got
> through. My FSF papers are signed, by the way.
It looks like you forgot to attach the patch...
--
Bastien
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/2] Redo Agenda in more cases even in sticky mode
2015-02-16 9:05 ` Nicolas Goaziou
2015-08-19 23:37 ` Nikolai Weibull
2015-08-20 17:02 ` Nikolai Weibull
@ 2015-08-20 18:22 ` Nikolai Weibull
2015-08-20 18:25 ` Nikolai Weibull
3 siblings, 0 replies; 18+ messages in thread
From: Nikolai Weibull @ 2015-08-20 18:22 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Nikolai Weibull
* org-agenda.el (org-agenda-maybe-redo): Test for
org-agenda-this-buffer-name as well.
The Agenda buffer will have a different name if it’s in sticky mode,
but some commands that alter the agenda should still redo it, for
example, org-agenda-remove-restriction-lock, just like
org-agenda-filter-by-category does.
---
lisp/org-agenda.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 07b77ac..5fd1cd4 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7169,7 +7169,9 @@ in the file. Otherwise, restriction will be to the current subtree."
(defun org-agenda-maybe-redo ()
"If there is any window showing the agenda view, update it."
- (let ((w (get-buffer-window org-agenda-buffer-name t))
+ (let ((w (get-buffer-window (or org-agenda-this-buffer-name
+ org-agenda-buffer-name)
+ t))
(w0 (selected-window)))
(when w
(select-window w)
--
2.5.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 1/2] Redo Agenda in more cases even in sticky mode
2015-02-16 9:05 ` Nicolas Goaziou
` (2 preceding siblings ...)
2015-08-20 18:22 ` [PATCH 1/2] Redo Agenda in more cases even in sticky mode Nikolai Weibull
@ 2015-08-20 18:25 ` Nikolai Weibull
3 siblings, 0 replies; 18+ messages in thread
From: Nikolai Weibull @ 2015-08-20 18:25 UTC (permalink / raw)
To: emacs-orgmode
* org-agenda.el (org-agenda-maybe-redo): Test for
org-agenda-this-buffer-name as well.
The Agenda buffer will have a different name if it’s in sticky mode,
but some commands that alter the agenda should still redo it, for
example, org-agenda-remove-restriction-lock, just like
org-agenda-filter-by-category does.
---
lisp/org-agenda.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 07b77ac..5fd1cd4 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7169,7 +7169,9 @@ in the file. Otherwise, restriction will be to the current subtree."
(defun org-agenda-maybe-redo ()
"If there is any window showing the agenda view, update it."
- (let ((w (get-buffer-window org-agenda-buffer-name t))
+ (let ((w (get-buffer-window (or org-agenda-this-buffer-name
+ org-agenda-buffer-name)
+ t))
(w0 (selected-window)))
(when w
(select-window w)
--
2.5.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock
2015-08-20 17:21 ` Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock Bastien
@ 2015-08-20 18:31 ` Nikolai Weibull
2015-08-23 7:56 ` Nicolas Goaziou
0 siblings, 1 reply; 18+ messages in thread
From: Nikolai Weibull @ 2015-08-20 18:31 UTC (permalink / raw)
To: Bastien; +Cc: emacs-orgmode
I am so disappointed with everything that has to do with e-mail right
now. For some reason the e-mail isn’t being delivered. I assume it’s
not being accepted by the mailing list, but I can’t see why. I’m not
getting any error message.
Anyway, here’s the relevant part (and let’s see if this e-mail gets through):
* org-agenda.el (org-agenda-maybe-redo): Test for
org-agenda-this-buffer-name as well.
The Agenda buffer will have a different name if it’s in sticky mode,
but some commands that alter the agenda should still redo it, for
example, org-agenda-remove-restriction-lock, just like
org-agenda-filter-by-category does.
---
lisp/org-agenda.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 07b77ac..5fd1cd4 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7169,7 +7169,9 @@ in the file. Otherwise, restriction will be to
the current subtree."
(defun org-agenda-maybe-redo ()
"If there is any window showing the agenda view, update it."
- (let ((w (get-buffer-window org-agenda-buffer-name t))
+ (let ((w (get-buffer-window (or org-agenda-this-buffer-name
+ org-agenda-buffer-name)
+ t))
(w0 (selected-window)))
(when w
(select-window w)
--
2.5.0
On Thu, Aug 20, 2015 at 7:21 PM, Bastien <bzg@gnu.org> wrote:
> Hi Nikolai,
>
>> Here’s the patch again, as I don’t think the one I sent yesterday got
>> through. My FSF papers are signed, by the way.
>
> It looks like you forgot to attach the patch...
>
> --
> Bastien
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock
2015-08-20 18:31 ` Nikolai Weibull
@ 2015-08-23 7:56 ` Nicolas Goaziou
0 siblings, 0 replies; 18+ messages in thread
From: Nicolas Goaziou @ 2015-08-23 7:56 UTC (permalink / raw)
To: Nikolai Weibull; +Cc: Bastien, emacs-orgmode
Hello,
Nikolai Weibull <now@disu.se> writes:
> * org-agenda.el (org-agenda-maybe-redo): Test for
> org-agenda-this-buffer-name as well.
>
> The Agenda buffer will have a different name if it’s in sticky mode,
> but some commands that alter the agenda should still redo it, for
> example, org-agenda-remove-restriction-lock, just like
> org-agenda-filter-by-category does.
Applied. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2015-08-23 7:54 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-22 18:10 Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock Nikolai Weibull
2015-01-07 17:51 ` Nikolai Weibull
2015-01-18 9:55 ` Nikolai Weibull
2015-01-18 10:26 ` Nicolas Goaziou
2015-01-18 13:27 ` Nikolai Weibull
2015-01-18 22:39 ` Nicolas Goaziou
2015-01-19 9:33 ` Nikolai Weibull
2015-01-19 17:38 ` Nicolas Goaziou
2015-02-15 21:54 ` Nikolai Weibull
2015-02-16 9:05 ` Nicolas Goaziou
2015-08-19 23:37 ` Nikolai Weibull
2015-08-20 17:02 ` Nikolai Weibull
2015-08-20 17:02 ` [PATCH 1/2] Redo Agenda in more cases even in sticky mode Nikolai Weibull
2015-08-20 17:21 ` Sticky agendas not redone when using org-agenda-(set|remove)-restriction-lock Bastien
2015-08-20 18:31 ` Nikolai Weibull
2015-08-23 7:56 ` Nicolas Goaziou
2015-08-20 18:22 ` [PATCH 1/2] Redo Agenda in more cases even in sticky mode Nikolai Weibull
2015-08-20 18:25 ` Nikolai Weibull
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).