From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolai Weibull Subject: Re: org-agenda-insert-diary-make-new-entry adds entry as first child? Date: Sat, 7 Mar 2015 22:49:51 +0100 Message-ID: References: <87vbsnmpqo.fsf@bzg.ath.cx> <8761kn8ir9.fsf@bzg.ath.cx> <87wqd3s30s.fsf@bzg.ath.cx> <87ha21xuob.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUMbZ-0007rK-9w for emacs-orgmode@gnu.org; Sat, 07 Mar 2015 16:49:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUMbY-0002q7-Ek for emacs-orgmode@gnu.org; Sat, 07 Mar 2015 16:49:53 -0500 In-Reply-To: <87ha21xuob.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org On Mon, Jul 28, 2014 at 4:20 PM, Bastien wrote: > Nikolai Weibull writes: > >> Here=E2=80=99s a suggested solution. We keep track of whether the paren= t >> entry already has any children, then we call org-insert-heading with >> two universal arguments to add an entry at the end of the current >> subtree. Finally, if there weren=E2=80=99t any children already, we dem= ote >> the entry we added so that it becomes a child of the parent entry. > > Finally applied in master, thanks, Hi! It seems that this was reverted in 3e01c7ff1b37f1f548cc6c959160ff11302a25c7, but the log doesn=E2=80=99t say w= hy. Was there a specific reason? That is, was the original behavior desired but the patch was fine or was there a problem with the patch? Should I write a patch that adds another org-agenda-insert-diary-strategy called 'date-entry-last or something like that? Thanks!