From mboxrd@z Thu Jan 1 00:00:00 1970 From: Allen Li Subject: Re: Bug: org-agenda-overriding-columns-format destroyed on revert [9.2.1 (9.2.1-2-gc6d37c-elpaplus)] Date: Sun, 17 Feb 2019 01:24:59 +0000 Message-ID: References: <808syk5cis.fsf@felesatra.moe> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000000693c705820ce142" Return-path: Received: from eggs.gnu.org ([209.51.188.92]:57481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvBCj-0005bA-DP for emacs-orgmode@gnu.org; Sat, 16 Feb 2019 20:25:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gvBCi-0001AN-A3 for emacs-orgmode@gnu.org; Sat, 16 Feb 2019 20:25:13 -0500 Received: from mail-it1-x132.google.com ([2607:f8b0:4864:20::132]:38062) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gvBCh-00019A-SX for emacs-orgmode@gnu.org; Sat, 16 Feb 2019 20:25:12 -0500 Received: by mail-it1-x132.google.com with SMTP id l66so23007622itg.3 for ; Sat, 16 Feb 2019 17:25:11 -0800 (PST) In-Reply-To: <808syk5cis.fsf@felesatra.moe> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Org Mode List --0000000000000693c705820ce142 Content-Type: text/plain; charset="UTF-8" On Wed, Feb 13, 2019 at 8:17 AM Allen Li wrote: > > 0. Make /tmp/tmp.org containing > > * TODO foo bar > > 1. emacs -Q > 2. Eval (setq org-agenda-custom-commands '(("n" "n" alltodo "" ((org-agenda-overriding-columns-format "%TODO"))))) > 3. Eval (setq org-agenda-files '("/tmp/tmp.org")) > 4. M-x org-agenda RET n > 5. Move point to item > 6. C-c C-x C-c (column view) > 7. g > > Expected: > > Column format is preserved > > Actual: > > Column format is reset > > (The example uses the version of Org shipped with Emacs, but I can > reproduce with my personal config using latest org-contrib-plus) I think the right way to fix this is by using a separate variable for setting buffer local values. I have attached a patch implementing this on maint. > > Emacs : GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30) > of 2018-07-05 > Package: Org mode version 9.2.1 (9.2.1-2-gc6d37c-elpaplus @ /home/ionasal/.emacs.d/elpa/org-plus-contrib-20190204/) --0000000000000693c705820ce142 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-buffer-local-org-agenda-overriding-columns-forma.patch" Content-Disposition: attachment; filename="0001-Fix-buffer-local-org-agenda-overriding-columns-forma.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_js889vd10 RnJvbSBlYmE4N2Y5ZGU4N2NjNjYxYzk5ZDEyZWYzMWI5NjFjMzZiM2Q1MjhiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxlbiBMaSA8ZGFya2ZlbGluZUBmZWxlc2F0cmEubW9lPgpE YXRlOiBTYXQsIDE2IEZlYiAyMDE5IDE3OjIxOjA0IC0wODAwClN1YmplY3Q6IFtQQVRDSF0gRml4 IGJ1ZmZlciBsb2NhbCBvcmctYWdlbmRhLW92ZXJyaWRpbmctY29sdW1ucy1mb3JtYXQgYnVnCgpT ZXR0aW5nIG9yZy1hZ2VuZGEtb3ZlcnJpZGluZy1jb2x1bW5zLWZvcm1hdCBhcyBhIGJ1ZmZlciBs b2NhbCB2YWx1ZQppbnRlcmZlcmVzIHdpdGggaG93IGl0IGlzIHVzZWQgYXMgYSBkeW5hbWljYWxs eSBzY29wZWQgdmFyLCBzbyB1c2UgYQpzZXBhcmF0ZSB2YXJpYWJsZSBmb3IgYnVmZmVyIGxvY2Fs IHNldHRpbmcuCi0tLQogbGlzcC9vcmctYWdlbmRhLmVsICB8IDMgKystCiBsaXNwL29yZy1jb2x2 aWV3LmVsIHwgOSArKysrKysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwg MiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL29yZy1hZ2VuZGEuZWwgYi9saXNwL29y Zy1hZ2VuZGEuZWwKaW5kZXggNDg5ZWNlYzk1Li4wNTRjMGIyNjggMTAwNjQ0Ci0tLSBhL2xpc3Av b3JnLWFnZW5kYS5lbAorKysgYi9saXNwL29yZy1hZ2VuZGEuZWwKQEAgLTM3NjgsNiArMzc2OCw3 IEBAIEZJTFRFUi1BTElTVCBpcyBhbiBhbGlzdCBvZiBmaWx0ZXJzIHdlIG5lZWQgdG8gYXBwbHkg d2hlbgogICAgICAgKHNldHEgYnVmZmVyLXJlYWQtb25seSBuaWwpKSkpCiAKIChkZWZ2YXIgb3Jn LWFnZW5kYS1vdmVycmlkaW5nLWNvbHVtbnMtZm9ybWF0KSAgOyBGcm9tIG9yZy1jb2x2aWV3LmVs CisoZGVmdmFyIG9yZy1hZ2VuZGEtbG9jYWwtb3ZlcnJpZGluZy1jb2x1bW5zLWZvcm1hdCkgIDsg RnJvbSBvcmctY29sdmlldy5lbAogKGRlZnVuIG9yZy1hZ2VuZGEtZmluYWxpemUgKCkKICAgIkZp bmlzaGluZyB0b3VjaCBmb3IgdGhlIGFnZW5kYSBidWZmZXIsIGNhbGxlZCBqdXN0IGJlZm9yZSBk aXNwbGF5aW5nIGl0LiIKICAgKHVubGVzcyBvcmctYWdlbmRhLW11bHRpCkBAIC0zNzgzLDcgKzM3 ODQsNyBAQCBGSUxURVItQUxJU1QgaXMgYW4gYWxpc3Qgb2YgZmlsdGVycyB3ZSBuZWVkIHRvIGFw cGx5IHdoZW4KIAkodW5sZXNzIG9yZy1hZ2VuZGEtd2l0aC1jb2xvcnMKIAkgIChyZW1vdmUtdGV4 dC1wcm9wZXJ0aWVzIChwb2ludC1taW4pIChwb2ludC1tYXgpICcoZmFjZSBuaWwpKSkKIAkod2hl biAoYm91bmQtYW5kLXRydWUtcCBvcmctYWdlbmRhLW92ZXJyaWRpbmctY29sdW1ucy1mb3JtYXQp Ci0JICAoc2V0cS1sb2NhbCBvcmctYWdlbmRhLW92ZXJyaWRpbmctY29sdW1ucy1mb3JtYXQKKwkg IChzZXRxLWxvY2FsIG9yZy1hZ2VuZGEtbG9jYWwtb3ZlcnJpZGluZy1jb2x1bW5zLWZvcm1hdAog CQkgICAgICBvcmctYWdlbmRhLW92ZXJyaWRpbmctY29sdW1ucy1mb3JtYXQpKQogCSh3aGVuIG9y Zy1hZ2VuZGEtdmlldy1jb2x1bW5zLWluaXRpYWxseQogCSAgKG9yZy1hZ2VuZGEtY29sdW1ucykp CmRpZmYgLS1naXQgYS9saXNwL29yZy1jb2x2aWV3LmVsIGIvbGlzcC9vcmctY29sdmlldy5lbApp bmRleCA3NDY0MjZiYzcuLjJmYmI1YWE2YyAxMDA2NDQKLS0tIGEvbGlzcC9vcmctY29sdmlldy5l bAorKysgYi9saXNwL29yZy1jb2x2aWV3LmVsCkBAIC01NjcsNyArNTY3LDEzIEBAIGZvciB0aGUg ZHVyYXRpb24gb2YgdGhlIGNvbW1hbmQuIikKIAogKGRlZnZhciBvcmctYWdlbmRhLW92ZXJyaWRp bmctY29sdW1ucy1mb3JtYXQgbmlsCiAgICJXaGVuIHNldCwgb3ZlcnJpZGVzIGFueSBvdGhlciBm b3JtYXQgZGVmaW5pdGlvbiBmb3IgdGhlIGFnZW5kYS4KLURvbid0IHNldCB0aGlzLCB0aGlzIGlz IG1lYW50IGZvciBkeW5hbWljIHNjb3BpbmcuIikKK0Rvbid0IHNldCB0aGlzLCB0aGlzIGlzIG1l YW50IGZvciBkeW5hbWljIHNjb3BpbmcuICBTZXQKK2BvcmctYWdlbmRhLWxvY2FsLW92ZXJyaWRp bmctY29sdW1ucy1mb3JtYXQnIGluc3RlYWQuIikKKworKGRlZnZhci1sb2NhbCBvcmctYWdlbmRh LWxvY2FsLW92ZXJyaWRpbmctY29sdW1ucy1mb3JtYXQgbmlsCisgICJXaGVuIHNldCwgb3ZlcnJp ZGVzIGFueSBvdGhlciBmb3JtYXQgZGVmaW5pdGlvbiBmb3IgdGhlIGFnZW5kYS4KK1RoaXMgY2Fu IGJlIHNldCBhcyBhIGJ1ZmZlciBsb2NhbCB2YWx1ZSB0byBhdm9pZCBpbnRlcmZlcmluZyB3aXRo CitkeW5hbWljIHNjb3BpbmcgZm9yIGBvcmctYWdlbmRhLW92ZXJyaWRpbmctY29sdW1ucy1mb3Jt YXQnLiIpCiAKIChkZWZ1biBvcmctY29sdW1ucy1lZGl0LXZhbHVlICgmb3B0aW9uYWwga2V5KQog ICAiRWRpdCB0aGUgdmFsdWUgb2YgdGhlIHByb3BlcnR5IGF0IHBvaW50IGluIGNvbHVtbiB2aWV3 LgpAQCAtMTU2NCw2ICsxNTcwLDcgQEAgUEFSQU1TIGlzIGEgcHJvcGVydHkgbGlzdCBvZiBwYXJh bWV0ZXJzOgogCSAoZm10CiAJICAoY29uZAogCSAgICgoYm91bmQtYW5kLXRydWUtcCBvcmctYWdl bmRhLW92ZXJyaWRpbmctY29sdW1ucy1mb3JtYXQpKQorCSAgICgoYm91bmQtYW5kLXRydWUtcCBv cmctYWdlbmRhLWxvY2FsLW92ZXJyaWRpbmctY29sdW1ucy1mb3JtYXQpKQogCSAgICgobGV0ICgo bSAob3JnLWdldC1hdC1ib2wgJ29yZy1oZC1tYXJrZXIpKSkKIAkgICAgICAoYW5kIG0KIAkJICAg KG9yIChvcmctZW50cnktZ2V0IG0gIkNPTFVNTlMiIHQpCi0tIAoyLjIwLjEKCg== --0000000000000693c705820ce142--