From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KBt3HVzht2L8ugAAbAwnHQ (envelope-from ) for ; Sun, 26 Jun 2022 06:32:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KLFeHVzht2JXhgEAauVa8A (envelope-from ) for ; Sun, 26 Jun 2022 06:32:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0507E3C4DD for ; Sun, 26 Jun 2022 06:32:28 +0200 (CEST) Received: from localhost ([::1]:60658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5Jwg-0001mN-TN for larch@yhetil.org; Sun, 26 Jun 2022 00:32:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5Jv2-0001g9-5x for emacs-orgmode@gnu.org; Sun, 26 Jun 2022 00:30:44 -0400 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]:44946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5Jv0-0002IJ-25 for emacs-orgmode@gnu.org; Sun, 26 Jun 2022 00:30:43 -0400 Received: by mail-ed1-x530.google.com with SMTP id z19so8621997edb.11 for ; Sat, 25 Jun 2022 21:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Idnw1DW3tovZXEsdgnAibibJf9E3w3PoiTQBfa68Pq0=; b=viUxqJUyfri6wnoVqUQDSI5/fk+/LChC7yWJlvZEdmshqA795Qap39sF2suvBlGiAX P30ubsf0GWazV6W1Yp8ZkZVd7ZpYxbxeUtYskbJzD+Ett/VjyDnrMIc54fEdc0d2lYH1 b/Tx9k81/g9GC3Yf9OO8SbTRyUfRTKTGqwpPfJYihtAUe/9/gnwxWDhFQ+jE0SS9EF7d H9msdGdKbhQ9nFkhH5ornoSotRgXPSjG0tQB7Dh0ayHfi2qbuv6Hx2cVz9mVDlyepw2G azpLl3jjbQXGIarRP8tjWzjzmgFRru78Cv/HxyBBLe1ToJGHoOKx+t/sVF0MecgyZFcb FEBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Idnw1DW3tovZXEsdgnAibibJf9E3w3PoiTQBfa68Pq0=; b=abOlvg+QVQz08n8kUsbHGWniR7/cWaFe5QU/szo8OGaHGFdB5D8WZO1uudyQiXCM0b yGcTcV0loNKVmbAjx+G5LjPBQy71cgPHohQFleKeL1X7BpbqIy12gXW2TcLnfXoRR//8 BBd2G3CdvXhiUU+XiWzKC0s9t4fm6JVRnHvS7oRYbpuyOBJszQA6v2uYb747RfknxwFh LCLsphZuWkVts6FAJtW+jCmohThwWf3jXnYlfnQaQ0BoZdu8w5d4phXIlLGktXqlrKDF lbsdS5so7EkrdCessDDnYGYhmkW0KsoiRVq7taD5DSGUOd5aGndKbuAPSmGeqq4LZT5s VAuw== X-Gm-Message-State: AJIora9hW1Ju6zoM9Oqpns1hmtztC0xSSjGoqFym4K/MQra+Q2o9I42K eiZBpnrFKHjUcsqlZ8fW+GUVoX5F4FeEiUEQgSULdQ== X-Google-Smtp-Source: AGRyM1tW0l+MBnUE+k7pQVbIsw2wibUsjXznSQmlXM9rvUBOOcImhMWa33DRrdaYItYtKdKS8qjdXaSuIBH2BBQ7EBY= X-Received: by 2002:a05:6402:3988:b0:434:e2a8:8459 with SMTP id fk8-20020a056402398800b00434e2a88459mr8840505edb.253.1656217840576; Sat, 25 Jun 2022 21:30:40 -0700 (PDT) MIME-Version: 1.0 References: <80o84vol8s.fsf@felesatra.moe> <87h79a3gxp.fsf@localhost> <87zgiav6wn.fsf@localhost> In-Reply-To: <87zgiav6wn.fsf@localhost> From: Allen Li Date: Sat, 25 Jun 2022 21:30:29 -0700 Message-ID: Subject: Re: [BUG] org-todo (C-c C-t) bad negative prefix behavior [9.5.2 (9.5.2-gfbff08 @ /home/ionasal/.emacs.d/elpa/org-9.5.2/)] To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Content-Type: multipart/mixed; boundary="0000000000000f115d05e25244da" Received-SPF: pass client-ip=2a00:1450:4864:20::530; envelope-from=darkfeline@felesatra.moe; helo=mail-ed1-x530.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656217948; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=P3OcdqIMhrTFicoM+PjKCoBeOAcQgd8K88fw7hgDORg=; b=DXi3yGnxpfVg6umR/uT3L1SZ/FbGT963rACYyLP7wwI6glCUvOKwXeIiVl9CWej2Md8Wrp abclNDFWoV4P1KPC1ZNq3h9EHcJU3JmV/Yv4GNADCBmnIRJh9hhocRbxrhO9e8qhgZGciA gcBSpf3CKZa7zEAnTHYggneriTZfResWogQz3pPL5zRpYvegRuqi5L6lp22gPcslQ5MOsC E2AP6/UK2HQWZZz+HcVOOQJajTUR8N4qxOHdvsBhLNgAoJCSSRip1jld8qBaMSHfvCgTsa +pcn6yuHyJVj9YpX8VciA0L/yJpcZ9LxItzC+4wfYf1qSJt0aTfvHKi+1rSidQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656217948; a=rsa-sha256; cv=none; b=RpGNHaSt72L/Zf87pR+iTJaMVN661t8PN7IBeBOpe34LD12Vdz9ypBm1jBg8UZ87UVQDcW RqwNfRLR/vsMFFGeDxdtqXtV2lIkO2RDI7ajGqiupqnCXRs0N3vvUO80SQbG6rOOOmWaqH OpIiWWiO+c32ZxWg7v4qCsFw36wqqbPI1MKxPEXK8Ykmoj6pxqPfClwWs0ES+SzBJH3z4x umjOC9jkHiBdmQlGiFvbR0wrDfLAP7waVsyL3MxQ7ti1u4SyIz+vBKnNjofuHU3qwjwCW2 hU21izwuz+E+/lhxH+bSW13XbCvmxhJEFdElqFuRVa2V6MEuEmVV9STLsBa7iQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=felesatra-moe.20210112.gappssmtp.com header.s=20210112 header.b=viUxqJUy; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.14 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=felesatra-moe.20210112.gappssmtp.com header.s=20210112 header.b=viUxqJUy; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0507E3C4DD X-Spam-Score: 3.14 X-Migadu-Scanner: scn0.migadu.com X-TUID: fwEsK+zEUS8a --0000000000000f115d05e25244da Content-Type: multipart/alternative; boundary="0000000000000f115b05e25244d8" --0000000000000f115b05e25244d8 Content-Type: text/plain; charset="UTF-8" On Fri, Jun 17, 2022 at 11:09 PM Ihor Radchenko wrote: > Ihor Radchenko writes: > > > Allen Li writes: > > > >> On Sat, Jan 1, 2022 at 9:31 AM Allen Li > wrote: > >> > >>> It seems like the right fix here is to make - behave the same as -1, > and > >>> raise a user error for any other negative numeric prefix, since it is > >>> likely not doing whatever the user wanted. > >>> > >> > >> Attached a small patch fixing this, which I tested manually. > > Applied onto main via bfd63cc4f. > > Would you also be interested to write a test checking org-todo ARGS? > Attached > > Best, > Ihor > --0000000000000f115b05e25244d8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Jun 17, 2022 at 11:09 PM Ihor Rad= chenko <yantar92@gmail.com>= wrote:
Ihor Radchenko <yantar92@gmail.com> writes:

> Allen Li <darkfeline@felesatra.moe> writes:
>
>> On Sat, Jan 1, 2022 at 9:31 AM Allen Li <darkfeline@felesatra.m= oe> wrote:
>>
>>> It seems like the right fix here is to make - behave the same = as -1, and
>>> raise a user error for any other negative numeric prefix, sinc= e it is
>>> likely not doing whatever the user wanted.
>>>
>>
>> Attached a small patch fixing this, which I tested manually.

Applied onto main via bfd63cc4f.

Would you also be interested to write a test checking org-todo ARGS?

Attached
=C2=A0

Best,
Ihor
--0000000000000f115b05e25244d8-- --0000000000000f115d05e25244da Content-Type: text/x-patch; charset="US-ASCII"; name="0001-test-org-Add-test-for-org-todo-prefix-behavior.patch" Content-Disposition: attachment; filename="0001-test-org-Add-test-for-org-todo-prefix-behavior.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l4utbdzk0 RnJvbSA5MjU1ODE5ZWUwNWI5ZjJiZGJlOGRlMWNmMGFjYmQ2YWU2NTUzMTUyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxlbiBMaSA8ZGFya2ZlbGluZUBmZWxlc2F0cmEubW9lPgpE YXRlOiBTYXQsIDI1IEp1biAyMDIyIDIxOjI3OjIwIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gdGVz dC1vcmc6IEFkZCB0ZXN0IGZvciBvcmctdG9kbyBwcmVmaXggYmVoYXZpb3IKCiogdGVzdGluZy9s aXNwL3Rlc3Qtb3JnLmVsICh0ZXN0LW9yZy9vcmctdG9kby1wcmVmaXgpOiBBZGQgdGVzdC4KLS0t CiB0ZXN0aW5nL2xpc3AvdGVzdC1vcmcuZWwgfCAxOSArKysrKysrKysrKysrKysrKysrCiAxIGZp bGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3Rlc3RpbmcvbGlzcC90 ZXN0LW9yZy5lbCBiL3Rlc3RpbmcvbGlzcC90ZXN0LW9yZy5lbAppbmRleCAxMjFmOWVmZDUuLjMw NGRkZGMwOCAxMDA2NDQKLS0tIGEvdGVzdGluZy9saXNwL3Rlc3Qtb3JnLmVsCisrKyBiL3Rlc3Rp bmcvbGlzcC90ZXN0LW9yZy5lbApAQCAtNzc1Myw2ICs3NzUzLDI1IEBAIENMT1NFRDogJXMKICAg ICAgICAgICAob3JnLWFkZC1sb2ctbm90ZSkpCiAgICAgICAgIChidWZmZXItc3RyaW5nKSkpKSkp CiAKKyhlcnQtZGVmdGVzdCB0ZXN0LW9yZy9vcmctdG9kby1wcmVmaXggKCkKKyAgIlRlc3QgYG9y Zy10b2RvJyBwcmVmaXggYXJnIGJlaGF2aW9yLiIKKyAgOzsgLTEgcHJlZml4IGFyZyBzaG91bGQg Y2FuY2VsIHJlcGVhdGVyIGFuZCBtYXJrIERPTkUuCisgIChzaG91bGQtbm90CisgICAoc3RyaW5n LXByZWZpeC1wCisgICAgIiogVE9ETyBIIgorICAgIChsZXQgKChvcmctdG9kby1rZXl3b3JkcyAn KChzZXF1ZW5jZSAiVE9ETyIgIkRPTkUiKSkpKQorICAgICAgKG9yZy10ZXN0LXdpdGgtdGVtcC10 ZXh0ICIqIFRPRE8gSFxuPDIwMTItMDMtMjkgVGh1ICsyeT4iCisJICAgICAgICAgICAgICAgICAg ICAgICAob3JnLXRvZG8gLTEpCisJICAgICAgICAgICAgICAgICAgICAgICAoYnVmZmVyLXN0cmlu ZykpKSkpCisgIDs7IC0gcHJlZml4IGFyZyBzaG91bGQgY2FuY2VsIHJlcGVhdGVyIGFuZCBtYXJr IERPTkUuCisgIChzaG91bGQtbm90CisgICAoc3RyaW5nLXByZWZpeC1wCisgICAgIiogVE9ETyBI IgorICAgIChsZXQgKChvcmctdG9kby1rZXl3b3JkcyAnKChzZXF1ZW5jZSAiVE9ETyIgIkRPTkUi KSkpKQorICAgICAgKG9yZy10ZXN0LXdpdGgtdGVtcC10ZXh0ICIqIFRPRE8gSFxuPDIwMTItMDMt MjkgVGh1ICsyeT4iCisJICAgICAgICAgICAgICAgICAgICAgICAob3JnLXRvZG8gJy0pCisJICAg ICAgICAgICAgICAgICAgICAgICAoYnVmZmVyLXN0cmluZykpKSkpKQorCiAMCiA7OzsgVGltZXN0 YW1wcyBBUEkKIAotLSAKMi4zNi4xCgo= --0000000000000f115d05e25244da--