From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Zhao Subject: Patch to fix `org-test-with-temp-text' Date: Wed, 9 Apr 2014 18:39:06 -0400 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=047d7b6700afac7aa404f6a3c4a0 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50253) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WY19A-00032U-LS for emacs-orgmode@gnu.org; Wed, 09 Apr 2014 18:39:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WY199-0000I8-H6 for emacs-orgmode@gnu.org; Wed, 09 Apr 2014 18:39:08 -0400 Received: from mail-vc0-x236.google.com ([2607:f8b0:400c:c03::236]:43158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WY199-0000I4-CJ for emacs-orgmode@gnu.org; Wed, 09 Apr 2014 18:39:07 -0400 Received: by mail-vc0-f182.google.com with SMTP id ib6so2763287vcb.13 for ; Wed, 09 Apr 2014 15:39:06 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode --047d7b6700afac7aa404f6a3c4a0 Content-Type: text/plain; charset=UTF-8 Hi list, I've just found a bug in `org-test-with-temp-text' and have fixed it. Please find attached my patch for the fix. Here's the description from git commit message: According to the docstring, if the string "" appears in TEXT then the string "" is removed and point is placed there. The problem was that after string "" was removed, the point was *not* placed at the position of the removed text, rather, it was placed one character before that position which is wrong. The reason is that Emacs buffer position is a number started from 1, instead of 0, in other words, the value of `(point-min)' is 1 not 0. The problem is addressed by adding 1 to the calculated position. I'm going to report another bug together with a reproducer written as an "org-test". But my test relies on my fix in `org-test-with-temp-text'. Therefor, I will appreciate it if this patch can be taken care of as soon as possible. Thank you, York --047d7b6700afac7aa404f6a3c4a0 Content-Type: text/x-diff; charset=US-ASCII; name="0001-testing-org-test.el-org-test-with-temp-text-Fix-poin.patch" Content-Disposition: attachment; filename="0001-testing-org-test.el-org-test-with-temp-text-Fix-poin.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_htt76j4e0 RnJvbSA5YmJmYzM3YWIwNTllOTIzYzU3ZWFhOTllM2EyZDgxMTQ0YzgwMjE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBZb3JrIFpoYW8gPGd0ZHBsYXRmb3JtQGdtYWlsLmNvbT4KRGF0 ZTogV2VkLCA5IEFwciAyMDE0IDEzOjM5OjE2IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gdGVzdGlu Zy9vcmctdGVzdC5lbCAob3JnLXRlc3Qtd2l0aC10ZW1wLXRleHQpOiBGaXggcG9pbnQKIHBvc2l0 aW9uCgpBY2NvcmRpbmcgdG8gdGhlIGRvY3N0cmluZywgaWYgdGhlIHN0cmluZyAiPHBvaW50PiIg YXBwZWFycyBpbiBURVhUCnRoZW4gdGhlIHN0cmluZyAiPHBvaW50PiIgaXMgcmVtb3ZlZCBhbmQg cG9pbnQgaXMgcGxhY2VkIHRoZXJlLiBUaGUKcHJvYmxlbSB3YXMgdGhhdCBhZnRlciBzdHJpbmcg Ijxwb2ludD4iIHdhcyByZW1vdmVkLCB0aGUgcG9pbnQKd2FzICpub3QqIHBsYWNlZCBhdCB0aGUg cG9zaXRpb24gb2YgdGhlIHJlbW92ZWQgdGV4dCwgcmF0aGVyLCBpdCB3YXMKcGxhY2VkIG9uZSBj aGFyYWN0ZXIgYmVmb3JlIHRoYXQgcG9zaXRpb24gd2hpY2ggaXMgd3JvbmcuIFRoZSByZWFzb24K aXMgdGhhdCBFbWFjcyBidWZmZXIgcG9zaXRpb24gaXMgYSBudW1iZXIgc3RhcnRlZCBmcm9tIDEs IGluc3RlYWQgb2YKMCwgaW4gb3RoZXIgd29yZHMsIHRoZSB2YWx1ZSBvZiBgKHBvaW50LW1pbikn IGlzIDEgbm90IDAuIFRoZSBwcm9ibGVtCmlzIGFkZHJlc3NlZCBieSBhZGRpbmcgMSB0byB0aGUg Y2FsY3VsYXRlZCBwb3NpdGlvbi4KClRJTllDSEFOR0UKLS0tCiB0ZXN0aW5nL29yZy10ZXN0LmVs IHwgMTEgKysrKysrLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDUgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvdGVzdGluZy9vcmctdGVzdC5lbCBiL3Rlc3Rpbmcvb3Jn LXRlc3QuZWwKaW5kZXggODc5ZDQ1ZS4uOTgzYzAxMiAxMDA2NDQKLS0tIGEvdGVzdGluZy9vcmct dGVzdC5lbAorKysgYi90ZXN0aW5nL29yZy10ZXN0LmVsCkBAIC0yMDksMTEgKzIwOSwxMiBAQCBv dGhlcndpc2UgcGxhY2UgdGhlIHBvaW50IGF0IHRoZSBiZWdpbm5pbmcgb2YgdGhlIGluc2VydGVk IHRleHQuIgogICAgICAod2l0aC10ZW1wLWJ1ZmZlcgogICAgICAgIChvcmctbW9kZSkKICAgICAg ICAobGV0ICgocG9pbnQgKHN0cmluZy1tYXRjaCAocmVnZXhwLXF1b3RlICI8cG9pbnQ+IikgaW5z aWRlLXRleHQpKSkKLQkgIChpZiBwb2ludAotCSAgICAgIChwcm9nbiAoaW5zZXJ0IChyZXBsYWNl LW1hdGNoICIiIG5pbCBuaWwgaW5zaWRlLXRleHQpKQotCQkgICAgIChnb3RvLWNoYXIgKG1hdGNo LWJlZ2lubmluZyAwKSkpCi0JICAgIChwcm9nbiAoaW5zZXJ0IGluc2lkZS10ZXh0KQotCQkgICAo Z290by1jaGFyIChwb2ludC1taW4pKSkpKQorCSAoaWYgcG9pbnQKKwkgICAgIChwcm9nbgorCSAg ICAgICAoaW5zZXJ0IChyZXBsYWNlLW1hdGNoICIiIG5pbCBuaWwgaW5zaWRlLXRleHQpKQorCSAg ICAgICAoZ290by1jaGFyICgxKyAobWF0Y2gtYmVnaW5uaW5nIDApKSkpCisJICAgKHByb2duIChp bnNlcnQgaW5zaWRlLXRleHQpCisJCSAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkpKSkKICAgICAg ICAsQGJvZHkpKSkKIChkZWYtZWRlYnVnLXNwZWMgb3JnLXRlc3Qtd2l0aC10ZW1wLXRleHQgKGZv cm0gYm9keSkpCiAKLS0gCjEuOC40Cgo= --047d7b6700afac7aa404f6a3c4a0--