From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Zhao Subject: Re: Patch for testing `org-open-at-point' Date: Sat, 12 Apr 2014 10:22:02 -0400 Message-ID: References: <878urc0zmw.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYyuH-0008AJ-98 for emacs-orgmode@gnu.org; Sat, 12 Apr 2014 10:27:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYyol-0005wt-Mz for emacs-orgmode@gnu.org; Sat, 12 Apr 2014 10:22:04 -0400 In-Reply-To: <878urc0zmw.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode Hi Bastien, Sorry that I didn't know this was a known issue and I appreciate that you are willing to fix it. While I agree with Nicolas that it is more appropriate to keep org schedule line from being a headline property, I also think it is totally legitimate to have an org link as headline property. Sure we can always move org links out of headline properties, but I'm sure there are times we don't want to see some of the links all the time, we really want to hide them inside the property tree. For example, when we put a person's information as properties, like the following: * Peter :PROPERTIES: :ADDRESS: xxx xxx xxxx xxxx :HOME_PHONE: xxx xxx xxx :WORK_PHONE: xxx xxx xxx :URL: www.foo.bar :END: We hope we don't have to always move the link (the URL line in the properties tree) out, i.e., we don't want to see the link all the time. > Let's add tests when they don't fail :) Fair enough, just make sure it will not be forgotten. Thanks On Fri, Apr 11, 2014 at 6:25 AM, Bastien wrote: > Hi York, > > York Zhao writes: > >> I found a bug that `org-open-at-point' doesn't work if the link is a >> heading property. > > This is a known issue and we will address it soon. > >> This used to work and was broken recently. I have written a test for >> this. The test is suppose to fail in current org-mode version. Please find >> attached my patch for the test. Hopefully I I didn't place the test in the wrong >> file. > > Let's add tests when they don't fail :) > > -- > Bastien