emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Luciano Passuello <lucianop@litemind.com>
To: emacs-orgmode@gnu.org
Subject: Bug: Archiving items with org-attach-archive-delete set to 'query' always asks for confirmation
Date: Fri, 10 Aug 2018 14:26:56 -0300	[thread overview]
Message-ID: <CACqKfLeq8PE+F1yLB0YzEf4CCVv+qib5f3G0Px06WtVxqgSpcg@mail.gmail.com> (raw)

Hello,

When I set org-attach-archive-delete to query, Org is supposed to ask
me for confirmation when archiving entries with attachments. However,
I am always asked for confirmation,  regardless if the item has
attachments in the first place. This is to me clearly undesirable
behavior.

Looking at the source code for org-attach, at line 573, that's indeed
what code tells us.
https://code.orgmode.org/bzg/org-mode/src/master/lisp/org-attach.el

My uninformed suggestion is to call org-attach-delete-all without the
force parameter, using the confirmation code already in
org-attach-delete-all.

Unfortunately, I'm not skilled enough in Elisp or knowledgeable in Org
source code to provide a reasonable patch.

Thanks!

             reply	other threads:[~2018-08-10 17:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-10 17:26 Luciano Passuello [this message]
2018-08-11  1:43 ` Bug: Archiving items with org-attach-archive-delete set to 'query' always asks for confirmation Kyle Meyer
2018-08-11 19:53   ` Luciano Passuello
2018-08-15 22:52     ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACqKfLeq8PE+F1yLB0YzEf4CCVv+qib5f3G0Px06WtVxqgSpcg@mail.gmail.com \
    --to=lucianop@litemind.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).