From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jay Kamat Subject: Re: [PATCH] Support for 'using namespace *' in ob-C.el Date: Mon, 31 Jul 2017 22:54:57 -0700 Message-ID: References: <874lu3mcw7.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="001a113f2dbac2aec90555aaca1b" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcQ9I-0004H7-RW for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 01:55:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcQ9H-0006Jl-Bi for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 01:55:20 -0400 Received: from mail-io0-x230.google.com ([2607:f8b0:4001:c06::230]:38706) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dcQ9H-0006JP-4m for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 01:55:19 -0400 Received: by mail-io0-x230.google.com with SMTP id g13so4126055ioj.5 for ; Mon, 31 Jul 2017 22:55:18 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: "Charles C. Berry" Cc: emacs-orgmode@gnu.org, Nicolas Goaziou --001a113f2dbac2aec90555aaca1b Content-Type: text/plain; charset="UTF-8" Hi Chuck, Thanks for pointing that out, this all makes a lot more sense now. Prior to this patch ':includes' and ':defines' seem to work in the property list (as described in the old version of the org manual), so (I think) the updated version of this patch also removes those usages (for :defines, :includes), so you must use the new format described in the manual. Speaking of the manual, that entry managed to get me very confused at first, as it didn't seem to work for me, but then I realized that there is actually a typo in the NEWS entry, the second line should be: :header-args+: :var a=1 b=2 I'm not sure what the policy is on changing old NEWS entries, but I've attached a small patch to fix the typo. Let me know if you have any other feedback! :) -Jay On Mon, Jul 31, 2017 at 8:34 AM, Charles C. Berry wrote: > On Mon, 31 Jul 2017, Jay Kamat wrote: > >> Hello! >> >> Sorry for the late reply, I was pretty busy last week. An updated >> patch is attached! >> > > [snip] > >> >>> Using `org-entry-get' is no longer supported. You can replace the `or' >>> with >>> >>> (cdr (assq :namespaces params)) >> >> >> Done, I also replaced the other uses of 'org-entry-get' around the one >> I modified >> > > I don't think Nicolas meant that `org-entry-get' is no longer supported > literally. I think he was referring to using it to enable using Babel header > arguments as property names (as it did in your code). See: > > http://orgmode.org/Changes.html#org343de47 > > > HTH, > > Chuck --001a113f2dbac2aec90555aaca1b Content-Type: text/x-patch; charset="US-ASCII"; name="0001-ORG-NEWS-Fix-a-small-typo-in-new-org-babel-header-ex.patch" Content-Disposition: attachment; filename="0001-ORG-NEWS-Fix-a-small-typo-in-new-org-babel-header-ex.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j5t63z0i0 RnJvbSA2NWM4YWRkOTI4NDJjMmU1NDdiMTNkNWM2ZmIyNDg1ZTdmZGJmMmRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYXkgS2FtYXQgPGpheWdrYW1hdEBnbWFpbC5jb20+CkRhdGU6 IE1vbiwgMzEgSnVsIDIwMTcgMjI6NDc6MzMgLTA3MDAKU3ViamVjdDogW1BBVENIXSBPUkctTkVX UzogRml4IGEgc21hbGwgdHlwbyBpbiBuZXcgb3JnIGJhYmVsIGhlYWRlciBleGFtcGxlCgoqIGV0 Yy9PUkctTkVXUyAoVXNpbmcpOiBGaXggdHlwbyBpbiBiYWJlbCA6aGVhZGVyLWFyZ3M6IGNvbnZl cnNpb24KClRJTllDSEFOR0UKLS0tCiBldGMvT1JHLU5FV1MgfCAyICstCiAxIGZpbGUgY2hhbmdl ZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9ldGMvT1JHLU5F V1MgYi9ldGMvT1JHLU5FV1MKaW5kZXggZDdiZDNlMmNlNy4uNWFjYWY3ZWU1MiAxMDA2NDQKLS0t IGEvZXRjL09SRy1ORVdTCisrKyBiL2V0Yy9PUkctTkVXUwpAQCAtNTgyLDcgKzU4Miw3IEBAIHNo b3VsZCBiZSB3cml0dGVuIGluc3RlYWQKICwqIEhlYWRsaW5lCiA6UFJPUEVSVElFUzoKIDpoZWFk ZXItYXJnczogOmV4cG9ydHMgY29kZQotOmhlYWRlci1hcmdzOiA6dmFyIGE9MSBiPTIKKzpoZWFk ZXItYXJncys6IDp2YXIgYT0xIGI9MgogOmhlYWRlci1hcmdzKzogOnZhciBjPTMKIDpFTkQ6CiAj K0VORF9FWEFNUExFCi0tIAoyLjExLjAKCg== --001a113f2dbac2aec90555aaca1b--