From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jay Kamat Subject: [PATCH] Fix ox-md remote image links export Date: Sat, 5 Aug 2017 19:43:04 -0700 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="001a11473e42b8a09a05560cb16a" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1deBXM-0006MZ-R9 for emacs-orgmode@gnu.org; Sat, 05 Aug 2017 22:43:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1deBXL-0005Rb-DS for emacs-orgmode@gnu.org; Sat, 05 Aug 2017 22:43:28 -0400 Received: from mail-it0-x22a.google.com ([2607:f8b0:4001:c0b::22a]:37711) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1deBXL-0005QW-8r for emacs-orgmode@gnu.org; Sat, 05 Aug 2017 22:43:27 -0400 Received: by mail-it0-x22a.google.com with SMTP id v127so22588291itd.0 for ; Sat, 05 Aug 2017 19:43:25 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org --001a11473e42b8a09a05560cb16a Content-Type: text/plain; charset="UTF-8" Hi! I discovered a bug in the ox-md exporter and have created a patch to fix it: Previously, this image link: [[https://git-scm.com/images/logo@2x.png]] would export to: ![img](//git-scm.com/images/logo@2x.png) which is an invalid markdown image, and won't display properly in browsers and other places. A workaround (which I have been using extremely heavily), is: [[file:https://git-scm.com/images/logo@2x.png]] which exports to ![img](https://git-scm.com/images/logo@2x.png) Which is the proper (unbroken) image link. I have attached a patch which fixes the first example, so it exports the same link as the workaround (and is no longer broken). One of my concerns with the attached patch is whether there's a better way to determine if a link is 'remote'. Maybe I should make a constant in the file listing 'remote' types and use that everywhere. I'm also not sure if I broke any other type of image link (but the simple local case seems to work fine). My papers are currently being processed, but I thought I would post this patch early to get feedback, since ideally I would like this bug to be fixed as soon as possible :). Hopefully they'll be done before the review is completed. Let me know if you see anything wrong, and thanks again for hacking org mode :D. -Jay --001a11473e42b8a09a05560cb16a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-ox-md.el-Fix-exporting-of-remote-image-links.patch" Content-Disposition: attachment; filename="0001-ox-md.el-Fix-exporting-of-remote-image-links.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j604aypk0 RnJvbSBiNDc2OGJhZjJjNmVhMjM0YzkyZjI0NTQwZWQ5MjdjZjg0NzNlOTk5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYXkgS2FtYXQgPGpheWdrYW1hdEBnbWFpbC5jb20+CkRhdGU6 IFNhdCwgNSBBdWcgMjAxNyAxOToxNDo0NCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIG94LW1kLmVs OiBGaXggZXhwb3J0aW5nIG9mIHJlbW90ZSBpbWFnZSBsaW5rcwoKKiBsaXNwL294LW1kLmVsIChv cmctbWQtbGluayk6IENoZWNrIGlmIGEgbGluayBpcyBhIHJlbW90ZSwgYW5kIGlmIHNvLAogIHVz ZSB0aGUgcmF3LWxpbmsgcHJvcGVydHkgb2YgdGhlIGxpbmssIHJhdGhlciB0aGFuIHRoZSBwYXRo LgoKQSB3b3JrYXJvdW5kIGZvciB0aGlzIGJ1ZyBpcyB0byBkbyB0aGlzOgpbW2ZpbGU6aHR0cDov L29yZ21vZGUub3JnL2ltZy9vcmctbW9kZS11bmljb3JuLWxvZ28ucG5nXV0KClRoaXMgY29tbWl0 IGxldHMgdGhlIHdvcmthcm91bmQgY29udGludWUgd29ya2luZywgd2hpbGUgdGhlIHByb3BlciBt ZXRob2Q6CltbaHR0cDovL29yZ21vZGUub3JnL2ltZy9vcmctbW9kZS11bmljb3JuLWxvZ28ucG5n XV0KaXMgZml4ZWQuCi0tLQogbGlzcC9veC1tZC5lbCB8IDggKysrKysrKy0KIDEgZmlsZSBjaGFu Z2VkLCA3IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9saXNwL294 LW1kLmVsIGIvbGlzcC9veC1tZC5lbAppbmRleCAwOGUzODUyODIzLi5hNGUxZDY3NDliIDEwMDY0 NAotLS0gYS9saXNwL294LW1kLmVsCisrKyBiL2xpc3Avb3gtbWQuZWwKQEAgLTQzMCw4ICs0MzAs MTQgQEAgYSBjb21tdW5pY2F0aW9uIGNoYW5uZWwuIgogCSAgICAgICAoZm9ybWF0ICJbJXNdKCMl cykiCiAJCSAgICAgICBkZXNjcmlwdGlvbgogCQkgICAgICAgKG9yZy1leHBvcnQtZ2V0LXJlZmVy ZW5jZSBkZXN0aW5hdGlvbiBpbmZvKSkpKSkpKSkKKyAgICAgOzsgR2VuZXJhdGUgYSBtZCBpbWFn ZSBsaW5rCiAgICAgICgob3JnLWV4cG9ydC1pbmxpbmUtaW1hZ2UtcCBsaW5rIG9yZy1odG1sLWlu bGluZS1pbWFnZS1ydWxlcykKLSAgICAgIChsZXQgKChwYXRoIChsZXQgKChyYXctcGF0aCAob3Jn LWVsZW1lbnQtcHJvcGVydHkgOnBhdGggbGluaykpKQorICAgICAgIDs7IEdldCB0aGUgcGF0aCBh bmQgY2FwdGlvbiB0byBpbnNlcnQgaW50byB0aGUgaW1hZ2UKKyAgICAgICAobGV0ICgocGF0aCAo bGV0ICgocmF3LXBhdGgKKwkJCSAgIDs7IHR5cGVzIG9mIGxpbmtzIHdoaWNoIHdlIGp1c3QgdXNl IHRoZSByYXcgbGluaworCQkJICAgKGlmIChtZW1iZXIgdHlwZSAnKCJodHRwIiAiaHR0cHMiICJm dHAiKSkKKwkJCSAgICAgKG9yZy1lbGVtZW50LXByb3BlcnR5IDpyYXctbGluayBsaW5rKQorCQkJ ICAgICAob3JnLWVsZW1lbnQtcHJvcGVydHkgOnBhdGggbGluaykpKSkKIAkJICAgIChpZiAobm90 IChmaWxlLW5hbWUtYWJzb2x1dGUtcCByYXctcGF0aCkpIHJhdy1wYXRoCiAJCSAgICAgIChleHBh bmQtZmlsZS1uYW1lIHJhdy1wYXRoKSkpKQogCSAgICAoY2FwdGlvbiAob3JnLWV4cG9ydC1kYXRh Ci0tIAoyLjExLjAKCg== --001a11473e42b8a09a05560cb16a--