emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Yuri Niyazov <yuri.niyazov@gmail.com>
To: Yuri Niyazov <yuri.niyazov@gmail.com>,
	"emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: Bug: agenda interaction with org-agenda-dim-blocked-tasks, org-agenda-max-entries and org-enforce-todo-dependencies [8.3beta (release_8.3beta-785-gb5d9f4 @ /Users/yn/dotfiles/org.emacs.d/org-mode/lisp/)]
Date: Tue, 3 Feb 2015 14:39:09 -0800	[thread overview]
Message-ID: <CACbjG0uy9-XVO9ArQ8ACoFgQWfToP33FeTxWcpX6L9gm422+=Q@mail.gmail.com> (raw)
In-Reply-To: <874mr23aro.fsf@nicolasgoaziou.fr>

On Tue, Feb 3, 2015 at 2:12 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Documentation (e.g., docstrings) may be improved, then. Would you want
> to suggest such an improvement?

In the docstring for "org-agenda-dim-blocked-tasks"

"Because dimming is not the same as skipping, items dimmed to
invisible count against the limits specified by org-agenda-max-*"

In the docstring for entries like org-agenda-max-entries and
org-agenda-max-todos

"If org-agenda-dim-blocked-tasks is set to invisible, those entries
will still count towards the limits specified by this setting."

> As you noticed, skipping is not the same as dimming. The latter is
> purely visual. See `org-agenda-skip-function' to really skip tasks from
> agenda, and probably `org-entry-blocked-p' to ignore blocked tasks.

I now think that having the ability to dim to invisible is a feature
mistake. I'm having a difficult time seeing when a user would want to
dim to invisible purely visually, rather than really skipping a
blocked task. There's no visual difference between dimming to
invisible and skipping, but they have subtly different and
non-intuitive differences in behavior. A better fix would be to create
a org-agenda-skip-blocked-tasks setting (which would be implemented
much like other skip settings) and in the docstring in dim to
invisible setting explain the difference and point to the new setting,
and maybe eventually deprecate dim to invisible.

If you think that is an acceptable direction, I am happy to start
working on a patch.

  reply	other threads:[~2015-02-03 22:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-02 20:55 Bug: agenda interaction with org-agenda-dim-blocked-tasks, org-agenda-max-entries and org-enforce-todo-dependencies [8.3beta (release_8.3beta-785-gb5d9f4 @ /Users/yn/dotfiles/org.emacs.d/org-mode/lisp/)] Yuri Niyazov
2015-02-03 21:13 ` Nicolas Goaziou
2015-02-03 21:49   ` Yuri Niyazov
2015-02-03 22:12     ` Nicolas Goaziou
2015-02-03 22:39       ` Yuri Niyazov [this message]
2015-02-03 22:52         ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACbjG0uy9-XVO9ArQ8ACoFgQWfToP33FeTxWcpX6L9gm422+=Q@mail.gmail.com' \
    --to=yuri.niyazov@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).