emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Hu Lucius <orctarorga@gmail.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] fix `org-agenda-new-marker`
Date: Fri, 11 Feb 2022 02:34:28 +0000	[thread overview]
Message-ID: <CACDPnMHOfUmO4sjer_pcox5Z5sodkVN-UW29AAYdL8V-iOiGoA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

In some cases, `org-agenda-buffer` is killed while the symbol itself
is still non-nil. `org-agena-new-marker` and anything calls it would
ends in a message of "Selecting deleted buffer".

This commit simply added an additional test that

    (buffer-live-p org-agenda-buffer)

should also be true.

Signed-off-by: Lucius Hu <lebensterben@users.noreply.github.com>
 lisp/org-agenda.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 9bc44a56e..d5969ac78 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -4225,7 +4225,7 @@ Marker is at point, or at POS if non-nil.  Org mode
keeps a list
 of these markers and resets them when they are no longer in use."
   (let ((m (copy-marker (or pos (point)) t)))
     (setq org-agenda-last-marker-time (float-time))
-    (if org-agenda-buffer
+    (if (org-agenda-buffer (buffer-live-p org-agenda-buffer))
  (with-current-buffer org-agenda-buffer
   (push m org-agenda-markers))
       (push m org-agenda-markers))

[-- Attachment #2: Type: text/html, Size: 1268 bytes --]

             reply	other threads:[~2022-02-11 14:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-11  2:34 Hu Lucius [this message]
2022-10-16 10:42 ` [PATCH] fix `org-agenda-new-marker` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACDPnMHOfUmO4sjer_pcox5Z5sodkVN-UW29AAYdL8V-iOiGoA@mail.gmail.com \
    --to=orctarorga@gmail.com \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).