emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Hu Lucius <orctarorga@gmail.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] org-agenda: fix `org-agenda-new-marker`
Date: Tue, 15 Feb 2022 06:10:02 +0000	[thread overview]
Message-ID: <CACDPnMH-HSSG5xD8ox0R-F3GrJerKBM5PCe+95JhQU7OB3h-ZQ@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1176 bytes --]

In some cases, `org-agenda-buffer` is killed while the symbol itself
is still non-nil. `org-agena-new-marker` and anything that calls it would
end in a message of "Selecting deleted buffer".

This commit simply added an additional test that

    (buffer-live-p org-agenda-buffer)

should also be true.

P.S. I've sent another patch with the same subject a few days earlier.
But that contains an error. Please dismiss that one.

Signed-off-by: Lucius Hu <lebensterben@users.noreply.github.com>
---
 lisp/org-agenda.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 9bc44a56e..cc7f01758 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -4225,7 +4225,7 @@ Marker is at point, or at POS if non-nil.  Org mode
keeps a list
 of these markers and resets them when they are no longer in use."
   (let ((m (copy-marker (or pos (point)) t)))
     (setq org-agenda-last-marker-time (float-time))
-    (if org-agenda-buffer
+    (if (and org-agenda-buffer (buffer-live-p org-agenda-buffer))
  (with-current-buffer org-agenda-buffer
   (push m org-agenda-markers))
       (push m org-agenda-markers))
--
2.35.1

[-- Attachment #2: Type: text/html, Size: 1437 bytes --]

                 reply	other threads:[~2022-02-15  6:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACDPnMH-HSSG5xD8ox0R-F3GrJerKBM5PCe+95JhQU7OB3h-ZQ@mail.gmail.com \
    --to=orctarorga@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: [PATCH] org-agenda: fix `org-agenda-new-marker`' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).