emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: ian martins <ianxm@jhu.edu>
To: John Herrlin <jherrlin@gmail.com>
Cc: org-mode-email <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] ob-java, a proposal on import improvement
Date: Sat, 9 Jan 2021 10:51:07 -0500	[thread overview]
Message-ID: <CAC=rjb7tPvbXdhwth0j7oAjUVmufh7_gaEoY78j36ekKKyS7EQ@mail.gmail.com> (raw)
In-Reply-To: <87o8hzv1e8.fsf@gmail.com>

On Fri, Jan 8, 2021 at 11:28 AM John Herrlin <jherrlin@gmail.com> wrote:

> I would like to combine imports from header-args with imports from a
> source block.
> ...
> I didnt get the to work so I made a patch.

John, Sorry that wasn't working. Thanks for investigating and
submitting a fix.  I think the problem was that I was missing static
imports, which you fixed in the first chunk of your patch. I don't
think the rest of the change is necessary. Could you revert the other
chunks and re-test?

This works for me using master, and your patch produces nearly the
same code (only import order differs):

    #+begin_src java :results output :imports java.util.HashMap
      import java.util.Map;

      Map<String, Integer> hash = new HashMap<>();
      hash.put("one", 1);
      hash.put("two", 2);
      System.out.println(hash);
    #+end_src


  parent reply	other threads:[~2021-01-09 15:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 16:28 John Herrlin
2021-01-08 22:09 ` Dr. Arne Babenhauserheide
2021-01-09 15:55   ` ian martins
2021-01-09 15:51 ` ian martins [this message]
2021-01-10 20:55   ` John Herrlin
2021-01-12 12:00     ` ian martins
2021-01-16 12:56       ` ian martins
2021-01-16 15:32         ` John Herrlin
2021-01-16 20:49           ` ian martins
2021-04-25  3:42             ` Timothy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAC=rjb7tPvbXdhwth0j7oAjUVmufh7_gaEoY78j36ekKKyS7EQ@mail.gmail.com' \
    --to=ianxm@jhu.edu \
    --cc=emacs-orgmode@gnu.org \
    --cc=jherrlin@gmail.com \
    --subject='Re: [PATCH] ob-java, a proposal on import improvement' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).