From: ian martins <firstname.lastname@example.org> To: John Herrlin <email@example.com> Cc: org-mode-email <firstname.lastname@example.org> Subject: Re: [PATCH] ob-java, a proposal on import improvement Date: Sat, 16 Jan 2021 15:49:37 -0500 [thread overview] Message-ID: <CAC=rjb7Ziuykgaw8X7yFwBS926WhyADCXxjZdFL6sasaDJx6_g@mail.gmail.com> (raw) In-Reply-To: <email@example.com> It's no problem. Didn't mean to rush you. Thanks again for the patch. Applied. On Sat, Jan 16, 2021 at 10:32 AM John Herrlin <firstname.lastname@example.org> wrote: > > > Sorry for latency, 9to5 been killing it. Thx for the feedback, make > sense! Here is a new patch with the improvements. > > > > ian martins <email@example.com> writes: > > > John, would you mind if I go ahead and make the change I mentioned and > > push it with you as the author? > > > > On Tue, Jan 12, 2021 at 7:00 AM ian martins <firstname.lastname@example.org> wrote: > >> > >> On Sun, Jan 10, 2021 at 3:55 PM John Herrlin <email@example.com> wrote: > >> > ian martins <firstname.lastname@example.org> writes: > >> > > I think the problem was that I was missing static > >> > > imports, which you fixed in the first chunk of your patch. I don't > >> > > think the rest of the change is necessary. Could you revert the other > >> > > chunks and re-test? > >> > > >> > Thats looks correct! Thanks! > >> > > >> > Here is a patch with the regexp fix. > >> > >> That's great. One small change, though. This only allows for a single > >> space between "import" and "static" so if someone were to put in two > >> it wouldn't work. I actually did the same thing in an earlier version > >> and it caused a problem. Since then I went to =(1+ space)= > >> everywhere. Could you also move the part that you're adding down to > >> the next line. It's not that the line is too long, but it keeps it to > >> one thing per line. > >> > >> The commit message is fine, but the first line shouldn't end in a period. > >> > >> ref: https://orgmode.org/worg/org-contribute.html#commit-messages
next prev parent reply other threads:[~2021-01-16 20:50 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-08 16:28 John Herrlin 2021-01-08 22:09 ` Dr. Arne Babenhauserheide 2021-01-09 15:55 ` ian martins 2021-01-09 15:51 ` ian martins 2021-01-10 20:55 ` John Herrlin 2021-01-12 12:00 ` ian martins 2021-01-16 12:56 ` ian martins 2021-01-16 15:32 ` John Herrlin 2021-01-16 20:49 ` ian martins [this message] 2021-04-25 3:42 ` Timothy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAC=rjb7Ziuykgaw8X7yFwBS926WhyADCXxjZdFL6sasaDJx6_g@mail.gmail.com' \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] ob-java, a proposal on import improvement' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).