From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id ZKh2HezmXF9LXgAA0tVLHw (envelope-from ) for ; Sat, 12 Sep 2020 15:19:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id EFqmF+zmXF9RSAAA1q6Kng (envelope-from ) for ; Sat, 12 Sep 2020 15:19:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E3A4C940221 for ; Sat, 12 Sep 2020 15:19:07 +0000 (UTC) Received: from localhost ([::1]:50734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kH7Iw-0006lB-Pz for larch@yhetil.org; Sat, 12 Sep 2020 11:19:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kH7IZ-0006kw-NX for Emacs-orgmode@gnu.org; Sat, 12 Sep 2020 11:18:43 -0400 Received: from mail-ed1-f44.google.com ([209.85.208.44]:39544) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kH7IX-0004zz-4e for Emacs-orgmode@gnu.org; Sat, 12 Sep 2020 11:18:43 -0400 Received: by mail-ed1-f44.google.com with SMTP id e22so2896375edq.6 for ; Sat, 12 Sep 2020 08:18:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wBCIHPEGQ1Mo/NheoplqzwcrEpFdmHZPfuvwmKNjNUA=; b=KpF00FYKV8kKMj5odpL4YK87kAAw1lIQZlC0A7AtDNrcSp2jX60Qe94TB+0Y8oUXLu vX980OcnMunt7H5znNI24CPMQvYYGaUJ6p5QHU7qOdHMfGW+Dg4tEKRSRwU9Qx14pEJh CXbmWWgffF4eh5UhFBsrsdjxk1oCraNrJvbrp1N7bmk6DJFi4tQvQgssDAycxl6AxBfd fBb0vClFFFhVNC06lyX6NMD3BnOrZa5lq72MMSUwfSvU38nIKJcP+IcxSCFRBgpStM2z 98C0dbPQ/L5Q0H9oIMzxcp+sBwoYeHzx/GfnvbtiI6FhCW9TDWxk9t4nWISG9M5Qe6Pi 57IQ== X-Gm-Message-State: AOAM531FmaCZuxwM67J1992HbUM2fWq9+Ar8pbVCZoq/UdcGfBLOZgBb IbkWziKygIiefcTKjpcIa0SbIJWL/NNqjBIaQLs= X-Google-Smtp-Source: ABdhPJyXwsLRRdzijaSHD1a5PXSr8Tp+faPqOXpUsPNXsduphM/2GRDaYugCF6WyvCQTNZsKyRO2ekx0MIVgYvr6bDQ= X-Received: by 2002:aa7:d29a:: with SMTP id w26mr8702978edq.106.1599923918977; Sat, 12 Sep 2020 08:18:38 -0700 (PDT) MIME-Version: 1.0 References: <877dt72ajj.fsf@kyleam.com> In-Reply-To: <877dt72ajj.fsf@kyleam.com> From: ian martins Date: Sat, 12 Sep 2020 11:18:27 -0400 Message-ID: Subject: Re: org-babel support for haxe To: Kyle Meyer Content-Type: multipart/alternative; boundary="000000000000dbbe5f05af1f5047" Received-SPF: pass client-ip=209.85.208.44; envelope-from=ianxm1@gmail.com; helo=mail-ed1-f44.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/12 11:18:39 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org-Mode mailing list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=jhu.edu (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.91 X-TUID: xjYeehTViua9 --000000000000dbbe5f05af1f5047 Content-Type: text/plain; charset="UTF-8" Thanks for the feedback. There's no special reason for the external test data file or repeated executable-find calls. I was following the convention from ob-C. I'll make those changes. ob-haxe and ob-java both involve a few changes to ob-core to allow temp directories instead of just temp files. Should I submit that as a separate patch? On Sun, Sep 6, 2020 at 11:24 AM Kyle Meyer wrote: > Hi ian, > > It looks like this library is instead going to be available through an > ELPA, but FWIW here are a couple of comments on the tests. > > ian martins writes: > > > diff --git a/testing/examples/ob-haxe-test.org b/testing/examples/ > ob-haxe-test.org > > new file mode 100644 > > index 000000000..ba9119d58 > > --- /dev/null > > +++ b/testing/examples/ob-haxe-test.org > > @@ -0,0 +1,247 @@ > > +#+Title: a collection of examples for ob-haxe tests > > +#+OPTIONS: ^:nil > > +* Simple > > + :PROPERTIES: > > + :ID: 966875e9-d10e-406c-9211-449555e3d3b2 > > + :END: > > +#+name: simple > > +#+begin_src haxe :results output silent > > + Sys.print(42); > > +#+end_src > > I know some other babel tests use a separate .org file, but I find this > setup harder to follow compared to having the Org content within the > test (e.g. using org-test-with-temp-text or > org-test-with-temp-text-in-file). Perhaps I'm missing why it's needed > in this case though. > > > diff --git a/testing/lisp/test-ob-haxe.el b/testing/lisp/test-ob-haxe.el > [...] > > +;;; Code: > > +(org-test-for-executable "haxe") > > +(unless (featurep 'ob-haxe) > > + (signal 'missing-test-dependency "Support for haxe code blocks")) > > + > > +(ert-deftest ob-haxe/simple () > > + "Hello world program." > > + (if (executable-find org-babel-haxe-command) > > I think you can avoid the executable-find here and in all the other > tests because you have (org-test-for-executable "haxe") at the beginning > of the file. > --000000000000dbbe5f05af1f5047 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks for the feedback. There's no special reaso= n for the external test data file or repeated executable-find calls. I was = following the convention from ob-C. I'll make those changes.
<= div>
ob-haxe and ob-java both involve a few changes to ob-cor= e to allow temp directories instead of just temp files. Should I submit tha= t as a separate patch?

On Sun, Sep 6, 2020 at 11:24 AM Kyle Meyer &l= t;kyle@kyleam.com> wrote:
Hi ian,

It looks like this library is instead going to be available through an
ELPA, but FWIW here are a couple of comments on the tests.

ian martins writes:

> diff --git a/testing/examples/ob-haxe-test.org b/testing/examples/<= a href=3D"http://ob-haxe-test.org" rel=3D"noreferrer" target=3D"_blank">ob-= haxe-test.org
> new file mode 100644
> index 000000000..ba9119d58
> --- /dev/null
> +++ b/testing/examples/ob-haxe-test.org
> @@ -0,0 +1,247 @@
> +#+Title: a collection of examples for ob-haxe tests
> +#+OPTIONS: ^:nil
> +* Simple
> +=C2=A0 :PROPERTIES:
> +=C2=A0 :ID:=C2=A0 =C2=A0 =C2=A0 =C2=A0966875e9-d10e-406c-9211-449555e= 3d3b2
> +=C2=A0 :END:
> +#+name: simple
> +#+begin_src haxe :results output silent
> +=C2=A0 Sys.print(42);
> +#+end_src

I know some other babel tests use a separate .org file, but I find this
setup harder to follow compared to having the Org content within the
test (e.g. using org-test-with-temp-text or
org-test-with-temp-text-in-file).=C2=A0 Perhaps I'm missing why it'= s needed
in this case though.

> diff --git a/testing/lisp/test-ob-haxe.el b/testing/lisp/test-ob-haxe.= el
[...]
> +;;; Code:
> +(org-test-for-executable "haxe")
> +(unless (featurep 'ob-haxe)
> +=C2=A0 (signal 'missing-test-dependency "Support for haxe co= de blocks"))
> +
> +(ert-deftest ob-haxe/simple ()
> +=C2=A0 "Hello world program."
> +=C2=A0 (if (executable-find org-babel-haxe-command)

I think you can avoid the executable-find here and in all the other
tests because you have (org-test-for-executable "haxe") at the be= ginning
of the file.
--000000000000dbbe5f05af1f5047--