From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id D3bMIb0RbV+McAAA0tVLHw (envelope-from ) for ; Thu, 24 Sep 2020 21:38:05 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wK9oHb0RbV8hfQAAB5/wlQ (envelope-from ) for ; Thu, 24 Sep 2020 21:38:05 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 248A59401AE for ; Thu, 24 Sep 2020 21:38:03 +0000 (UTC) Received: from localhost ([::1]:51772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLYwD-0000XJ-Q9 for larch@yhetil.org; Thu, 24 Sep 2020 17:38:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLYcP-0006Zp-Ld for Emacs-orgmode@gnu.org; Thu, 24 Sep 2020 17:17:35 -0400 Received: from mail-ej1-f54.google.com ([209.85.218.54]:41751) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kLYcG-0003J1-Tz for Emacs-orgmode@gnu.org; Thu, 24 Sep 2020 17:17:33 -0400 Received: by mail-ej1-f54.google.com with SMTP id lo4so719263ejb.8 for ; Thu, 24 Sep 2020 14:17:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OOtRCABNHZtch4Ng0MKBrwNF/ybGiJ3oawedB8tWnK0=; b=Pbf8HN0hvWGTATVFhNVUStxD7a9ksxWhdSxSOe06T3WaSOb7TYrmg5ROgdzvvt9tm5 +RtOgcYU+DuiXkUmKjZ6l4JqygesTrdTE52pWWQjvbJyGYu4XVOEyI35CXkHXAfteAFN Yftdd5awktVPl9Raq+MT0Sv+ZRIPlzsrEmi+wQVnG8SG+hH+Y1ezFOQ1FQcHq9et65a1 +R0ZZAyutJ5yz6GYXb98Zj969z+DKj/VNaqv00FHzvkTmv617/OSasEmXxmQ2XaD7QfY fgyHgofZeQUnt0D0wPdAR9Wjz5NN6ovEvZhFfnj0q0TtSEw4hzLCxCC/OsF2tXWRyukK EnUw== X-Gm-Message-State: AOAM532a255GrKh51xaJtxCcWmX0lCqQQptnNkquOyH8SB1y/pmzAu8l Hhgsocjg/qNYtxZ/33xHLadMIYRN7w3pTb8jnh8= X-Google-Smtp-Source: ABdhPJxerTGaX++MKkRLLY8FWhDoxxjlCS79GVtUpY9dQQi7gstTfwiXLSuJk5KOYeYpOTD/Zdq5KOJTlbDqMXSkPNQ= X-Received: by 2002:a17:906:fb15:: with SMTP id lz21mr541682ejb.185.1600982235250; Thu, 24 Sep 2020 14:17:15 -0700 (PDT) MIME-Version: 1.0 References: <877dt72ajj.fsf@kyleam.com> <875z8hmojt.fsf@kyleam.com> In-Reply-To: <875z8hmojt.fsf@kyleam.com> From: ian martins Date: Thu, 24 Sep 2020 17:17:04 -0400 Message-ID: Subject: Re: org-babel support for haxe To: Kyle Meyer Content-Type: multipart/alternative; boundary="0000000000006c872705b015b999" Received-SPF: pass client-ip=209.85.218.54; envelope-from=ianxm1@gmail.com; helo=mail-ej1-f54.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/24 17:17:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org-Mode mailing list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=jhu.edu (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.91 X-TUID: IIS8tljxHOVp --0000000000006c872705b015b999 Content-Type: text/plain; charset="UTF-8" with ob-java I assumed I shouldn't change ob-core, so I advised/overrode ob-core instead of changing it. But it would be much better to change ob-core. I'll submit those changes as a separate patch that modifies ob-core. On Sun, Sep 13, 2020 at 4:04 PM Kyle Meyer wrote: > ian martins writes: > > > ob-haxe and ob-java both involve a few changes to ob-core to allow temp > > directories instead of just temp files. Should I submit that as a > separate > > patch? > > It looks like that change is included with your ob-java patch [0], which > will be considered after 9.4 is released [1], so I think it's fine as > is. (In my opinion, splitting up that patch would have been nice, but I > don't think it's worth a reroll, at least until some initial comments > come in.) > > [0] > https://orgmode.org/list/CAC=rjb7AhmnRQ9Nc4Ao07qK3QZF4LVaTmU_R1fWqr+97NpnRJQ@mail.gmail.com > [1] https://orgmode.org/list/87sgbwgvx6.fsf@gnu.org > --0000000000006c872705b015b999 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
with ob-java I assumed I shouldn't change ob-core, so = I advised/overrode ob-core instead of changing it. But it would be much bet= ter to change ob-core. I'll submit those changes as a separate patch th= at modifies ob-core.

On Sun, Sep 13, 2020 at 4:04 PM Kyle Meyer <kyle@kyleam.com> wrote:
ian martins writes:

> ob-haxe and ob-java both involve a few changes to ob-core to allow tem= p
> directories instead of just temp files. Should I submit that as a sepa= rate
> patch?

It looks like that change is included with your ob-java patch [0], which will be considered after 9.4 is released [1], so I think it's fine as is.=C2=A0 (In my opinion, splitting up that patch would have been nice, but= I
don't think it's worth a reroll, at least until some initial commen= ts
come in.)

[0] htt= ps://orgmode.org/list/CAC=3Drjb7AhmnRQ9Nc4Ao07qK3QZF4LVaTmU_R1fWqr+97NpnRJQ= @mail.gmail.com
[1] https://orgmode.org/list/87sgbwgvx6.fsf@gnu.org
--0000000000006c872705b015b999--