[-- Attachment #1: Type: text/plain, Size: 428 bytes --] I've written some documentation for ob-java for worg. Should I submit a patch or is it fine to just push? it doesn't modify any existing files. I've seen this question come up on this list before but I haven't seen an answer. Also I couldn't find the answer on worg [1]. one note: I tweaked the css a bit. I think it makes it easier to read, but it also doesn't match the other pages. [1] https://orgmode.org/worg/#orgeb00eb0 [-- Attachment #2: Type: text/html, Size: 588 bytes --]
ian martins writes:
> I've written some documentation for ob-java for worg. Should I submit a
> patch or is it fine to just push? it doesn't modify any existing files.
It's fine to just push.
[-- Attachment #1: Type: text/plain, Size: 730 bytes --] Thanks. I pushed. The docs for java are here [1]. It looks like many of the language pages don't pick up their formatting. Mine did the same at first. Is it fine if I fix them? The =#+HTML_HEAD:= property breaks them. I suspect that it's existence blocks the page from picking up the default css. Also It points to an html id that doesn't exist, so it would have no effect. [1] https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-java.html On Fri, Oct 30, 2020 at 12:40 AM Kyle Meyer <kyle@kyleam.com> wrote: > ian martins writes: > > > I've written some documentation for ob-java for worg. Should I submit a > > patch or is it fine to just push? it doesn't modify any existing files. > > It's fine to just push. > [-- Attachment #2: Type: text/html, Size: 1222 bytes --]
ian martins writes:
> Thanks. I pushed. The docs for java are here [1].
>
> It looks like many of the language pages don't pick up their formatting.
> Mine did the same at first. Is it fine if I fix them?
Yes, please, and in general feel free to make improvements and fixes.
Thanks.