emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nathan Neff <nathan.neff@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Agenda search: setting sort-order
Date: Wed, 1 Aug 2018 20:28:34 -0500	[thread overview]
Message-ID: <CAC=HedC_=ki2JmZ07476EMDUTfu0FTepoBtn3V1S4-HY_kz_dQ@mail.gmail.com> (raw)
In-Reply-To: <87bmc6edfo.fsf@nicolasgoaziou.fr>

[-- Attachment #1: Type: text/plain, Size: 1686 bytes --]

On Tue, Jun 19, 2018 at 3:20 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:

> Hello,
>
> Nathan Neff <nathan.neff@gmail.com> writes:
>
> > I had a look at org-agenda.el, and took a first stab at "coding" :)
> > I fixed the sorting problem when using agenda-search-view, and
> > I have a DIFF/patch at the bottom of this e-mail [1] that provided the
> fix.
> >
> > Would this be of interest to the org-mode project?
>
> IMO, the Org mode project is interested in having its bugs fixed ;)
>
> > This code fixes the
> > problem,
> > but it is duplicated in the function org-agenda-get-todos, and seems
> > redundant,
> > therefore a more "long term" fix would probably not resemble the minor
> patch
> > below.  Also, I have no experience with lisp, nor the org-mode
> > codebase :-O
>
> A more "long term" fix would be to rewrite the agenda (asynchronous,
> more scalable, better API for external use).
>
> > Here's steps I used to find the problem.  Feel free to skip to [1]
> > for the DIFF/patch.
>
> Would you mind sending it using `git format-patch'?
>

Hi Nicolas,

I'm a bit leery of submitting these lines of code - one reason is that
the sort feature still really doesn't work very well.  IIRC, the results
are globally sorted by timestamp, but there's results with NULL or
no timestamps mixed in.

In other words, results are something like:

* foo 12/1/2001
* bar 12/2/2002
* baz <no timestamp>
* blech 12/2/2003
* another <no timestamp>

So, it's not really a fix, and I'm not sure this is even good code :)
If someone wants to grab the fix and jump from here, that's fine, it's only
a few lines.

Thanks,
--Nate


>
> Thank you.
>
> Regards,
>
> --
> Nicolas Goaziou
>

[-- Attachment #2: Type: text/html, Size: 2766 bytes --]

     prev parent reply	other threads:[~2018-08-02  1:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30 21:57 Agenda search: setting sort-order Nathan Neff
2018-06-12 20:07 ` Nathan Neff
2018-06-18 18:16   ` Nathan Neff
2018-06-19 20:20     ` Nicolas Goaziou
2018-08-02  1:28       ` Nathan Neff [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAC=HedC_=ki2JmZ07476EMDUTfu0FTepoBtn3V1S4-HY_kz_dQ@mail.gmail.com' \
    --to=nathan.neff@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).