From: "Sławomir Grochowski" <slawomir.grochowski@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [RFC] [feat] org-colview/org-columns: 'column view' moving rows up/down
Date: Tue, 11 Apr 2023 10:49:24 +0200 [thread overview]
Message-ID: <CABnDLzE8xFtnwhByYEk-3mUosXLGj7ifTy-v+OgRjovKvwVg9w@mail.gmail.com> (raw)
In-Reply-To: <877culo1pb.fsf@localhost>
[-- Attachment #1: Type: text/plain, Size: 2026 bytes --]
Thank you Ihor for finding such an important bug.
I've tried to pinpoint it.
I think it happens only when: first heading (row) is the first line of the
buffer.
To reproduce it:
* a
* b
* c
C-u C-c C-x C-c => runs `org-columns' with global argument.
Using a keyboard. Press M-<down>, M-<down>, M-<up>.
Heading 'a' will disappear.
I've tried to create a test based on that behaviour, but can't reproduce
this bug in test env.
Also I can't reproduce this when I'm invoking the commands directly from
M-x.
As I understand it something with overlay. Which try to jump before the
first line of the buffer.
And that makes some kind of overflow?
I will try to simplify the example and create a simple overlay without
org-columns.
If anyone has some ideas how to debug it I will be grateful for the hints.
On Sun, Apr 9, 2023 at 11:13 AM Ihor Radchenko <yantar92@posteo.net> wrote:
> Sławomir Grochowski <slawomir.grochowski@gmail.com> writes:
>
> > Thank you Ihor for the code review.
> > Now please help me find everything that can be improved in this patch.
>
> I just tried to use the patch using the following test case:
>
> 1. Create a new Org file containing
>
> * A
> * B
> * C
> ** C1
> * D
>
> 2. C-u C-c C-x C-c
> 3. M-<
> 4. M-<down> M-<up> M-<down> M-<up> M-<down> M-<up> M-<down> M-<up> C-c C-c
> 5. Observe text disappearing and columns being unhighlighted. At the
> end, the buffer is left with
>
> * B
>
> >> Finally, I see no records about you copyright assignment status.
> >> Please take a look at
> >> https://orgmode.org/worg/org-contribute.html#copyright
> >>
> >
> > Yes, it's my first time. I sent an email to assign@gnu.org, yesterday.
>
> Note that they should reply within 5 working days.
>
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>
>
[-- Attachment #2: Type: text/html, Size: 3072 bytes --]
next prev parent reply other threads:[~2023-04-11 8:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 10:11 [RFC] [feat] org-colview/org-columns: 'column view' moving rows up/down Sławomir Grochowski
2023-04-07 11:04 ` Ihor Radchenko
2023-04-08 21:48 ` Sławomir Grochowski
2023-04-09 9:16 ` Ihor Radchenko
2023-04-11 8:49 ` Sławomir Grochowski [this message]
2023-04-12 9:09 ` Ihor Radchenko
2023-08-20 10:43 ` Ihor Radchenko
2023-08-20 17:44 ` Sławomir Grochowski
2023-08-20 19:39 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABnDLzE8xFtnwhByYEk-3mUosXLGj7ifTy-v+OgRjovKvwVg9w@mail.gmail.com \
--to=slawomir.grochowski@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).