From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Org-choose Date: Fri, 13 Feb 2009 22:34:20 +0100 Message-ID: References: <273688C0-9A36-47D5-B747-A1371C2BD05A@uva.nl> <1782.65.96.63.84.1234471662.squirrel@mail.panix.com> <5E0C3EFF-06FA-4446-B869-F514B6748C5E@uva.nl> <1036.24.63.20.74.1234553649.squirrel@mail.panix.com> Mime-Version: 1.0 (Apple Message framework v930.3) Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LY5g2-0004tP-Ea for emacs-orgmode@gnu.org; Fri, 13 Feb 2009 16:34:26 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LY5g0-0004t3-VA for emacs-orgmode@gnu.org; Fri, 13 Feb 2009 16:34:26 -0500 Received: from [199.232.76.173] (port=44309 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LY5g0-0004t0-Qp for emacs-orgmode@gnu.org; Fri, 13 Feb 2009 16:34:24 -0500 Received: from ey-out-1920.google.com ([74.125.78.148]:36556) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LY5g0-0001Tp-D6 for emacs-orgmode@gnu.org; Fri, 13 Feb 2009 16:34:24 -0500 Received: by ey-out-1920.google.com with SMTP id 4so121186eyg.24 for ; Fri, 13 Feb 2009 13:34:23 -0800 (PST) In-Reply-To: <1036.24.63.20.74.1234553649.squirrel@mail.panix.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Tom Breton (Tehom)" Cc: emacs-orgmode@gnu.org Hi Tom, thanks, this patch seems to fix at least the problem I was having. I see that you now require 'cl also during runtime, which is probably (?) because you are also calling some functions, not only macros? If we decide to move org-choose into the Org core at some point, then we would have to change this, because Emacs rules require that cl is only required during compilation. I think that is a pity because it is *so* useful, but there you go. So, maybe at some point you might want to replace the cl functions with other code. On Feb 13, 2009, at 8:34 PM, Tom Breton (Tehom) wrote: > > That just might be it! I have changed it to org-split-string. A > patch is attached. > > I can't detect any difference - all tests pass either way - so I hope > you will tell me whether it works now. It does! And I like it, I am already using it. Also, because it opens the possibility to think of more nice things to do with TODO keywords. > > Thank you. And thank you for your patience with this. Of course! Thank you for your contributions! - Carsten