emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "R. Michael Weylandt" <michael.weylandt@gmail.com>
To: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: :mkdirp without path specifier
Date: Fri, 2 May 2014 23:43:21 -0400	[thread overview]
Message-ID: <CAAmySGMzq+aGd4Za+F49+KKKXcnzLYLXMnA7XDRLYS5ry7-tMw@mail.gmail.com> (raw)
In-Reply-To: <14FCE026-6FA3-409F-87F6-B2E9B1452C9E@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

On Thu, May 1, 2014 at 3:47 PM, Michael Weylandt
<michael.weylandt@gmail.com> wrote:
> If it intended that setting :mkdirp yes should break tangling with 'directory-free' file names?
> I.e., should
> #############
> #+TITLE: test
> #+BEGIN_SRC python :mkdirp yes :tangle test.py
> print 1+2
> ###############
> tangle without error?
> It currently doesn't because (file-name-directory "test.py"), which is nil, gets passed to make-directory, which throws an error.
> The manual is ambiguous, stating only that the arg to :tangle is interpreted as a path. A strict reading says this shouldn't work, regardless of :mkdirp, since we're not giving a path, but I think the "understood ./" of :mkdirp no is reasonable.

Patch attached. Should apply cleanly against master and maint.


[-- Attachment #2: 0001-Fix-tangle-with-mkdirp-yes-tangle-FILE.patch --]
[-- Type: application/octet-stream, Size: 1272 bytes --]

From d4dc8067f3a97fbd6061537e4f52bbcea0b50bc8 Mon Sep 17 00:00:00 2001
From: Michael Weylandt <michael.weylandt@gmail.com>
Date: Fri, 2 May 2014 23:30:42 -0400
Subject: [PATCH] Fix tangle with ":mkdirp yes :tangle FILE"

* ob-tangle.el (org-babel-tangle): Fix tangling with :mkdirp and :tangle FILE.
Since (file-name-directory FILE) returns nil, don't pass it to
make-directory without checking.

Fixes tangling of files like:
print 1 + 2 + 3

 lisp/ob-tangle.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/ob-tangle.el b/lisp/ob-tangle.el
index be7e9a6..dd92345 100644
--- a/lisp/ob-tangle.el
+++ b/lisp/ob-tangle.el
@@ -234,7 +234,8 @@ used to limit the exported source code blocks by language."
 		      ;; Possibly create the parent directories for file.
 		      (when (let ((m (funcall get-spec :mkdirp)))
                               (and m (not (string= m "no"))))
-			(make-directory (file-name-directory file-name) 'parents))
+			(if (file-name-directory file-name)
+			    (make-directory (file-name-directory file-name) 'parents)))
 		      ;; delete any old versions of file
 		      (when (and (file-exists-p file-name)
 				 (not (member file-name (mapcar #'car path-collector))))
-- (Apple Git-47)

  reply	other threads:[~2014-05-03  3:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-01 19:47 :mkdirp without path specifier Michael Weylandt
2014-05-03  3:43 ` R. Michael Weylandt [this message]
2014-05-03  3:47   ` R. Michael Weylandt
2014-05-03  8:19     ` Achim Gratz
2014-05-03 14:52       ` R. Michael Weylandt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAmySGMzq+aGd4Za+F49+KKKXcnzLYLXMnA7XDRLYS5ry7-tMw@mail.gmail.com \
    --to=michael.weylandt@gmail.com \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).