From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 6A8aJQ+YPmQ0kQAASxT56A (envelope-from ) for ; Tue, 18 Apr 2023 15:15:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id yDXdJA+YPmTcswAAauVa8A (envelope-from ) for ; Tue, 18 Apr 2023 15:15:59 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 59FA66638 for ; Tue, 18 Apr 2023 15:15:59 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1polAd-0003pC-8I; Tue, 18 Apr 2023 09:14:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1polAZ-0003oT-B7 for emacs-orgmode@gnu.org; Tue, 18 Apr 2023 09:14:51 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1polAX-000664-Ju for emacs-orgmode@gnu.org; Tue, 18 Apr 2023 09:14:51 -0400 Received: by mail-ej1-x62c.google.com with SMTP id xd13so39153623ejb.4 for ; Tue, 18 Apr 2023 06:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681823688; x=1684415688; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vvkINsgzXcONyJeg1qDYFcRuw9ilfPJdayS8ziNBXXo=; b=Fbnw+7rp6iOxnfP+cBfr25r0cu6CH+snF7qI4I4PUL9sFDCk5ci0KMrCX4MeDKo/6n SsCxJ9sNmLQJ1YNRuN0TOph5e9HZymOX7o8sZYcvdOW/XIFBKE6qJMR5KiCKtG7fmu2o uviPH2gfTJfzQyhGq6H/ef2x0l0DqxnYxBZ8ufLpQCDIZHM4263waTEw5/3oakuwRLDy pIoQXNjrbIc78dgw3hSfuq7wRmYpNgVug/5C0+GPWQJ0xLOwlzKcY7J+bdzTzQKrmiR3 UbMQxRBiGdb06BwiktnYSeYB7Q8w2iLEKsaLqqjRtN638BS0T3GGVC9OT+exDFHpEc/7 mP/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681823688; x=1684415688; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vvkINsgzXcONyJeg1qDYFcRuw9ilfPJdayS8ziNBXXo=; b=CKRGKKkszG3ZbwE3aX8CxiUIU/m4NK6FOv4b5Vie825MN1LwPbgYbgGm9JKdYkjbQ4 HyYZC1Ubvkqvey7V7SPd25/cycejQ0A1Oj2QUB6pfcYeQDb00L457uuxD9NU5sph0USs XhqKbFg1plhwB+QiAut8Wtpb2Xfnlfn2HYNQ1EQrTwRG3A2Pc93jzf6VvsFIMdKr5Abj L5ufy4H6LwnS+4ysprQi6NmgWB8BLB66TQpjYk9e8iW3sOCrtiRTUJql8ZFCjAiRy6cG W5/iektHGox0PTEeYdEzSpLQyGgnZq2+63UJiXCBnZoR6Q5/mU9q4xxRWuVb6X7YCam1 svLQ== X-Gm-Message-State: AAQBX9fKEM4GNYyaw+SStBBluN2tMmX5WJ2fSEGaOVzFpc0QCozPEYgy s5zP+RLDhPUGCXZSlWodnmkBrYQXJcPRLXl307c= X-Google-Smtp-Source: AKy350ZHfQOmXsdMEf2TU3YBe05hWrdl8tUYUwS5/5wUbhg84Qod8SKASvo14Zy15ZLs7kE/thQuXZc0NmJBuIJ3248= X-Received: by 2002:a17:906:bb12:b0:94e:4b26:233c with SMTP id jz18-20020a170906bb1200b0094e4b26233cmr10451016ejb.16.1681823688075; Tue, 18 Apr 2023 06:14:48 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a17:907:d307:b0:94f:2d6f:2c5f with HTTP; Tue, 18 Apr 2023 06:14:47 -0700 (PDT) In-Reply-To: <878repgwt4.fsf@localhost> References: <87ilduqrem.fsf@localhost> <87mt35h3ip.fsf@localhost> <878repgwt4.fsf@localhost> From: Lionel Henry Date: Tue, 18 Apr 2023 15:14:47 +0200 Message-ID: Subject: Re: [BUG] ob-R tests fail on Emacs 27 since ESS commit 536b5b914a7 [9.7-pre (release_9.6.4-318-gcfe5e0.dirty @ /home/yantar92/.emacs.d/straight/build/org/)] To: Ihor Radchenko Cc: emacs-orgmode@gnu.org, ESS-core@r-project.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=lionel.hry@gmail.com; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681823759; a=rsa-sha256; cv=none; b=oazhV1PSlx2oUNCme2jZSgTOF5jbHg/wsjdBsQo0iXqKDmTTTfCE/qy8ok9yOHjSA7+zr0 qZNjCEq04ZCHIxOzkfQeckWvHXp51IDIz/Tunj+H25jP/QQ0D9cFhpHKmcZkMrYSWqbagH z1JLaE3P644M/L//FtV70ReF+rLh+H6rGd/pZKjSvAJRZcB+Hkxnj4s8re9IQ94ls4doSZ DtzRfVd4tD4kq8G/4IaDvGogPyRUd31kBcCLoYtqgsyjzNn6r6xwGnE8O1iJpu+vdUFYd7 hq8AXVvTwxbsv1Z2Z1V00e9JQQM6rSpbc+emxY971jBCKevTeiIo0gZtf4mnvw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Fbnw+7rp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681823759; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=vvkINsgzXcONyJeg1qDYFcRuw9ilfPJdayS8ziNBXXo=; b=CcLcoja6uUUMNCOIFikBik/mGD4g/RjPnq+qx86NWT7K5CFYERpGXlTPYNfer03fYKeFCB Lr8TxrEcjz5jZXFqo5BenpCMJwY723VQVBm8oO3DxDJdhWjL8c7RSS78HPxAC1e1vS690I NmeHDf6qCKyNvk2gUZIn1mcvXO7q9qEkySbcyvY9H3cPXbInTSQv4qZ4dghL4xnZti4j0f W7R5PtxEIwCCWSBjqGr/+f0OGSPOsLQUybgh+/VvjfSE2ufGMpY72ST6o8iCxhJsQBzGBJ +9jXrjQovTThlv8pkHgkxG33NZVFPxb+Ges4YtHPY4HTLvSgBPqJ8vdeDw4ayA== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -4.95 X-Spam-Score: -4.95 X-Migadu-Queue-Id: 59FA66638 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Fbnw+7rp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-TUID: iPybQ2TAfde7 > Do note that the root cause remains on the ESS side - `run-ess-r' in > Emacs 27, when called non-interactively, may set line splitting to > something strange. I think you're right. Probably we shouldn't be executing screen options when called non-interactively and instead leave the R default width (80). I've opened an issue to track this: https://github.com/emacs-ess/ESS/issues/1248 Best, Lionel On 4/18/23, Ihor Radchenko wrote: > Lionel Henry writes: > >> Can you try with the latest commit please? >> https://github.com/emacs-ess/ESS/commit/ed6c12ee3dfb1046fb030200f45e75a65b31e49e > > Works now. Thank you! > >> By the way, it looks like you're setting the width in the exported >> initialization routine rather than just in tests. For user-facing >> features at least you probably want to set the width to something that >> will produce readable output. > > You are right. For some reason, I thought that the problem also affects > :results value, when we want to convert ESS interactive output into > Elisp data. But it was not the case - only :results output has been > affected. > > Since we have no reason to disregard ESS output settings in :results > output, I pushed an alternative fix that only affects tests, as you > suggested. > > Do note that the root cause remains on the ESS side - `run-ess-r' in > Emacs 27, when called non-interactively, may set line splitting to > something strange. I am unsure if it is something that should be fixed > on ESS side. I am also unsure if the problem does not happen in other > Emacs versions. > > Fixed, on main. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=83e446ea8 > > I also added a test for :results value when the output is long. Just in > case. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3c449cc43 > > -- > Ihor Radchenko // yantar92, > Org mode contributor, > Learn more about Org mode at . > Support Org development at , > or support my work at >