From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id WKWIJDGRPmTT5AAASxT56A (envelope-from ) for ; Tue, 18 Apr 2023 14:46:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id sII/JDGRPmRVOwEAauVa8A (envelope-from ) for ; Tue, 18 Apr 2023 14:46:41 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4B0E63FAC5 for ; Tue, 18 Apr 2023 14:46:41 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pokiY-0003My-M9; Tue, 18 Apr 2023 08:45:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poVQb-0005Qh-R9 for emacs-orgmode@gnu.org; Mon, 17 Apr 2023 16:26:21 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1poVQa-00016g-8B for emacs-orgmode@gnu.org; Mon, 17 Apr 2023 16:26:21 -0400 Received: by mail-ej1-x62c.google.com with SMTP id a5so11001903ejb.6 for ; Mon, 17 Apr 2023 13:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681763177; x=1684355177; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RB2u5+zx9D9gD39vNOKfO0VWjDNs57bwmVut6Slyk00=; b=Fo34l+g7K+HXRFWJgGbEgXRr7AiV1yR3Gg8nP6vE5Xbp2TfNwW7MtttWzq71JbuuWy 5ySWPjRAV7yswlZUfqYvpJ9AklsyXTRN0MAS5MFA71jsDqSNl6Akh/L/eQZ+ajtSgWs3 CTblM3Pz/KQD9HTTw3CznUCViWefulELPy6fMTAnsOrPIWpp1u+Au7OvhV/PW4lV/PS1 9dEYLOQgBrxUg7OnWoB7g+rPuL2fjk/a455KuQvSPdfgYBbEglKa+1/BHQT/oo8I6IUl 6N4tUhllWme1IkZuGnGsSpW5z932/PU6oQBMoHgUrS4JtHGt/+4M7B4Ca1oFAFGxDZog GQeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681763177; x=1684355177; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RB2u5+zx9D9gD39vNOKfO0VWjDNs57bwmVut6Slyk00=; b=O49rNnkHQYzH6l5qahlnIeQx/NzXSNSK6mkZGCgFAMtmeT0JlMQhqw+i9a2b/EIU03 id4Q4ynEEQ7VF2vLn26ZTrw5LpUKdur+KunnNnfF9hrmDnfbztw22YEU2GooVzTvSzth skz8tNZ4+cW9yd1fpNcue13z+LCggxY3joTpziZEeAhXgCAYrmV/DsWHqlTLXae8eFMl ofLTC7BHjm9ZHn2+cVGd9hbK8LGaSvEisTh3bE/h2Y8bwiJQz9jnbSE42q0MbWidnV/R 58uf24TOIXA44oB8V8G/K2a0gv4IGkR0Qgu2e1oYAs3P0dHrpv72czgA5OnXcqQXW/VT sEig== X-Gm-Message-State: AAQBX9eqcbJvv/vYXtcrgifywpEKCZpfjfWM1+FbAhofY6xwQoj0ZTsr hw7pzwtoCHUKzAORCiUjMoh20W/GilUSbPpCAGc= X-Google-Smtp-Source: AKy350bVUrf7xwoCpldr9DbZADRU3C9cViJW4kyDgV9EC64udAx1SE4DryrZ6sguFV50vQec3gVrhVeEZSHmmYTAjws= X-Received: by 2002:a17:906:b145:b0:94e:cd53:21f with SMTP id bt5-20020a170906b14500b0094ecd53021fmr8464339ejb.64.1681763177478; Mon, 17 Apr 2023 13:26:17 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a17:907:d307:b0:94f:2d6f:2c5f with HTTP; Mon, 17 Apr 2023 13:26:16 -0700 (PDT) In-Reply-To: <87ilduqrem.fsf@localhost> References: <87ilduqrem.fsf@localhost> From: Lionel Henry Date: Mon, 17 Apr 2023 22:26:16 +0200 Message-ID: Subject: Re: [BUG] ob-R tests fail on Emacs 27 since ESS commit 536b5b914a7 [9.7-pre (release_9.6.4-318-gcfe5e0.dirty @ /home/yantar92/.emacs.d/straight/build/org/)] To: Ihor Radchenko Cc: emacs-orgmode@gnu.org, ESS-core@r-project.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=lionel.hry@gmail.com; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 18 Apr 2023 08:45:52 -0400 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Fo34l+g7; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681822001; a=rsa-sha256; cv=none; b=cagp0TPGR8m0cQCqzRymWZHsrLiZBzYrrmJcjylmjdywDXXDCB3YxmIJnAPkvSfadTAKsg nvrYQCqWBRn82fdeY43vqZz1ZtCUVDAOX2r6+Db47p232mnLtG3cF2JY4eysgdlqcX+bQx 3EguruRJdkHAFkJn+s7epzwTF9gcZNe9PHT+p32x/TeT/pLqK1Qh7EVym93MztL540aB/K 4WgKApUBFB3zEtoA0UpgLsaQFyY8t7to9PlYiTJD1cONSYyh2y9/vewq3mEnmifXieUQ8r SSW/XrSXBie23RMXq2uqGgEk7mQlf9f3mFBXs5RGnwuw0sbIGo9uvbtgG5xeJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681822001; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RB2u5+zx9D9gD39vNOKfO0VWjDNs57bwmVut6Slyk00=; b=ND0oPbAT0mYxVNGQ8ATI8weuYWIgRxIakpEVaiasIct0xjP35g/3aRkoL4XZJ5rh4b9ugH qghopjc2DQQfzH/hSnuqk/Ywbr1SN8PEV2qAHMfVKYECG0PDRJhLkN/+I+lPV3VhDi7RFd 6Q65+6Klpn5/wh6dXWiPEFKZd9xUtxdrwmTmd7F5Q5zhMXfY+DkoKbPtmyFlq3YzEiMviQ dPqcfKFR22OdfY8BPgl3+UTVBnWKwqylxDIdPq3hI6ougDLmqGjTBxFiGQ5OV3MNwtB/vD zGpaVl/68yQHEFz/ka7MaZLBvPeEvXHy6B54RSUwNiDNgteqXZfgX5MACItqOg== X-Migadu-Spam-Score: -6.55 X-Spam-Score: -6.55 X-Migadu-Queue-Id: 4B0E63FAC5 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Fo34l+g7; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com X-TUID: 2m2xYYMg+69b Hi Ihor, Thanks for looking into this. I think you're right it's probably caused by ESS now setting the width on startup. In that case you could fix your tests by setting `options(width = )` to some hardcoded value. You could do it via `ess-r-post-run-hook`. Best, Lionel On 4/17/23, Ihor Radchenko wrote: > > Steps to reproduce: > > 1. cd /path/to/org/git/repo > 2. make test EMACS=emacs-27 BTEST_POST="-L /path/to/ESS/lisp -l ob-R -l ess > -l ess-r-mode" BTEST_RE="async" > > 3 unexpected results: > FAILED ob-session-async-R-named-output > FAILED ob-session-async-R-output-drawer > FAILED ob-session-async-R-simple-session-async-output > > The tests started failing since 2023/04/04. > https://builds.sr.ht/~bzg/job/968099 > > I bisected the failure down to the following ESS commit: > > 536b5b914a75afa37ee05aa8ba0aecd0f9c9eb33 > Author: Lionel Henry > AuthorDate: Mon Apr 3 13:01:11 2023 +0200 > Commit: Lionel Henry > CommitDate: Mon Apr 3 13:01:11 2023 +0200 > > Parent: fef059c3 Wait for process after `ess-r-post-run-hook` > Contained: master > Follows: ESSRv1.8 (21) > > Move `ess-r` startup commands out of `ess-r-post-run-hook` > > They are blocking commands and the user might have added streaming > commands to the hook. > > Also document why users should be careful when mixing blocking and > streaming commands. > > ------ > > I am not sure what is going on as ob-R does not really use the changed > hooks. The suspects are > > (ess-execute-screen-options t) > (ess-set-working-directory default-directory))) > > In particular, I think that `ess-execute-screen-options' is doing > something funny because one of the tests fails with > > "1:5" outputting > > 1 2 3 > 4 5 > > split into two lines, which looks like some text filling problem. > > -- > Ihor Radchenko // yantar92, > Org mode contributor, > Learn more about Org mode at . > Support Org development at , > or support my work at >