emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Bugfix to org-babel-remove-temporary-stable-directory
@ 2022-07-06 20:37 Mark Dawson
  2022-07-07  9:32 ` Ihor Radchenko
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Dawson @ 2022-07-06 20:37 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

* ob-core.el (org-babel-remove-temporary-stable-directory): This
function was failing when `org-babel-temporary-stable-directory' was
nil.  This variable is nil when initialised.  The function
now checks that the variable is non-nil before attempting to call
`file-exists-p`.
TINYCHANGE
---
 lisp/ob-core.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/ob-core.el b/lisp/ob-core.el
index 6c379c121..d4a50734d 100644
--- a/lisp/ob-core.el
+++ b/lisp/ob-core.el
@@ -3265,6 +3265,7 @@ constructed like the following: PREFIXDATAhashSUFFIX."
 (defun org-babel-remove-temporary-stable-directory ()
   "Remove `org-babel-temporary-stable-directory' and on Emacs shutdown."
   (when (and (boundp 'org-babel-temporary-stable-directory)
+             org-babel-temporary-stable-directory
      (file-exists-p org-babel-temporary-stable-directory))
     (let ((org-babel-temporary-directory
            org-babel-temporary-stable-directory))
-- 
2.34.0

[-- Attachment #2: Type: text/html, Size: 1116 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Bugfix to org-babel-remove-temporary-stable-directory
  2022-07-06 20:37 [PATCH] Bugfix to org-babel-remove-temporary-stable-directory Mark Dawson
@ 2022-07-07  9:32 ` Ihor Radchenko
  0 siblings, 0 replies; 2+ messages in thread
From: Ihor Radchenko @ 2022-07-07  9:32 UTC (permalink / raw)
  To: markgdawson; +Cc: emacs-orgmode

Mark Dawson <markgdawson@gmail.com> writes:

> * ob-core.el (org-babel-remove-temporary-stable-directory): This
> function was failing when `org-babel-temporary-stable-directory' was
> nil.  This variable is nil when initialised.  The function
> now checks that the variable is non-nil before attempting to call
> `file-exists-p`.
> TINYCHANGE

Thanks for the patch!
I applied a different fix.
See https://list.orgmode.org/87let71hy0.fsf@yandex.com/T/#t

Best,
Ihor


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-07-07  9:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-06 20:37 [PATCH] Bugfix to org-babel-remove-temporary-stable-directory Mark Dawson
2022-07-07  9:32 ` Ihor Radchenko

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).