I've made the suggested changes, with the exception of the "part of Emacs bit", as this should go in contrib not core. I asked Bastien privately about getting access to the git repository, but will ask here as well: When I run 'git clone orgmode@orgmode.org:org-mode.git' I get a response saying "Permission denied (publickey). fatal: Could not read from remote repository" Does that mean my key wasn't properly added, or did I miss some required set-up? Best, Ista On Tue, Jul 29, 2014 at 10:36 AM, Bastien wrote: > Hi Ista, > > some comments on the code below. > > Ista Zahn writes: > >> ;; Copyright (C) 2014 Ista Zahn >> ;; Author: Ista Zahn, based on ob-julia.el by G. Jay Kerns, and ob-R.el >> ;; by Eric Schulte and Dan Davison > > You need to reformat this -- see files with multiple authors in Org or > in Emacs. > >> ;; This file is not part of GNU Emacs. > > We plan to add this to Org's core, so this will be part of Emacs. > >> ;; Stata and ESS are required. > > Maybe add some links for the requirements. > >> (defcustom org-babel-stata-command inferior-STA-program-name >> "Name of command to use for executing stata code." >> :group 'org-babel >> :version "24.4" >> :package-version '(Org . "8.0") > ^^^ > > This needs to be 8.3 > >> ;; The following was a very complicated write object command >> ;; The replacement needs to add error catching >> ;(defvar org-babel-stata-write-object-command "{function(object,transfer.file){object;invisible(if(inherits(try({tfile<-tempfile();write.table(object,file=tfile,sep=\"\\t\",na=\"nil\",row.names=%s,col.names=%s,quote=FALSE);file.rename(tfile,transfer.file)},silent=TRUE),\"try-error\")){if(!file.exists(transfer.file))file.create(transfer.file)})}}(object=%s,transfer.file=\"%s\")") > > Maybe simply remove this, or make it more readable. > > Thanks in advance for this contribution! > > -- > Bastien