From: Pride Allman <email@example.com> To: firstname.lastname@example.org Subject: [PATCH] lisp/org-table.el: Use booktabs on org-table-export Date: Mon, 9 May 2022 18:29:53 -0400 [thread overview] Message-ID: <CA+VaMHtG5xZiWChm1XEv2+WafQD0SJQXnsYsW71mxQogr_-Azg@mail.gmail.com> (raw) [-- Attachment #1.1: Type: text/plain, Size: 1711 bytes --] Hello, This is my first patch so hopefully I followed the instructions correctly, While using ~org-table-export~ on a table directly even with ~org-latex-tables-booktabs~ set to ~t~, it exports a normal table instead of booktabs table. But on the same situation, if you export the whole buffer the table will be exported according to booktabs. So my theory was there is a discrepancy between the method used by ~org-latex-export-to-latex~ and the ~org-table-export~. And on browsing the codes for those two I found this. The code for ~org-latex-table-row~ used by latex export backend has this line: #+begin_src emacs-lisp :tangle yes (booktabsp (if (plist-member attr :booktabs) (plist-get attr :booktabs) (plist-get info :latex-tables-booktabs))) #+end_src Shows that it also takes into account the ~info~ plist. I couldn't find out what that info plist has, but I can assume it's the information on the overall buffer or that table's context, and it has the effect of using the booktabs from the config. While the code for ~orgtbl-to-latex~ shows it only takes into account the ~booktabs~ parameter on latex table. #+begin_src emacs-lisp :tangle yes :latex-tables-booktabs (plist-get params :booktabs) #+end_src So I tried changing the line in ~orgtbl-to-latex~ to #+begin_src emacs-lisp :tangle yes :latex-tables-booktabs (if (plist-member params :booktabs) (plist-get params :booktabs) org-latex-tables-booktabs) #+end_src So if there is ~booktabs~ parameter then it'll overwrite the settings but if not it'll use the booktabs config. There is probably a better way to use it, but this works for now so I tried this. Please find the attached patch with the fix. Regards, Gaurav [-- Attachment #1.2: Type: text/html, Size: 2003 bytes --] [-- Attachment #2: 0001-lisp-org-table.el-Use-booktabs-on-org-table-export.patch --] [-- Type: text/x-patch, Size: 1528 bytes --] From 264fb8b7f2c5782c92c5beffe54ac18c97b4b685 Mon Sep 17 00:00:00 2001 From: Gaurav <email@example.com> Date: Mon, 9 May 2022 18:05:52 -0400 Subject: [PATCH] lisp/org-table.el: Use booktabs on org-table-export * lisp/org-table.el (orgtbl-to-latex): Read booktabs flag from `org-latex-tables-booktabs' if `:booktabs' is not present in table `params'. Problem was while using ~org-table-export~ on a table directly even with ~org-latex-tables-booktabs~ set to ~t~, it exports a normal table instead of booktabs table. But on the same point, if you export the whole buffer the table will be exported according to booktabs. I looked at the discrepancy between the method used by ~org-latex-export-to-latex~ and the ~org-table-export~ and did this to fix it. TINYCHANGE --- lisp/org-table.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/org-table.el b/lisp/org-table.el index b160dc97c..46498f119 100644 --- a/lisp/org-table.el +++ b/lisp/org-table.el @@ -6000,7 +6000,9 @@ supported. It is also possible to use the following ones: (list :backend 'latex :latex-default-table-mode 'table :latex-tables-centered nil - :latex-tables-booktabs (plist-get params :booktabs) + :latex-tables-booktabs (if (plist-member params :booktabs) + (plist-get params :booktabs) + org-latex-tables-booktabs) :latex-table-scientific-notation nil :latex-default-table-environment (or (plist-get params :environment) "tabular")) -- 2.36.1
next reply other threads:[~2022-05-09 22:31 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-09 22:29 Pride Allman [this message] 2022-05-11 12:19 ` Ihor Radchenko 2022-05-11 17:01 ` Pride Allman 2022-05-12 9:29 ` Ihor Radchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CA+VaMHtG5xZiWChm1XEv2+WafQD0SJQXnsYsW71mxQogr_-Azg@mail.gmail.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] lisp/org-table.el: Use booktabs on org-table-export' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).