From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Dudebout Subject: Re: [PATCH] org-agenda: make log and clockreport modes local Date: Thu, 22 Feb 2018 09:20:28 -0500 Message-ID: References: <87h8q9i1nr.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113fb198ea02700565cdbe27" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eorjc-0005j1-8R for emacs-orgmode@gnu.org; Thu, 22 Feb 2018 09:20:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eorja-0004hi-Vy for emacs-orgmode@gnu.org; Thu, 22 Feb 2018 09:20:32 -0500 Received: from mail-lf0-x22b.google.com ([2a00:1450:4010:c07::22b]:38264) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eorja-0004gt-O8 for emacs-orgmode@gnu.org; Thu, 22 Feb 2018 09:20:30 -0500 Received: by mail-lf0-x22b.google.com with SMTP id g72so7626930lfg.5 for ; Thu, 22 Feb 2018 06:20:30 -0800 (PST) In-Reply-To: <87h8q9i1nr.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org --001a113fb198ea02700565cdbe27 Content-Type: text/plain; charset="UTF-8" Thank you. I signed FSF papers in November 2015 for use-package's inclusion to emacs. On Thu, Feb 22, 2018 at 8:39 AM, Nicolas Goaziou wrote: > Hello, > > Nicolas Dudebout writes: > > > `org-agenda-show-log' indicates if the the current agenda buffer has > > log-mode enabled. When building a new agenda buffer, it gets its > > value from `org-agenda-start-with-log-mode'. It is is semantically a > > buffer local variable: when creating a new agenda buffer you expect it > > to be set to the value in `org-agenda-start-with-log-mode'. However, > > 2e9c2d71 while fixing an issue with sticky agendas rendered the > > variable `org-agenda-log-mode' effectively global: toggling log mode > > in a given agenda buffer modifies the global default for all agenda > > buffers. The same reasoning holds for clockreport mode. > > > > This change ensures that a log or clockreport mode change made in one > > agenda buffer does not propagate to other agenda buffers, existing or > > new. The change is however preserved on org-agenda-redo in the > > initial agenda buffer, whether using sticky agendas or not. > > Applied. Thank you. > > I don't know if you signed FSF papers already. Therefore, I added > TINYCHANGE at the end of the commit message. > > Regards, > > -- > Nicolas Goaziou > --001a113fb198ea02700565cdbe27 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you.

I signed FSF papers in Novemb= er 2015 for use-package's inclusion to emacs.

On Thu, Feb 22, 2018 at 8:39 AM, = Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
Hello,

Nicolas Dudebout <nicolas.= dudebout@gmail.com> writes:

> `org-agenda-show-log' indicates if the the current agenda buffer h= as
> log-mode enabled.=C2=A0 When building a new agenda buffer, it gets its=
> value from `org-agenda-start-with-log-mode'.=C2=A0 It is is s= emantically a
> buffer local variable: when creating a new agenda buffer you expect it=
> to be set to the value in `org-agenda-start-with-log-mode'.= =C2=A0 However,
> 2e9c2d71 while fixing an issue with sticky agendas rendered the
> variable `org-agenda-log-mode' effectively global: toggling log mo= de
> in a given agenda buffer modifies the global default for all agenda > buffers.=C2=A0 The same reasoning holds for clockreport mode.
>
> This change ensures that a log or clockreport mode change made in one<= br> > agenda buffer does not propagate to other agenda buffers, existing or<= br> > new.=C2=A0 The change is however preserved on org-agenda-redo in the > initial agenda buffer, whether using sticky agendas or not.

Applied. Thank you.

I don't know if you signed FSF papers already. Therefore, I added
TINYCHANGE at the end of the commit message.

Regards,

--
Nicolas Goaziou

--001a113fb198ea02700565cdbe27--