From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew MacLean Subject: Re: fa5fd6351605912ec75e783cb62649 breaks org-babel-script-escape for ob-ruby Date: Tue, 11 Aug 2015 21:24:13 -0600 Message-ID: References: <87h9o5316t.fsf@kyleam.com> <87bned311f.fsf@kyleam.com> <874mk5coqy.fsf@kmlap.domain.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11c36216e5b909051d14c1f8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPMeZ-000248-BG for emacs-orgmode@gnu.org; Tue, 11 Aug 2015 23:24:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPMeX-0004FK-Vw for emacs-orgmode@gnu.org; Tue, 11 Aug 2015 23:24:35 -0400 Received: from mail-ob0-x22d.google.com ([2607:f8b0:4003:c01::22d]:35291) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPMeX-0004FG-P4 for emacs-orgmode@gnu.org; Tue, 11 Aug 2015 23:24:33 -0400 Received: by obbop1 with SMTP id op1so3722626obb.2 for ; Tue, 11 Aug 2015 20:24:33 -0700 (PDT) In-Reply-To: <874mk5coqy.fsf@kmlap.domain.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Kyle Meyer Cc: emacs-orgmode@gnu.org --001a11c36216e5b909051d14c1f8 Content-Type: multipart/alternative; boundary=001a11c36216e5b902051d14c1f6 --001a11c36216e5b902051d14c1f6 Content-Type: text/plain; charset=UTF-8 If the stricter definition covers everything that org-babel-escape-script was supposed to do... I agree we should keep it. My problem was I wasn't sure if the function got pruned of something it needed. But if that's not the case... On Tue, Aug 11, 2015 at 6:52 PM, Kyle Meyer wrote: > Feel free to wait to hear others' thoughts on this, but, in any case, > please use 'git format-patch' to generate a patch with a commit message > (see the contributing section of the website [1] for more information). > Also, it'd be nice to add a test that catches the original error. > ...here is the git format-patch of the ob-ruby.el change! I also created one for a test to check for basic Ruby evaluation capabilities. It should catch errors that break evaluation like this in ob-ruby. (I find it interesting that the session tests worked without the double-escape change actually.) --001a11c36216e5b902051d14c1f6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
If t= he stricter definition covers everything that org-babel-escape-script was s= upposed to do... I agree we should keep it.
My problem was I wasn&= #39;t sure if the function got pruned of something it needed.

=
But if that's not the case...

On Tue, Aug 11, 2015 a= t 6:52 PM, Kyle Meyer <kyle@kyleam.com> wrote:
Feel free to wait to hear others' thoughts on this, but, in any case,<= br> please use 'git format-patch' to generate a patch with a commit mes= sage
(see the contributing section of the website [1] for more information).
Also, it'd be nice to add a test that catches the original error.
=

...here is the git = format-patch of the ob-ruby.el change!

I also created one for a test to check for basic Ruby evaluation capabi= lities. It should catch errors that break evaluation like this in ob-ruby. = (I find it interesting that the session tests worked without the double-esc= ape change actually.)
--001a11c36216e5b902051d14c1f6-- --001a11c36216e5b909051d14c1f8 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Removed-double-escape-in-ob-ruby.el-In-org-babel-rub.patch" Content-Disposition: attachment; filename="0001-Removed-double-escape-in-ob-ruby.el-In-org-babel-rub.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_id87mbn30 RnJvbSAwNzA1MmI0YWQwZjUxZjI0NTM0YzVlZTI4OTk1MTFjZmI2NThhZTcxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBcmNoZW5vdGggPGFyY2hlbm90aEBnbWFpbC5jb20+CkRhdGU6 IFR1ZSwgMTEgQXVnIDIwMTUgMjA6Mjk6NTMgLTA2MDAKU3ViamVjdDogW1BBVENIIDEvMl0gUmVt b3ZlZCBkb3VibGUtZXNjYXBlIGluIG9iLXJ1YnkuZWwgKEluCiBvcmctYmFiZWwtcnVieS1ldmFs dWF0ZSkKClRoZSBvbmx5IHRpbWUgb3JnLWJhYmVsLXJ1YnktZXZhbHVhdGUgaXMgY2FsbGVkIGlz IGluCm9yZy1iYWJlbC1leGVjdXRlOnJ1YnksIHdoZXJlIGl0cyByZXN1bHQgZWl0aGVyIGVzY2Fw ZWQgKFRoZSBkb3VibGUKZXNjYXBlKSBvciBwYXNzZWQgaW4gYXMgdGhlICJzY2FsYXItZm9ybSIg b2Ygb3JnLWJhYmVsLXJlc3VsdC1jb25kIHdoaWNoCmhhbmRsZXMgdGhlICJwcCIgYW5kICJjb2Rl IiBwYXJhbWV0ZXJzLiAoU28sIHBsYWNlcyB0aGF0IGRvbid0IG5lZWQKZXNjYXBpbmcuKQotLS0K IGxpc3Avb2ItcnVieS5lbCB8IDYgKy0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24o KyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9vYi1ydWJ5LmVsIGIvbGlzcC9v Yi1ydWJ5LmVsCmluZGV4IDliMDFkYmYuLjBmZjQ2MGUgMTAwNjQ0Ci0tLSBhL2xpc3Avb2ItcnVi eS5lbAorKysgYi9saXNwL29iLXJ1YnkuZWwKQEAgLTIwMSwxMSArMjAxLDcgQEAgcmV0dXJuIHRo ZSB2YWx1ZSBvZiB0aGUgbGFzdCBzdGF0ZW1lbnQgaW4gQk9EWSwgYXMgZWxpc3AuIgogCQkJICAg ICAgb3JnLWJhYmVsLXJ1YnktcHAtd3JhcHBlci1tZXRob2QKIAkJCSAgICBvcmctYmFiZWwtcnVi eS13cmFwcGVyLW1ldGhvZCkKIAkJCSAgYm9keSAob3JnLWJhYmVsLXByb2Nlc3MtZmlsZS1uYW1l IHRtcC1maWxlICdub3F1b3RlKSkpCi0JCSAobGV0ICgocmF3IChvcmctYmFiZWwtZXZhbC1yZWFk LWZpbGUgdG1wLWZpbGUpKSkKLSAgICAgICAgICAgICAgICAgICAoaWYgKG9yIChtZW1iZXIgImNv ZGUiIHJlc3VsdC1wYXJhbXMpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAobWVtYmVyICJw cCIgcmVzdWx0LXBhcmFtcykpCi0gICAgICAgICAgICAgICAgICAgICAgIHJhdwotICAgICAgICAg ICAgICAgICAgICAgKG9yZy1iYWJlbC1ydWJ5LXRhYmxlLW9yLXN0cmluZyByYXcpKSkpKSkKKwkJ IChvcmctYmFiZWwtZXZhbC1yZWFkLWZpbGUgdG1wLWZpbGUpKSkpCiAgICAgOzsgY29taW50IHNl c3Npb24gZXZhbHVhdGlvbgogICAgIChjYXNlIHJlc3VsdC10eXBlCiAgICAgICAob3V0cHV0Ci0t IAoyLjUuMAoK --001a11c36216e5b909051d14c1f8 Content-Type: text/x-patch; charset=US-ASCII; name="0002-Add-test-that-basic-Ruby-evaluation-works-with-ob-ru.patch" Content-Disposition: attachment; filename="0002-Add-test-that-basic-Ruby-evaluation-works-with-ob-ru.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_id87mbnn1 RnJvbSA0MDg2NDg1MmQ5ZjA5OTZjNGY3NTUzNzdhODMyNmYyY2JhZTQxN2VjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBcmNoZW5vdGggPGFyY2hlbm90aEBnbWFpbC5jb20+CkRhdGU6 IFR1ZSwgMTEgQXVnIDIwMTUgMjE6MTg6NDQgLTA2MDAKU3ViamVjdDogW1BBVENIIDIvMl0gQWRk IHRlc3QgdGhhdCBiYXNpYyBSdWJ5IGV2YWx1YXRpb24gd29ya3Mgd2l0aCBvYi1ydWJ5CgpUaGlz IHdpbGwgYWxzbyB0ZXN0IHRoYXQgdGhlIHN0cmluZyBlc2NhcGUgc2NoZW5hbmlnYW5zIGFyZSBm aXhlZC4KLS0tCiB0ZXN0aW5nL2xpc3AvdGVzdC1vYi1ydWJ5LmVsIHwgMTcgKysrKysrKysrKysr KysrKysKIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvdGVz dGluZy9saXNwL3Rlc3Qtb2ItcnVieS5lbCBiL3Rlc3RpbmcvbGlzcC90ZXN0LW9iLXJ1YnkuZWwK aW5kZXggZWI1MjMzYi4uNTc2Y2IxMyAxMDA2NDQKLS0tIGEvdGVzdGluZy9saXNwL3Rlc3Qtb2It cnVieS5lbAorKysgYi90ZXN0aW5nL2xpc3AvdGVzdC1vYi1ydWJ5LmVsCkBAIC0yMSw2ICsyMSwy MyBAQAogKHVubGVzcyAoZmVhdHVyZXAgJ29iLXJ1YnkpCiAgIChzaWduYWwgJ21pc3NpbmctdGVz dC1kZXBlbmRlbmN5ICJTdXBwb3J0IGZvciBSdWJ5IGNvZGUgYmxvY2tzIikpCiAKKyhlcnQtZGVm dGVzdCB0ZXN0LW9iLXJ1YnkvYmFzaWMtZXZhbHVhdGlvbiAoKQorICAiVGVzdCB0aGF0IGJhc2lj IGV2YWx1YXRpb24gd29ya3MuIgorICAgIChzaG91bGQgKGVxdWFsIChvcmctdGVzdC13aXRoLXRl bXAtdGV4dCAiIytiZWdpbl9zcmMgcnVieQorIDIgKyAyCisjK2VuZF9zcmMiCisgIChvcmctYmFi ZWwtZXhlY3V0ZS1tYXliZSkKKyAgKHN1YnN0cmluZy1uby1wcm9wZXJ0aWVzCisgICAoYnVmZmVy LXN0cmluZykpKQorCQkgICAiIytiZWdpbl9zcmMgcnVieQorIDIgKyAyCisjK2VuZF9zcmMKKwor IytSRVNVTFRTOgorOiA0CisKKyIpKSkKKwogKGVydC1kZWZ0ZXN0IHRlc3Qtb2ItcnVieS9zZXNz aW9uLW91dHB1dC0xICgpCiAgICAgKHNob3VsZCAoZXF1YWwgKG9yZy10ZXN0LXdpdGgtdGVtcC10 ZXh0ICIjK2JlZ2luX3NyYyBydWJ5IDpzZXNzaW9uIDpyZXN1bHRzIG91dHB1dAogcyA9IFwiMVwi Ci0tIAoyLjUuMAoK --001a11c36216e5b909051d14c1f8--