From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iHeUKoX7oGNY+wAAbAwnHQ (envelope-from ) for ; Tue, 20 Dec 2022 01:02:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id SECYKoX7oGPzKQAAauVa8A (envelope-from ) for ; Tue, 20 Dec 2022 01:02:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 81ABD28C67 for ; Tue, 20 Dec 2022 01:02:13 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7Q4D-0003Z9-Ku; Mon, 19 Dec 2022 19:01:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7Q49-0003Xv-6h for emacs-orgmode@gnu.org; Mon, 19 Dec 2022 19:01:05 -0500 Received: from mail-yw1-x1136.google.com ([2607:f8b0:4864:20::1136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7Q46-0004iV-Q1 for emacs-orgmode@gnu.org; Mon, 19 Dec 2022 19:01:04 -0500 Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-3b48b139b46so148396877b3.12 for ; Mon, 19 Dec 2022 16:01:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2oKtQhkHZO/l4yvPQl0hahekiMLJvo+LdW9DBWJ0UsQ=; b=iE3R3MXcY9q+QOYCaeaY2ytqJCSgaCV/lI76ndckCahhQlnHo9NLjljf6O87Y1M/Bk eaMo987fNvzzRka8i35y90BmyfyPj9rI/R857dG+QQwlPwcUei3A0vCXejtFBvsO8NlM ubIVvSEdNbluiqRJEkq1NHUoNfjAOp7JUn9lij9OBmrplcygeB4nRXCi6aNmOcVhuA3k 2Hdp8Nz105AgNJ8L7OYpUSV+/Hx21xZG6sOTiodVuuIIogPxzFNnqWeto1z9dH7jY6ZT wS5k4+lMy5Doi5ODWAOygvQ/IGZMoX7I+RbzOpMcK9pu8DOZB0yBqM5VO30EG1XcXDD4 6c2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2oKtQhkHZO/l4yvPQl0hahekiMLJvo+LdW9DBWJ0UsQ=; b=ltwPtugofZ2+hr74bbIWv5rRNnb0VkeHL7GEtlNkNF4GTCSTtTmpPFhVHQeZuu2rYU KUKuu36zi0CkmEiWw8MH+KFDxO9ZDVfMvKinfF4vo/ctG4vhU9Ej8pSBPLOmRd7oVlpj OPy7HU8xHDTnYcwPpxS5c8Qyg2evwM/W/6rNZmfY0GLwx3T1ZGVYdxIwoqORb+piPCl9 jtFmeGQC0+ZXFrmHdvCdN+E+PnlCJs+etuBh7tJoojinU170pTYjOHAogOF+ihAPMlbo owerm06o1km9otIcCl8UVMS1meTCCggB5agdYgxs1S/3X0yEf2rYCPdUI9EyAzdO+CIa 8Qpg== X-Gm-Message-State: ANoB5pmdSC/kanF2oscZYEzm32Kjj+UIpsfhIAl1sTwW4VClNkvzNFT6 KaTXoO+Zw9xHy7PGOgO5pV+sO7lrXQY2VU8AoFQ= X-Google-Smtp-Source: AA0mqf7NL0MiMG8xzHYEL2XLkRSmmWgNy0DO+Xpw+TPqE8Cf48oTGVbZh2Iz7o1MJomECYls88mdMRchFjawtjAJRHg= X-Received: by 2002:a81:1ec8:0:b0:367:a786:8318 with SMTP id e191-20020a811ec8000000b00367a7868318mr12998553ywe.367.1671494460958; Mon, 19 Dec 2022 16:01:00 -0800 (PST) MIME-Version: 1.0 References: <87359ld5ye.fsf@kyleam.com> <874ju0j538.fsf@localhost> <87len9uj5s.fsf@localhost> <87ilicua53.fsf@localhost> <86len8uxmu.fsf@gmail.com> <87o7s3swyt.fsf@localhost> <86h6xvvl30.fsf@gmail.com> <87k02o6bgv.fsf@localhost> <86tu1sidg6.fsf@gmail.com> In-Reply-To: <86tu1sidg6.fsf@gmail.com> From: Tom Gillespie Date: Mon, 19 Dec 2022 19:00:49 -0500 Message-ID: Subject: Re: [PATCH] ob-core: add org-confirm-babel-evaluate-cell custom variable To: Tim Cross Cc: Ihor Radchenko , emacs-orgmode@gnu.org Content-Type: multipart/alternative; boundary="00000000000096ecfb05f03721dd" Received-SPF: pass client-ip=2607:f8b0:4864:20::1136; envelope-from=tgbugs@gmail.com; helo=mail-yw1-x1136.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iE3R3MXc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671494533; a=rsa-sha256; cv=none; b=idKnVrqz+Y2nw2peJR84UQ+b5Dkona7z0mOwkPs/I7WRqwB+9Es2nyPZg0W9ynrID4kuy/ QE3+dm8eNTaFFzbjt/GiqqVQfsXyZHgbEtranE9/5756hMXuwqRl3u5OqvH25JbHBuLG1Y rsVB1oV9v7DbHIlO5c4uxki+RDaHS8eBd14WHG6RA3GYi5fc2ITRnaUU0jFR4KKKTS1pZ6 VI/etmnzagZaw8BHIviLSntqj3zgXEzOQGp0ZkuQmoIH0JLJWIKcgRS3f4tZyybK5IxSAm jmpNY9GzOCVcSgqdlD1eyN8oYe/DGg1a1F8ckf1iogpcxuBRvKjXfFnZsxCZPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671494533; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=2oKtQhkHZO/l4yvPQl0hahekiMLJvo+LdW9DBWJ0UsQ=; b=WfeD4EBYE4Egkmxc+zTmkBV4tHl8LM/McwFGCU7iO9pT+7QpLoSJck1CSQCeSOIUo/VwOd wOFHKYK2A3gft7i4pMT0+qMTDr4IPgcMTsM/2IZUaZm5ZIATNVWUPrzrQNknth+2AJNE6c loN9BLPBKf683FcVDbycD2wV/3LrQnAPDoiWTq+euQhtdc5Zybl1qF7inLEuGk7sto8YEN Jn2FQxPI/k74iRGhDCam8dH8A38brthVFe7/jC6mSjlkWKBUls4gVTMAZFej9VmxlE+w+K /QxWVp1LV/mq/pVnpSXS217EiBV886BlbcTb/7MwNDbKViTVWtZUxR4CTwZV9Q== Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iE3R3MXc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -6.01 X-Spam-Score: -6.01 X-Migadu-Queue-Id: 81ABD28C67 X-TUID: eQQV5wfA0Imx --00000000000096ecfb05f03721dd Content-Type: text/plain; charset="UTF-8" By the way, while we're on bugfixes. I just noticed that (format "%S" cell) is being used to create the fake body for info. This is incorrect because cell is already a string at this point and this makes the behavior inconsistent with the rest of org babel as a result. Fix below. Best, Tom The fix is to pass (list "emacs-lisp" cell '((:eval . yes)) nil cell nil nil) --00000000000096ecfb05f03721dd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
By the way, while we're on bugfixes. = I just noticed that (format "%S" cell) is being used to create th= e fake body for info. This is incorrect because cell is already a string at= this point and this makes the behavior inconsistent with the rest of org b= abel as a result. Fix below. Best,
Tom
=

The fix is to pass

(list "emacs-lisp"= cell
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '((:eval . yes)) nil cell
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 nil nil)



--00000000000096ecfb05f03721dd--