From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uAlAJjWMkWJNhAEAbAwnHQ (envelope-from ) for ; Sat, 28 May 2022 04:43:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id qIk5JjWMkWK1IgEA9RJhRA (envelope-from ) for ; Sat, 28 May 2022 04:43:01 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5BB041F808 for ; Sat, 28 May 2022 04:43:01 +0200 (CEST) Received: from localhost ([::1]:38482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1numPs-0006Fz-7s for larch@yhetil.org; Fri, 27 May 2022 22:43:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1numPP-0006DE-71 for emacs-orgmode@gnu.org; Fri, 27 May 2022 22:42:31 -0400 Received: from mail-yw1-x112b.google.com ([2607:f8b0:4864:20::112b]:38312) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1numPN-0005sQ-ML for emacs-orgmode@gnu.org; Fri, 27 May 2022 22:42:30 -0400 Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-2ff7b90e635so64047077b3.5 for ; Fri, 27 May 2022 19:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MZWMe8J0uI0p7lvRXAP01WT3nuUI2kY28ps7akq3QK4=; b=htlCmYR4G8Dvow4E3EwoxNp1tkfD3vg9gxCwqOp9Bpnuf/we7s+K4qvBNVoLrAG4y2 ULPra+MTDmg2YzPZhh/1m5Q5q5unEnzmy6FLA1VaKpno9W6RXduTPzoUC+lrlZuaTlAZ A3AkGryZa6PtMoNK3lzPZIubuEn9fs1rGpJxbDdzF9wbnp5/dHqo6NZcXebJ/TU5ZlBf 9TfD1j5PH2pnowbxnIpZK1Cf+9S2ixoAUN3Sf5m/eRO4LW6cym2Mbr5NCRHkBvKWb6ZH 564M+11zqCyx2gux+yM3gMDUxDcczd4BWQu9W6J7+I7lxVnbzR/lIcFS/YFK7VB8vAEJ 23Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MZWMe8J0uI0p7lvRXAP01WT3nuUI2kY28ps7akq3QK4=; b=LS8jAHMi59Xt9f1MU+7PCclaOebOwhFlze5L7VcVwJm/8+vLkw2HC9nv6jIglTfrf8 UpUEjbzf7ysqKkT7VRbCmmhRPrYkVF4Hm4izg3kcE2mz0Bi66wU19nOTtGOI7/Hk4rdc sRQ9RYtzgJB26/068NfyBOP5Ce3VhHpG7gyxT+n4p75vjlz+jtJvuIQFsWpmMKsWvtah eVbvtGktealqtgvqtG9Td+GMnbVK/wt8KnE8sgf71LFJJauyPHCbmXbcJuAW5t70UK3L PFFJumpOTd3qT7LAMpVqpQSEAGpN5oULcOV0ZK10MN3lmJvis7JzmmaMRHqH/Te+6KxZ xKPw== X-Gm-Message-State: AOAM531jF2g7ZpqwVFGia9O9S3JReMXrI91E0SuktZ04psmY363C1qCf c5VQi861LydG/lhResW1uYeW6a06ZzQso7sSyj4= X-Google-Smtp-Source: ABdhPJxcty0/xcvMnEDEupp8PecBIwSFLUxeQThuDgn24nyAPLrx3ayJEEDsWWGhz6XDPQx3gMLcNtsLOST+g8MZfbw= X-Received: by 2002:a81:304:0:b0:2fe:e17e:4660 with SMTP id 4-20020a810304000000b002fee17e4660mr47930492ywd.236.1653705748539; Fri, 27 May 2022 19:42:28 -0700 (PDT) MIME-Version: 1.0 References: <87y2cvloay.fsf@gnu.org> <149145640c25d2ae191ab87c7056e372f9904370.1643454546.git.yantar92@gmail.com> <87sfpphkfc.fsf@localhost> <877d66e613.fsf@localhost> In-Reply-To: <877d66e613.fsf@localhost> From: Tom Gillespie Date: Fri, 27 May 2022 19:42:17 -0700 Message-ID: Subject: Re: [BUG] 67275f4 broke evil-search Re: [PATCH 10/35] Implement link folding To: Ihor Radchenko Cc: emacs-orgmode Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::112b; envelope-from=tgbugs@gmail.com; helo=mail-yw1-x112b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653705781; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=MZWMe8J0uI0p7lvRXAP01WT3nuUI2kY28ps7akq3QK4=; b=c232JMsCpzbwG9m3tvAsliuJ/svJ24L0YP9o/6QnU7qMTtFTkF65/j21nKchogCGTzqIC9 1n2DdHX2jdaChFTbzw7iBye8ZKfBpLUr6VSqwDwpCrjXzlj5E2asC4b+KD077nQfuuDfbN ktXax57xwHB6RuavW9ndbVG6SGaXg06Tu01uKpbE3cnvL9D8H6A68Dh5JsW+Bg/F/gFbnO Fn1NoZUbTpofF+cSiX9LyGSJGzy1y/sor9A53SH2MuXuBo5yo4B2MIfBq2OFfSFH6iKK0F u+1FmolXhIgfvNLHnpqMytTXA486zx0TMHfhyyFypfmimEmweD4FpIhkU4BT4g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653705781; a=rsa-sha256; cv=none; b=kz0EpGIMw7Uw9F1Hx5sfXGsIKN5RbE+Q1AZ1kGBBjIkiVtQbnHHeiHKqH1sCMsy9h1Kv14 O61PErnk8MeEe8wuudirf26yLBSGoLrlaYXuD31Emye54J4EnywvtuDvp66X9tGnQdx/Xj clMAlK84SmfEVg6g/o3sJpUV142jzLFtA8DEMWjnEOKpyGmOIN3WzpF5rcHapvRJYFZk+Y vuVZekjSdFlWI8nI1kU3Y1CtcV1J4OkCQB3C0ICfu6qQa1rwAt+YKglP26j27QHTSz3Zpb NHzdmH75IvSK5eXvCKCBXM/SZ4Iua83cuBT+Yo5bucYho2m53+HSous0HfuONg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=htlCmYR4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.84 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=htlCmYR4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5BB041F808 X-Spam-Score: -3.84 X-Migadu-Scanner: scn0.migadu.com X-TUID: fcKg3y8QQIyj The workaround from the other thread to (setq org-fold-core-style 'overlays) is perfect. > The whole point of the patch is _not_ using overlays. For performance > reasons. Yep, the workaround is sufficient for now, and the note on performance for large files in the docstring makes it clear what the tradeoffs are, and why we want the text properties to be the default. Not need to "restore" the old behavior since it is just a setq away. > Note that if evil were to comply with the canonical isearch > implementation and respect isearch-mode-end-hook, there would be no > issue. I think we might want to update the documentation to mention issue with evil for now, and alert the evil devs about this change. Then we can approach them about implementing support for searching inside invisible regions marked via text properties since that is essentially a new feature that is being added to org for 9.6, though one that will be on by default. The evil-search module doesn't seem to support _any_ of the isearch hooks needed but while looking into this I think I know generally where it might be possible to add them. Thanks! Tom