From: Tom Gillespie <firstname.lastname@example.org> To: Ihor Radchenko <email@example.com> Cc: Bastien <firstname.lastname@example.org>, emacs-orgmode <email@example.com>, Alan Light <firstname.lastname@example.org> Subject: Re: Bug fix attached: org-babel sql postgres, fix hardcode Date: Sat, 12 Dec 2020 21:11:37 -0500 [thread overview] Message-ID: <CA+G3_POxv=co0cU1YPKB_nc+1LFEtbxrUqWQcEWcCSBH98rhqA@mail.gmail.com> (raw) In-Reply-To: <87wnxm5xyh.fsf@localhost> It looks like the two patches are sequential, there should probably be a rebase into a single patch. I would remove the comment in the second patch because it is a single command to jump to the default value and it might change in the future, so no reason to put it in a comment. One way to communicate about the source of that variable is to include (require 'sql) in ob-sql which is likely needed anyway due to the fact that sql-postgres-program is defined by sql.el and there will be a byte compiler error because the variable is undefined. Having the value of "psql" present as a backup in case sql-postgres-program is somehow nil seems reasonable. Best, Tom
next prev parent reply other threads:[~2020-12-13 2:12 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-08 16:39 Alan Light 2020-12-12 17:59 ` Bastien 2020-12-12 19:53 ` Alan Light 2020-12-13 0:18 ` Ihor Radchenko 2020-12-13 0:31 ` Alan Light 2020-12-13 0:52 ` Ihor Radchenko 2020-12-13 2:11 ` Tom Gillespie [this message] 2021-02-04 4:19 ` Kyle Meyer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CA+G3_POxv=co0cU1YPKB_nc+1LFEtbxrUqWQcEWcCSBH98rhqA@mail.gmail.com' \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: Bug fix attached: org-babel sql postgres, fix hardcode' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).