From: Tom Gillespie <firstname.lastname@example.org> To: email@example.com Cc: emacs-orgmode <firstname.lastname@example.org> Subject: Re: [PATCH] ob-tangle.el: Speed up tangling Date: Tue, 20 Apr 2021 01:33:50 -0700 [thread overview] Message-ID: <CA+G3_PNZVxt_oC8rRnaYdb=A6rwgwH_GPtMpbjcx-VA1yGFOQg@mail.gmail.com> (raw) In-Reply-To: <email@example.com> Hi Sébastien, The temp -> rename approach is good, but you should probably use make-temp-file to create the file to reduce the risk of collisions/race conditions. For example as (make-temp-file (concat file-name ".tangling")). I think that the location of condition-case is ok, but I wonder what would happen if something were to fail before entering that? I think that only a subset of the files would be tangled, but they would all have their correct modes, so I think that that is ok. I also think that the message to the user should probably not be changed right now. While it might can be useful for debug, if someone is tangling to a large number of files then the filenames/paths are going to flood messages, so I would leave it out of this patch, and possibly submit it as another patch for a separate discussion. Best! Tom
next prev parent reply other threads:[~2021-04-20 8:45 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-18 7:22 Sébastien Miquel 2021-04-18 18:47 ` Tom Gillespie 2021-04-19 8:05 ` Sébastien Miquel 2021-04-20 8:33 ` Tom Gillespie [this message] 2021-04-21 6:33 ` Sébastien Miquel 2021-04-21 8:02 ` Timothy 2021-05-01 15:09 ` Bastien 2021-05-01 20:13 ` Sébastien Miquel 2021-05-01 20:32 ` Bastien
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CA+G3_PNZVxt_oC8rRnaYdb=A6rwgwH_GPtMpbjcx-VA1yGFOQg@mail.gmail.com' \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] ob-tangle.el: Speed up tangling' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).