From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Gillespie Subject: Re: [PATCH] org-src: Add option to restore window configuration after edit Date: Sun, 16 Feb 2020 21:27:56 -0800 Message-ID: References: <87blpxq26b.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:54869) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3Yx1-0002nh-AB for emacs-orgmode@gnu.org; Mon, 17 Feb 2020 00:28:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3Yx0-00013L-51 for emacs-orgmode@gnu.org; Mon, 17 Feb 2020 00:28:11 -0500 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]:36965) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j3Ywz-0000zu-UW for emacs-orgmode@gnu.org; Mon, 17 Feb 2020 00:28:10 -0500 Received: by mail-lj1-x242.google.com with SMTP id q23so1218152ljm.4 for ; Sun, 16 Feb 2020 21:28:09 -0800 (PST) In-Reply-To: <87blpxq26b.fsf@kyleam.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Kyle Meyer Cc: emacs-orgmode@gnu.org Hi Kyle, Thank you for the pointer. That does indeed solve my issue. I must have missed it because it wasn't merged into maint. The conversation in that thread seems to indicate that the old behavior is the correct default. I imagine that there might be a few other folks with Matt's use case, but I guess that can wait. Thus, definitely ok to ignore this patch. Best! Tom On Sun, Feb 16, 2020 at 8:16 PM Kyle Meyer wrote: > > Hi Tom, > > Tom Gillespie writes: > > > Hi all, > > After hours of frustration ending in a realization that I should really > > just read the change logs, I tracked down the reason why editing > > source blocks was now destroying my window layout. I restored the > > old behavior hidden behind a custom variable. Let me know if it looks > > ok, or if more work is needed. Thanks! > > I haven't looked at your proposed change closely, but I think this is > the same issue that was reported recently [0] and fixed by d833920de > (org-src: restore windows for some values of org-src-window-setup, > 2019-12-23). If you have a chance, please check whether that commit > resolves the issue for you. > > [0]: https://lists.gnu.org/archive/html/emacs-orgmode/2019-12/msg00263.html