emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [Patch] Add support for geiser-scheme-implementation to lisp/ob-scheme.el
@ 2020-05-31  4:40 Vladimir Nikishkin
  2020-06-08  8:33 ` Vladimir Nikishkin
  0 siblings, 1 reply; 3+ messages in thread
From: Vladimir Nikishkin @ 2020-05-31  4:40 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

Hello, everyone

ob-scheme doesn't seem to be respecting geiser-scheme-implementation,
which is a buffer-local variable to specify which implementation in
particular to use in an org buffer by default.

This 2-line patch adds this support.

Please, consider adding it.

-- 
Yours sincerely, Vladimir Nikishkin

[-- Attachment #2: 0001-Add-support-for-geiser-scheme-implementation-in-ob-s.patch --]
[-- Type: text/x-patch, Size: 1305 bytes --]

From f7b0277b1de47305dbfaeab614cd4530e07921c1 Mon Sep 17 00:00:00 2001
From: Lockywolf <lockywolf@gmail.com>
Date: Sun, 31 May 2020 12:34:53 +0800
Subject: [PATCH] Add support for geiser-scheme-implementation in ob-scheme.el

---
 lisp/ob-scheme.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/ob-scheme.el b/lisp/ob-scheme.el
index 5ca7f871d..3eee8213d 100644
--- a/lisp/ob-scheme.el
+++ b/lisp/ob-scheme.el
@@ -43,6 +43,7 @@
 (require 'geiser-impl nil t)
 (defvar geiser-repl--repl)             ; Defined in geiser-repl.el
 (defvar geiser-impl--implementation)   ; Defined in geiser-impl.el
+(defvar geiser-scheme-implementation)  ; Defined in geiser-impl.el
 (defvar geiser-default-implementation) ; Defined in geiser-impl.el
 (defvar geiser-active-implementations) ; Defined in geiser-impl.el
 (defvar geiser-debug-show-debug-p)     ; Defined in geiser-debug.el
@@ -211,6 +212,7 @@ This function is called by `org-babel-execute-src-block'."
       (let* ((result-type (cdr (assq :result-type params)))
 	     (impl (or (when (cdr (assq :scheme params))
 			 (intern (cdr (assq :scheme params))))
+		       geiser-scheme-implementation
 		       geiser-default-implementation
 		       (car geiser-active-implementations)))
 	     (session (org-babel-scheme-make-session-name
-- 
2.26.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Patch] Add support for geiser-scheme-implementation to lisp/ob-scheme.el
  2020-05-31  4:40 [Patch] Add support for geiser-scheme-implementation to lisp/ob-scheme.el Vladimir Nikishkin
@ 2020-06-08  8:33 ` Vladimir Nikishkin
  2020-06-08  8:47   ` Bastien
  0 siblings, 1 reply; 3+ messages in thread
From: Vladimir Nikishkin @ 2020-06-08  8:33 UTC (permalink / raw)
  To: emacs-orgmode

Could someone with a right of commit apply this patch?



2020-05-31 12:40 GMT+08:00, Vladimir Nikishkin <lockywolf@gmail.com>:
> Hello, everyone
>
> ob-scheme doesn't seem to be respecting geiser-scheme-implementation,
> which is a buffer-local variable to specify which implementation in
> particular to use in an org buffer by default.
>
> This 2-line patch adds this support.
>
> Please, consider adding it.
>
> --
> Yours sincerely, Vladimir Nikishkin
>


-- 
Yours sincerely, Vladimir Nikishkin


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Patch] Add support for geiser-scheme-implementation to lisp/ob-scheme.el
  2020-06-08  8:33 ` Vladimir Nikishkin
@ 2020-06-08  8:47   ` Bastien
  0 siblings, 0 replies; 3+ messages in thread
From: Bastien @ 2020-06-08  8:47 UTC (permalink / raw)
  To: Vladimir Nikishkin; +Cc: emacs-orgmode

Hi Vladimir,

Vladimir Nikishkin <lockywolf@gmail.com> writes:

> Could someone with a right of commit apply this patch?

applied, thanks.

I had to edit the patch to add a changelog.

Please read this page on how to submit your next patches:
https://orgmode.org/worg/org-contribute.html

Thanks,

-- 
 Bastien


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-06-08  8:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-31  4:40 [Patch] Add support for geiser-scheme-implementation to lisp/ob-scheme.el Vladimir Nikishkin
2020-06-08  8:33 ` Vladimir Nikishkin
2020-06-08  8:47   ` Bastien

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).