From: Carsten Dominik <carsten.dominik@gmail.com>
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: [RFC] Change some defcustoms into defcont
Date: Mon, 21 Oct 2013 12:26:41 +0200 [thread overview]
Message-ID: <C6A33FCB-43C4-4D68-BDED-87F35F206757@gmail.com> (raw)
In-Reply-To: <87mwm33sv1.fsf@gmail.com>
On 21.10.2013, at 10:56, Nicolas Goaziou <n.goaziou@gmail.com> wrote:
> Hello,
>
> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> I think this change breaks user setups. I don't know how many
>> people do change these keywords, but I know some do, if
>> only for localization purposes. I myself have modified the
>> archive keyword in some cases, if I use this feature for a
>> different purpose.
>
> I don't think it breaks their setup, since you can do:
>
> (setq org-deadline-string "SOMETHING:")
Yes. But in particular the less well versed users will likely
have used customize.
>
> Of course, if they change it with `custom-set-variables', they will have
> to change it.
>
>> You probably want to do this to make Org syntax less fragile.
>
> Correct.
>
>> However, I think it can also be achieved by leaving these as defcustom
>> and discouraging changes in the docstring with a standard sentence
>> about about deprecation.
>
> That's exactly the point of the defconst: you can still modify the
> variable, but it sends a strong message to the user. Also, it's not
> about deprecation: code base should still rely on these variables.
This is where I disagree. I think the Emacs implementation of defconst
is broken, and retained in this way only for backward compatibility.
If we still allow users to edit this in principle, I do not think we
should make these variables defconst. If editing is not
even depreciated, there is even less reason to make this change.
How about we add a sentence like this:
Changing this variable may cause compatibility problems with other users
trying to edit your file in Emacs.
>
>> Your most important argument to me seems about efficiency of cashing.
>> We can fix this by providing :set methods for the customize entries
>> that will trigger global cache erasing, so that you do not need to
>> programmatically check this all the time.
>
> I know, and I still have to do it for variables like
> `org-todo-keywords', which are meant to be modified.
>
> My main concern is about core Org syntax.
- Carsten
next prev parent reply other threads:[~2013-10-21 10:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-20 8:47 [RFC] Change some defcustoms into defcont Nicolas Goaziou
2013-10-20 18:23 ` Carsten Dominik
2013-10-21 8:56 ` Nicolas Goaziou
2013-10-21 10:26 ` Carsten Dominik [this message]
2013-10-21 10:51 ` Nicolas Goaziou
2013-10-21 11:56 ` Carsten Dominik
2013-10-21 15:15 ` Nicolas Goaziou
2013-10-22 7:50 ` Carsten Dominik
2013-10-22 9:52 ` Nicolas Goaziou
2013-10-22 10:34 ` Carsten Dominik
2013-10-22 18:28 ` Torsten Wagner
2013-10-22 20:00 ` Florian Beck
2013-10-23 8:56 ` Nicolas Goaziou
2013-10-23 13:25 ` Carsten Dominik
2013-10-29 14:04 ` Nicolas Goaziou
2013-10-29 14:11 ` Nicolas Goaziou
2013-11-16 20:25 ` Nicolas Goaziou
2013-11-16 23:55 ` Carsten Dominik
2013-10-21 8:17 ` Sebastien Vauban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C6A33FCB-43C4-4D68-BDED-87F35F206757@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=n.goaziou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).