emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] agenda startup: log-mode should be customizable as well
@ 2009-05-14  3:57 Benjamin Andresen
  2009-05-14 11:36 ` Carsten Dominik
  0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Andresen @ 2009-05-14  3:57 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

Hey there,

I was curious as to why a value such log-mode wasn't customizable
to be run on start-up as follow-mode and clock-report-mode are.

If Carsten thinks this is a good idea, I've attached a patch that may
shave of 5 seconds of him adding it. It applies cleanly to current git
HEAD.

br,
benny


[-- Attachment #2: org-agenda-show-log.diff --]
[-- Type: text/plain, Size: 1217 bytes --]

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 7622f6a..e52fdbc 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -628,6 +628,7 @@ Needs to be set before org.el is loaded."
   :group 'org-agenda-startup
   :type 'boolean)
 
+
 (defvar org-agenda-include-inactive-timestamps nil
   "Non-nil means, include inactive time stamps in agenda and timeline.")
 
@@ -789,6 +790,12 @@ agenda display."
   :group 'org-agenda-daily/weekly
   :type 'boolean)
 
+(defcustom org-agenda-start-with-log-mode nil
+  "The initial value of log-mode in a newly created agenda window."
+  :group 'org-agenda-startup
+  :group 'org-agenda-daily/weekly
+  :type 'boolean)
+
 (defcustom org-agenda-start-with-clockreport-mode nil
   "The initial value of clockreport-mode in a newly created agenda window."
   :group 'org-agenda-startup
@@ -1252,7 +1259,7 @@ The following commands are available:
   (unless org-agenda-keep-modes
     (setq org-agenda-follow-mode org-agenda-start-with-follow-mode
 	  org-agenda-clockreport-mode org-agenda-start-with-clockreport-mode
-	  org-agenda-show-log nil))
+	  org-agenda-show-log org-agenda-start-with-log-mode))
   (easy-menu-change
    '("Agenda") "Agenda Files"
    (append

[-- Attachment #3: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] agenda startup: log-mode should be customizable as well
  2009-05-14  3:57 [PATCH] agenda startup: log-mode should be customizable as well Benjamin Andresen
@ 2009-05-14 11:36 ` Carsten Dominik
  0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2009-05-14 11:36 UTC (permalink / raw)
  To: Benjamin Andresen; +Cc: emacs-orgmode


[-- Attachment #1.1: Type: text/plain, Size: 1893 bytes --]

Applied, thanks.

- Carsten

On May 14, 2009, at 5:57 AM, Benjamin Andresen wrote:

> Hey there,
>
> I was curious as to why a value such log-mode wasn't customizable
> to be run on start-up as follow-mode and clock-report-mode are.
>
> If Carsten thinks this is a good idea, I've attached a patch that may
> shave of 5 seconds of him adding it. It applies cleanly to current git
> HEAD.
>
> br,
> benny
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 7622f6a..e52fdbc 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -628,6 +628,7 @@ Needs to be set before org.el is loaded."
>   :group 'org-agenda-startup
>   :type 'boolean)
>
> +
> (defvar org-agenda-include-inactive-timestamps nil
>   "Non-nil means, include inactive time stamps in agenda and  
> timeline.")
>
> @@ -789,6 +790,12 @@ agenda display."
>   :group 'org-agenda-daily/weekly
>   :type 'boolean)
>
> +(defcustom org-agenda-start-with-log-mode nil
> +  "The initial value of log-mode in a newly created agenda window."
> +  :group 'org-agenda-startup
> +  :group 'org-agenda-daily/weekly
> +  :type 'boolean)
> +
> (defcustom org-agenda-start-with-clockreport-mode nil
>   "The initial value of clockreport-mode in a newly created agenda  
> window."
>   :group 'org-agenda-startup
> @@ -1252,7 +1259,7 @@ The following commands are available:
>   (unless org-agenda-keep-modes
>     (setq org-agenda-follow-mode org-agenda-start-with-follow-mode
> 	  org-agenda-clockreport-mode org-agenda-start-with-clockreport-mode
> -	  org-agenda-show-log nil))
> +	  org-agenda-show-log org-agenda-start-with-log-mode))
>   (easy-menu-change
>    '("Agenda") "Agenda Files"
>    (append
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode


[-- Attachment #1.2: Type: text/html, Size: 2591 bytes --]

[-- Attachment #2: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-05-14 11:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-14  3:57 [PATCH] agenda startup: log-mode should be customizable as well Benjamin Andresen
2009-05-14 11:36 ` Carsten Dominik

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).