From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rainer M Krug Subject: Re: [babel][PATCHES] ob-R patches for review Date: Thu, 8 May 2014 12:02:36 +0200 Message-ID: References: <87ppjpm5n5.fsf@gmail.com> Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiLA5-0003OJ-7C for emacs-orgmode@gnu.org; Thu, 08 May 2014 06:02:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WiLA0-0006Q1-74 for emacs-orgmode@gnu.org; Thu, 08 May 2014 06:02:45 -0400 Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:50458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiL9z-0006Pq-Tz for emacs-orgmode@gnu.org; Thu, 08 May 2014 06:02:40 -0400 Received: by mail-we0-f176.google.com with SMTP id q59so2279990wes.35 for ; Thu, 08 May 2014 03:02:39 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Charles Berry Cc: "emacs-orgmode@gnu.org" Envoy=C3=A9 de mon iPhone > Le 8 mai 2014 =C3=A0 04:26, Charles Berry a =C3=A9crit := >=20 > Eric Schulte gmail.com> writes: >=20 >>=20 >> Rainer M Krug krugs.de> writes: >>=20 >>> Hi >>>=20 >>> Attached please find seven patches for review to implement the storing >>> of org variables in their own environment and to make the org-issued R >>> code look nicer in the R session. >>>=20 >>> Thanks, >>>=20 >>> Rainer >>=20 >> Hi Rainer, >>=20 >> Thanks for these patches. I don't have the R experience to review or >> maintain them, but I'm happy to apply them. >>=20 >> I missed some previous discussion in this thread. Are these patches >> ready to be applied as is? >=20 >=20 > IMO, the patches hard coded behaviors that would better be customizable > and optional.=20 I'll give feedback tomorrow and let you know about customization of the name= of the environment. The general behavior of storing the variables in an env= ironment should not be customizable as it is 1) safer then the behavior of storing each variable separately 2) no changes for the user are introduced=20 Cheers Rainer >=20 > Rainer and I had some back and forth about this -- see the thread. >=20 > Best, >=20 > Chuck >=20 >=20 >=20