From: Carlo Tambuatco <email@example.com> To: Bhavin Gandhi <firstname.lastname@example.org> Cc: Org-Mode Mailing List <email@example.com>, Ihor Radchenko <firstname.lastname@example.org>, Gustavo Barros <email@example.com> Subject: Re: [PATCH] Bug: Duplicate logbook entry for repeated tasks [9.4.6 (9.4.6-gab9f2a @ /home/gustavo/.emacs.d/elpa/org-9.4.6/)] Date: Mon, 12 Jul 2021 22:55:39 -0400 [thread overview] Message-ID: <C00634EE-FDF6-41DF-AA9C-FD71DBAB4A1C@gmail.com> (raw) In-Reply-To: <CAOn=hbcMR5pBYGViXEtAiYZTWWLscs37bFLw7w+rApFGG1EeWQ@mail.gmail.com> Newbie question: what command do I use to apply the patch…? > On Jul 12, 2021, at 1:50 PM, Bhavin Gandhi <firstname.lastname@example.org> wrote: > > On Sun, 11 Jul 2021 at 06:59, Ihor Radchenko <email@example.com> wrote: >> You are right. I believe that I fixed the breakage in the attached >> patch. Also, I noticed that c67037 did not fix the original bug when >> state change requests interactive note. > > Thanks! I tested your latest patch, and it is fixing both the original > issues which `c67037' solved as well as this one. > > I was trying to understand your change. So, when we call > `org-agenda-todo', it calls `org-todo' which adds the > post-command-hook. This hook is supposed to run when `org-agenda-todo' > finishes, but instead of that we call it directly. This makes sure that > the change is recorded in `buffer-undo-list'. > > Sorry if that's too much to ask, but why don't we need something similar > when org-log-note-how is 'note? Can you please help me understand that? > I tried reading org-add-log-note and org-store-log-note, but I think I'm > missing something basic here. > > Also, should this line from org.el (org-store-log-note) be removed? > > ;; Don't add undo information when called from `org-agenda-todo'. >
next prev parent reply other threads:[~2021-07-13 2:56 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-14 13:39 Gustavo Barros 2021-06-14 18:01 ` Bhavin Gandhi 2021-06-14 18:41 ` Gustavo Barros 2021-07-10 13:48 ` [PATCH] " Ihor Radchenko 2021-07-10 16:46 ` Gustavo Barros 2021-07-10 17:14 ` Bhavin Gandhi 2021-07-11 1:29 ` Ihor Radchenko 2021-07-11 5:40 ` Ihor Radchenko 2021-07-11 5:57 ` Ihor Radchenko 2021-07-12 17:50 ` Bhavin Gandhi 2021-07-13 2:55 ` Carlo Tambuatco [this message] 2021-07-13 15:35 ` [PATCH] " Alan Ristow 2021-07-13 18:08 ` Bhavin Gandhi 2021-07-17 13:51 ` Ihor Radchenko 2021-07-17 13:41 ` [PATCH] " Ihor Radchenko 2021-09-25 15:25 ` Bastien 2021-09-25 18:15 ` Gustavo Barros 2021-09-26 6:26 ` Bastien
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=C00634EE-FDF6-41DF-AA9C-FD71DBAB4A1C@gmail.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] Bug: Duplicate logbook entry for repeated tasks [9.4.6 (9.4.6-gab9f2a @ /home/gustavo/.emacs.d/elpa/org-9.4.6/)]' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).