From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Fix incorrect time calculation for org-extend-today-until Date: Thu, 17 Oct 2013 07:42:37 +0200 Message-ID: References: <5235E247.3020809@gmail.com> <525EE1EB.3060805@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Content-Type: multipart/signed; boundary="Apple-Mail=_C45DAF9A-7BBC-4F96-BC73-0B88C85679DE"; protocol="application/pgp-signature"; micalg=pgp-sha1 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWght-0000kA-9S for emacs-orgmode@gnu.org; Thu, 17 Oct 2013 02:05:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWghk-00036A-Qw for emacs-orgmode@gnu.org; Thu, 17 Oct 2013 02:05:13 -0400 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:63641) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWghk-00033u-Jt for emacs-orgmode@gnu.org; Thu, 17 Oct 2013 02:05:04 -0400 Received: by mail-wi0-f179.google.com with SMTP id hm4so1904486wib.12 for ; Wed, 16 Oct 2013 23:05:03 -0700 (PDT) In-Reply-To: <525EE1EB.3060805@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Ian Kelling Cc: emacs-orgmode@gnu.org --Apple-Mail=_C45DAF9A-7BBC-4F96-BC73-0B88C85679DE Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=iso-8859-1 Hi Ian, I must have missed this a month ago, sorry about this. I applied the = patch now (by hand, git-am choked on it.) Thank you! - Carsten On 16.10.2013, at 20:58, Ian Kelling wrote: > I sent this patch a month ago, but it got no reply. Perhaps that I > accidentally had html email format didn't help. >=20 > During the extra hours of org-extend-today-until, when > org-clock-mode-line-total is 'today, the clocked time shown in the > modeline is wrong. It ignores all previously clocked time, when it > should add them starting from the past day beyond > org-extend-today-until hours. This also affects clock tables. >=20 > The problem can be reproduced in emacs -q with the following code, > as long as the current time is not between 11 PM and 12 AM: >=20 > (progn > (require 'org-clock) > (setq org-clock-mode-line-total 'today) > (setq org-extend-today-until 23) > (format-time-string "%a %D %l:%M %p" (org-clock-get-sum-start))) >=20 > expected result: > A date of yesterday, time of 11:00 PM >=20 > Actual result: > A date of today, time of 11:00 PM >=20 > Note this patch only fixes a bug where org-extend-today-until > is already used. >=20 >=20 > - Ian Kelling >=20 > <0001-Fix-incorrect-time-calculation-for-org-extend-today-.patch> --Apple-Mail=_C45DAF9A-7BBC-4F96-BC73-0B88C85679DE Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJSX3jNAAoJEO+gg/nAZuwMxy4H/2LtMk3862whEryVHKqjP/Y9 wlxDWZe5pf2aEcJLKLMtQpAQxzmrkuNtWQK6aWJWHi6l5dzkHemGK8qdlcCHTX9E XA08X0WgztMZJ6nqjz1Q5uD+svEJqNivVG5DvMIn+zMqQWNQmf3pzGPZr9fl5nRp aDYMIHtVccy/MAYbGHL/qtus4PoeJJTcLIl5J6Ti1qDMLRsZsY0lRFow278bRMG3 rqB7/zodtpUMQGCAn1G9IJwWyaVxKfYvtcAvu9maHCoyBpd8R2Gu+WzhyjAlTbMr 8DCYb9w8EesWHBkhar8KXTV1uVaUg+GqzlJKRwt7kQ9TIIijdjHH2npv5ZYayWw= =Suoz -----END PGP SIGNATURE----- --Apple-Mail=_C45DAF9A-7BBC-4F96-BC73-0B88C85679DE--