From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand Subject: Re: [PATCH] extend doc strings of priority defcustoms Date: Tue, 31 May 2011 19:52:06 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=0016364c7d31f267e704a4960f2f Return-path: Received: from eggs.gnu.org ([140.186.70.92]:37859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRTCS-00015t-23 for emacs-orgmode@gnu.org; Tue, 31 May 2011 13:57:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QRTCP-0001bo-8K for emacs-orgmode@gnu.org; Tue, 31 May 2011 13:57:51 -0400 Received: from mail-ey0-f169.google.com ([209.85.215.169]:37020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRTCN-0001an-Lt for emacs-orgmode@gnu.org; Tue, 31 May 2011 13:57:47 -0400 Received: by eyd9 with SMTP id 9so1930566eyd.0 for ; Tue, 31 May 2011 10:57:46 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Org Mode --0016364c7d31f267e704a4960f2f Content-Type: text/plain; charset=ISO-8859-1 My most recent patch has been applied. Unfortunately it broke the wrap around when cycling through priorities. Now I have rewritten the "if" that I obviously did not understand enough, have corrected the error message, have tested much better and suggest this additional patch that should definitely improve the situation. Michael --0016364c7d31f267e704a4960f2f Content-Type: application/octet-stream; name="0001-Priorities-Fix-error-handling-and-improve-docstring.patch" Content-Disposition: attachment; filename="0001-Priorities-Fix-error-handling-and-improve-docstring.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_god50ta00 RnJvbSBkNGRiOGNjYTZiOWMzYzM2Y2VkZmZlOWQwOWVmOGEyNzhmYjQxOGMyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIEJyYW5kIDxtaWNoYWVsLmNoLmJyYW5kQGdtYWls LmNvbT4KRGF0ZTogVHVlLCAzMSBNYXkgMjAxMSAxOTozOTowMyArMDIwMApTdWJqZWN0OiBbUEFU Q0hdIFByaW9yaXRpZXM6IEZpeCBlcnJvciBoYW5kbGluZyBhbmQgaW1wcm92ZSBkb2NzdHJpbmcK CiogbGlzcC9vcmcuZWwgKG9yZy1kZWZhdWx0LXByaW9yaXR5KTogSW1wcm92ZSBkb2NzdHJpbmcu CihvcmctcHJpb3JpdHkpOiBDbGVhbnVwIGFuZCBjb3JyZWN0aW9uIG9mIHRocm93IGVycm9yIHdo ZW4gcHJpb3JpdHkgaXMKb3V0IG9mIHJhbmdlLgotLS0KIGxpc3Avb3JnLmVsIHwgICA0OCArKysr KysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZXMgY2hh bmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlz cC9vcmcuZWwgYi9saXNwL29yZy5lbAppbmRleCA5NTYyYjZlLi5mMWMxZDNjIDEwMDY0NAotLS0g YS9saXNwL29yZy5lbAorKysgYi9saXNwL29yZy5lbApAQCAtMjQ5Myw3ICsyNDkzLDkgQEAgV2hl biBzdGFydGluZyB0byBjeWNsZSBvbiBhbiBlbXB0eSBwcmlvcml0eSB0aGUgZmlyc3Qgc3RlcCBp biB0aGUgY3ljbGUKIGRlcGVuZHMgb24gYG9yZy1wcmlvcml0eS1zdGFydC1jeWNsZS13aXRoLWRl ZmF1bHQnLiAgVGhlIHJlc3VsdGluZyBmaXJzdAogc3RlcCBwcmlvcml0eSBtdXN0IG5vdCBleGNl ZWQgdGhlIHJhbmdlIGZyb20gYG9yZy1oaWdoZXN0LXByaW9yaXR5JyB0bwogYG9yZy1sb3dlc3Qt cHJpb3JpdHknIHdoaWNoIG1lYW5zIHRoYXQgYG9yZy1kZWZhdWx0LXByaW9yaXR5JyBoYXMgdG8g YmUKLWluIHRoaXMgcmFuZ2UgZXhjbHVzaXZlIG9yIGluY2x1c2l2ZSB0aGUgcmFuZ2UgYm91bmRh cmllcy4iCitpbiB0aGlzIHJhbmdlIGV4Y2x1c2l2ZSBvciBpbmNsdXNpdmUgdGhlIHJhbmdlIGJv dW5kYXJpZXMuICBFbHNlIHRoZQorZmlyc3Qgc3RlcCByZWZ1c2VzIHRvIHNldCB0aGUgZGVmYXVs dCBhbmQgdGhlIHNlY29uZCB3aWxsIGZhbGwgYmFjawordG8gKGRlcGVuZGluZyBvbiB0aGUgY29t bWFuZCB1c2VkKSB0aGUgaGlnaGVzdCBvciBsb3dlc3QgcHJpb3JpdHkuIgogICA6Z3JvdXAgJ29y Zy1wcmlvcml0aWVzCiAgIDp0eXBlICdjaGFyYWN0ZXIpCiAKQEAgLTEyMjg4LDggKzEyMjkwLDcg QEAgQUNUSU9OIGNhbiBiZSBgc2V0JywgYHVwJywgYGRvd24nLCBvciBhIGNoYXJhY3Rlci4iCiAg ICAgICAob3JnLWJhY2stdG8taGVhZGluZyB0KQogICAgICAgKGlmIChsb29raW5nLWF0IG9yZy1w cmlvcml0eS1yZWdleHApCiAJICAoc2V0cSBjdXJyZW50IChzdHJpbmctdG8tY2hhciAobWF0Y2gt c3RyaW5nIDIpKQotCQloYXZlIHQpCi0JKHNldHEgY3VycmVudCBvcmctZGVmYXVsdC1wcmlvcml0 eSkpCisJCWhhdmUgdCkpCiAgICAgICAoY29uZAogICAgICAgICgoZXEgYWN0aW9uICdyZW1vdmUp CiAJKHNldHEgcmVtb3ZlIHQgbmV3ID9cICkpCkBAIC0xMjMwOSwyNSArMTIzMTAsMzYgQEAgQUNU SU9OIGNhbiBiZSBgc2V0JywgYHVwJywgYGRvd24nLCBvciBhIGNoYXJhY3Rlci4iCiAJICAgICAg IChlcnJvciAiUHJpb3JpdHkgbXVzdCBiZSBiZXR3ZWVuIGAlYycgYW5kIGAlYyciCiAJCSAgICAg IG9yZy1oaWdoZXN0LXByaW9yaXR5IG9yZy1sb3dlc3QtcHJpb3JpdHkpKSkpCiAgICAgICAgKChl cSBhY3Rpb24gJ3VwKQotCShpZiAoYW5kIChub3QgaGF2ZSkgKGVxIGxhc3QtY29tbWFuZCB0aGlz LWNvbW1hbmQpKQotCSAgICAoc2V0cSBuZXcgb3JnLWxvd2VzdC1wcmlvcml0eSkKLQkgIChzZXRx IG5ldyAoaWYgKGFuZCBvcmctcHJpb3JpdHktc3RhcnQtY3ljbGUtd2l0aC1kZWZhdWx0IChub3Qg aGF2ZSkpCi0JCQlvcmctZGVmYXVsdC1wcmlvcml0eSAoMS0gY3VycmVudCkpKQotCSAgKHdoZW4g KDwgKHVwY2FzZSBuZXcpIG9yZy1oaWdoZXN0LXByaW9yaXR5KQotCSAgICAoZXJyb3IKLQkgICAg ICJTZWUgYG9yZy1kZWZhdWx0LXByaW9yaXR5JyBmb3IgcmFuZ2UgbGltaXQgZXhjZWVkZWQgaGVy ZSIpKSkpCisJKHNldHEgbmV3IChpZiBoYXZlCisJCSAgICAgICgxLSBjdXJyZW50KSAgOyBub3Jt YWwgY3ljbGluZworCQkgICAgOzsgbGFzdCBwcmlvcml0eSB3YXMgZW1wdHkKKwkJICAgIChpZiAo ZXEgbGFzdC1jb21tYW5kIHRoaXMtY29tbWFuZCkKKwkJCW9yZy1sb3dlc3QtcHJpb3JpdHkgIDsg d3JhcCBhcm91bmQgZW1wdHkgdG8gbG93ZXN0CisJCSAgICAgIDs7IGRlZmF1bHQKKwkJICAgICAg KGlmIG9yZy1wcmlvcml0eS1zdGFydC1jeWNsZS13aXRoLWRlZmF1bHQKKwkJCSAgb3JnLWRlZmF1 bHQtcHJpb3JpdHkKKwkJCSgxLSBvcmctZGVmYXVsdC1wcmlvcml0eSkpKSkpKQogICAgICAgICgo ZXEgYWN0aW9uICdkb3duKQotCShpZiAoYW5kIChub3QgaGF2ZSkgKGVxIGxhc3QtY29tbWFuZCB0 aGlzLWNvbW1hbmQpKQotCSAgICAoc2V0cSBuZXcgb3JnLWhpZ2hlc3QtcHJpb3JpdHkpCi0JICAo c2V0cSBuZXcgKGlmIChhbmQgb3JnLXByaW9yaXR5LXN0YXJ0LWN5Y2xlLXdpdGgtZGVmYXVsdCAo bm90IGhhdmUpKQotCQkJb3JnLWRlZmF1bHQtcHJpb3JpdHkgKDErIGN1cnJlbnQpKSkKLQkgICh3 aGVuICg+ICh1cGNhc2UgbmV3KSBvcmctbG93ZXN0LXByaW9yaXR5KQotCSAgICAoZXJyb3IKLQkg ICAgICJTZWUgYG9yZy1kZWZhdWx0LXByaW9yaXR5JyBmb3IgcmFuZ2UgbGltaXQgZXhjZWVkZWQg aGVyZSIpKSkpCisJKHNldHEgbmV3IChpZiBoYXZlCisJCSAgICAgICgxKyBjdXJyZW50KSAgOyBu b3JtYWwgY3ljbGluZworCQkgICAgOzsgbGFzdCBwcmlvcml0eSB3YXMgZW1wdHkKKwkJICAgIChp ZiAoZXEgbGFzdC1jb21tYW5kIHRoaXMtY29tbWFuZCkKKwkJCW9yZy1oaWdoZXN0LXByaW9yaXR5 ICA7IHdyYXAgYXJvdW5kIGVtcHR5IHRvIGhpZ2hlc3QKKwkJICAgICAgOzsgZGVmYXVsdAorCQkg ICAgICAoaWYgb3JnLXByaW9yaXR5LXN0YXJ0LWN5Y2xlLXdpdGgtZGVmYXVsdAorCQkJICBvcmct ZGVmYXVsdC1wcmlvcml0eQorCQkJKDErIG9yZy1kZWZhdWx0LXByaW9yaXR5KSkpKSkpCiAgICAg ICAgKHQgKGVycm9yICJJbnZhbGlkIGFjdGlvbiIpKSkKICAgICAgIChpZiAob3IgKDwgKHVwY2Fz ZSBuZXcpIG9yZy1oaWdoZXN0LXByaW9yaXR5KQogCSAgICAgICg+ICh1cGNhc2UgbmV3KSBvcmct bG93ZXN0LXByaW9yaXR5KSkKLQkgIChzZXRxIHJlbW92ZSB0KSkKKwkgIChpZiAoYW5kIChtZW1x IGFjdGlvbiAnKHVwIGRvd24pKQorCQkgICAobm90IGhhdmUpIChub3QgKGVxIGxhc3QtY29tbWFu ZCB0aGlzLWNvbW1hbmQpKSkKKyAgICAgICAgICAgICAgOzsgYG5ldycgaXMgZnJvbSBkZWZhdWx0 IHByaW9yaXR5CisJICAgICAgKGVycm9yCisJICAgICAgICJUaGUgZGVmYXVsdCBjYW4gbm90IGJl IHNldCwgc2VlIGBvcmctZGVmYXVsdC1wcmlvcml0eScgd2h5IikKKyAgICAgICAgICAgIDs7IG5v cm1hbCBjeWNsaW5nOiBgbmV3JyBpcyBiZXlvbmQgaGlnaGVzdC9sb3dlc3QgcHJpb3JpdHkKKyAg ICAgICAgICAgIDs7IGFuZCBpcyB3cmFwcGVkIGFyb3VuZCB0byB0aGUgZW1wdHkgcHJpb3JpdHkK KwkgICAgKHNldHEgcmVtb3ZlIHQpKSkKICAgICAgIChzZXRxIG5ld3MgKGZvcm1hdCAiJWMiIG5l dykpCiAgICAgICAoaWYgaGF2ZQogCSAgKGlmIHJlbW92ZQotLSAKMS43LjQuMgoK --0016364c7d31f267e704a4960f2f--