emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Michael Brand <michael.ch.brand@gmail.com>
To: Michael Brand <michael.ch.brand@gmail.com>,
	Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Bugfix for heading levels when toggling from list
Date: Thu, 9 Jun 2011 13:13:17 +0200	[thread overview]
Message-ID: <BANLkTikfyHprQowXbq7=WELuvtnSB7gVAw@mail.gmail.com> (raw)
In-Reply-To: <87hb7zphhf.fsf@gmail.com>

On Thu, Jun 9, 2011 at 09:54, Nicolas Goaziou <n.goaziou@gmail.com> wrote:
> I would happily apply your patch, but could you explain, before, what
> bugs are solved by it ? Thank you.

BTW, your bugfix commit mentioned by me was not buggy at all, it just
unleashed (before I wrongly wrote "introduced") this buglet hidden
before: "C-c *" on an item inside heading and only with "odd":
#+begin_src org
  ,#+STARTUP: odd
  ,* section
  ,  - item
expected: 3 stars, buglet: 2 stars

The second buglet, found in the source code while resolving the first:
"M-1 C-c *" on an item before first heading:
#+begin_src org
  ,- item
expected: 1 star, buglet: 2 stars

According to my understanding of the source code of org-toggle-heading
I expect no other buglet with "C-c *" on items or body text. At least
I found no buglet left when testing my changes with the necessary
combinations to cover all 4 cases within each of both "cond" and both
"if nstar" in the source code region I changed:
- no region / region with body text lines or one item nested in one item
- item(s) / body text line(s)
- before first heading / inside heading
- "C-c *" / "M-1 C-c *" / "M-2 C-c *"
- #+STARTUP: oddeven / odd
Quite a rigorous testing :-)


  reply	other threads:[~2011-06-09 11:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-09  7:07 [PATCH] Bugfix for heading levels when toggling from list Michael Brand
2011-06-09  7:54 ` Nicolas Goaziou
2011-06-09 11:13   ` Michael Brand [this message]
2011-06-10  5:25     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTikfyHprQowXbq7=WELuvtnSB7gVAw@mail.gmail.com' \
    --to=michael.ch.brand@gmail.com \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).