From: Carsten Dominik <carsten.dominik@gmail.com>
To: Manish <mailtomanish.sharma@gmail.com>
Cc: emacs-orgmode list <emacs-orgmode@gnu.org>
Subject: Re: tag or property names with dashes
Date: Mon, 30 Aug 2010 10:34:57 +0200 [thread overview]
Message-ID: <B5214606-CE6E-4364-AA30-DA1315E16A51@gmail.com> (raw)
In-Reply-To: <AANLkTincP_uEZGBmXR2nyr6Y2Ofh7=317cnun7yuB+-F@mail.gmail.com>
Hi Manish,
this looks pretty good. I just went over the patch and
found something like 5 locations where you did not make
the change, and I fixed those.
Have you been testing your patch extensively? Some testing
needs to be done before we can merge it.
- Carsten
On Aug 20, 2010, at 9:30 PM, Manish wrote:
> On Sat, Aug 21, 2010 at 12:58 AM, Manish <mailtomanish.sharma@gmail.com
> > wrote:
>> On Fri, Aug 20, 2010 at 11:02 PM, Manish wrote:
>>> On Fri, Aug 20, 2010 at 7:15 PM, Carsten Dominik wrote:
>>>>
>>>> On Aug 20, 2010, at 3:36 PM, Manish wrote:
>>>>
>> [snip: accepting -'s in properties (17 lines)]
>>>>>
>>>>> Are "#" and "%" are disallowed in the tags? Can they be made to
>>>>> work
>>>>> please?
>>>>
>>>> This is non-trivial and I shy away from the work for now. Make me a
>>>> patch and I will look at it.
>>>
>>> Attempting something that /you/ call non-trivial is nigh impossible
>>> for me. :(
>>>
>>> But even if I were to dare.. any hints where I could start?
>>>
>>
>> Attaching a naive first attempt. With this patch, I have tested
>> special
>> behavior of ctrl-a/e respecting tags in org files, ascii and HTML
>> exports, agenda, and tag filtering. LaTeX export was not working so
>> could not test and do not have the setup for testing Docbook exports.
>> Please do take a look -- I do not understand the larger
>> repurcussions/side effects of the changes to all the regexes.
>>
>> Thanks
>> -- Manish
>>
>
> This time _with_ patch.
>
> -- Manish
> <0001-Modified-regexes-to-accept-percent-and-hash-sign-as-.patch>
- Carsten
next prev parent reply other threads:[~2010-08-30 11:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 19:40 tag or property names with dashes Ilya Shlyakhter
2010-08-20 7:27 ` Carsten Dominik
2010-08-20 13:36 ` Manish
2010-08-20 13:45 ` Carsten Dominik
2010-08-20 17:32 ` Manish
2010-08-20 19:28 ` Manish
2010-08-20 19:30 ` Manish
2010-08-30 8:34 ` Carsten Dominik [this message]
2010-08-30 17:29 ` Manish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B5214606-CE6E-4364-AA30-DA1315E16A51@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mailtomanish.sharma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).