From: Arthur Miller <arthur.miller@live.com>
To: Ruijie Yu <ruijie@netyu.xyz>
Cc: emacs-orgmode@gnu.org
Subject: Re: Problem with let/cl-letf binding stuff with org-capture
Date: Fri, 10 Feb 2023 17:29:12 +0100 [thread overview]
Message-ID: <AM9PR09MB4977BC7D367844F9E256ABB496DE9@AM9PR09MB4977.eurprd09.prod.outlook.com> (raw)
In-Reply-To: <E2EB9155-238D-4423-80A0-B64D934FEBF8@netyu.xyz> (Ruijie Yu's message of "Fri, 10 Feb 2023 23:38:51 +0800")
Ruijie Yu <ruijie@netyu.xyz> writes:
> Hi Arthur,
>
> Please excuse my brevity and semi-random line of thought, as I’m replying on mobile right now. See below.
>
>> On Feb 10, 2023, at 23:11, Arthur Miller <arthur.miller@live.com> wrote:
>>
>>
>> Based on a Reddit thread:
>>
>> https://www.reddit.com/r/emacs/comments/10xhvd8/a_little_readstring_utility_using_an_org_mode/j7xziao/?context=3
>>
>> I did a small experiment to see if I can re-use org-capture, to just capture a
>> string from a buffer, without actually writing to any file.
>>
>> My plan was to just let-bind org-capture-finalize with cl-letf:
>>
>> #+begin_src emacs-lisp
>> (defun my-read-string ()
>> (cl-letf (((symbol-function 'org-capture-finalize) ;; C-c C-c
>> (lambda (&optional _) (interactive "P") (buffer-string)))
>> ((symbol-function 'org-kill-note-or-show-branches) #'kill-buffer)) ;; C-c C-k
>> (let ((org-capture-templates '(("s" "string" plain (function ignore)))))
>> (org-capture nil "s"))))
>> #+end_src
>
> Based on my somewhat-limited experience with CL (and elisp), I have never seen
> this particular type of letf structure. What I am used to seeing and writing is
> the following:
It uses "place" or "field" to set the symbol binding, as in setf or incf.
You can read more on SX:
https://stackoverflow.com/questions/39550578/in-emacs-what-is-the-difference-between-cl-flet-and-cl-letf
> (cl-letf ((f (x) (1+ x))
> (1+ (f 2)))
> ; => 4
>
> In particular, IIUC, I don’t think you would need symbol-function here. Maybe
> you can learn more from the docstring of cl-letf than me trying to drain my
> memory on this topic without reference.
>
> Also, in the code snippet you provided, what *should* org-capture-finalize be? A function that can be called like this:
>
> (org-capture-finalize arg1 arg2)
>
> ? Or a variable containing a function (reference) that can be called like this:
>
> (funcall org-capture-finalize arg1 arg2)
>
> ? In the former case you might be able to use cl-letf, and in the latter case you should use let with a lambda value.
>
>> Unfortunately, that does not work. Regardless of binding, and if I used cl-letf
>> or cl-flet or cl-labels, or old let, or something brewed on the internet, the
>> binding org-capture see for org-capture-finalize, is the original one from
>> org-capture.el.
>>
>> My second experiment was to abstract the finalize function into a funcallable
>> fariable in org-capture.el (I have patched org-capture.el with this):
>>
>> #+begin_src emacs-lisp
>> (defvar org-capture-finalizer #'org-capture--default-finalize)
>>
>> (defun org-capture-finalize (&optional stay-with-capture)
>> "Finalize the capture process.
>> With prefix argument STAY-WITH-CAPTURE, jump to the location of the
>> captured item after finalizing."
>> (interactive "P")
>> (funcall org-capture-finalizer stay-with-capture))
>>
>>
>> (defun org-capture--default-finalize (&optional stay-with-capture)
>> "Default implementation for org-capture finalizer function."
>>
>> ;; this is the original org-capture-finalize just renamed to "default-finalize"
>> )
>> #+end_src
>>
>> So I could then have something like this (never mind C-c C-k function being
>> removed):
>>
>> #+begin_src emacs-lisp
>> (defun my-read-string ()
>> (let ((org-capture-templates '(("s" "string" plain (function ignore))))
>> (org-capture-finalizer
>> (lambda (&optional _) (interactive "P") (buffer-string))))
>> (org-capture nil "s")))
>> #+end_src
>>
>> However I see that the binding for the org-capture-finalizer, in capture buffer,
>> is still the default 'org-capture--default-finalize' and not my lambda.
>
> I guess this answers part of my question in my previous paragraph. Is
> org-capture-finalizer defined via defvar? If so, does it help if you put an
> empty defvar before the let binding? If not, maybe someone actually using Emacs
> right now can be of more help here.
These were two different examples; one that let-binds the function
'org-caputre-finalize', via cl-letf and the latter one that was completely
different in which I have defvared a symbol so I can let-bind it as a variable.
> If not, maybe someone actually using Emacs
> right now can be of more help here.
Don't worry; thanks for the help anyway!
/a
next prev parent reply other threads:[~2023-02-10 16:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 15:05 Problem with let/cl-letf binding stuff with org-capture Arthur Miller
2023-02-10 15:38 ` Ruijie Yu via General discussions about Org-mode.
2023-02-10 16:29 ` Arthur Miller [this message]
2023-02-10 19:00 ` Bruno Barbier
2023-02-11 6:33 ` Arthur Miller
2023-02-11 7:58 ` Bruno Barbier
2023-02-11 16:14 ` Arthur Miller
2023-02-11 19:23 ` Bruno Barbier
2023-02-12 7:21 ` Arthur Miller
2023-02-12 9:22 ` Bruno Barbier
2023-02-12 16:12 ` Arthur Miller
2023-02-12 16:22 ` Ihor Radchenko
2023-02-13 18:40 ` Bruno Barbier
2023-02-15 11:45 ` Arthur Miller
2023-02-15 13:18 ` Bruno Barbier
2023-02-15 17:36 ` arthur miller
2023-02-13 18:37 ` Bruno Barbier
2023-02-11 16:49 ` Ihor Radchenko
2023-02-15 13:06 ` Arthur Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM9PR09MB4977BC7D367844F9E256ABB496DE9@AM9PR09MB4977.eurprd09.prod.outlook.com \
--to=arthur.miller@live.com \
--cc=emacs-orgmode@gnu.org \
--cc=ruijie@netyu.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).