Re: [PATCH] Fix section id on HTML export when no custom id is present

From: Carsten Dominik <carsten.dominik@gmail.com>
To: Bernt Hansen <bernt@norang.ca>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix section id on HTML export when no custom id is present
Date: Sun, 19 Apr 2009 22:33:44 +0200	[thread overview]
Message-ID: <ACB0B7F7-C474-4765-84D3-CF059BCAD7DC@gmail.com> (raw)
In-Reply-To: <1240158544-8214-2-git-send-email-bernt@norang.ca>

Yes, a bug, but your fix is not the right one, see the discussions  
with Sebastian about the naming of containers and IDs.

Fixed, in a different way.

Thanks.

- Carsten

On Apr 19, 2009, at 6:29 PM, Bernt Hansen wrote:

> This fixes a bug where section ids were all set to 'nil'.
> suffix and href were identical so suffix is no more.
>
> Before this change the table of contents had the correct id but the
> heading levels all had id="nil"
> ---
>
> This patch is available at git://git.norang.ca/org-mode for-carsten
>
> lisp/org-html.el |    9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/lisp/org-html.el b/lisp/org-html.el
> index 0f3d113..0c416af 100644
> --- a/lisp/org-html.el
> +++ b/lisp/org-html.el
> @@ -1817,7 +1817,7 @@ When TITLE is nil, just close all open levels."
> 	 (preferred (cdr (assoc target org-export-preferred-target-alist)))
> 	 (remove (or preferred target))
> 	 (l org-level-max)
> -	 snumber href suffix)
> +	 snumber href)
>     (setq extra-targets (remove remove extra-targets))
>     (setq extra-targets
> 	  (mapconcat (lambda (x)
> @@ -1874,12 +1874,11 @@ When TITLE is nil, just close all open  
> levels."
> 				 level snumber)
> 			 " " title)))
> 	(unless (= head-count 1) (insert "\n</div>\n"))
> -	(setq href (cdr (assoc (concat "sec-" snumber) org-export- 
> preferred-target-alist)))
> -	(setq suffix (or href (concat "sec-" snumber)))
> +	(setq href (or (cdr (assoc (concat "sec-" snumber) org-export- 
> preferred-target-alist)) (concat "sec-" snumber)))
> 	(insert (format "\n<div id=\"outline-container-%s\" class=\"outline- 
> %d\">\n<h%d id=\"%s\">%s%s</h%d>\n<div class=\"outline-text-%d\" id= 
> \"text-%s\">\n"
> -			suffix level level href
> +			href level level href
> 			extra-targets
> -			title level level suffix))
> +			title level level href))
> 	(org-open-par)))))
>
> (defun org-export-html-get-tag-class-name (tag)
> -- 
> 1.6.3.rc1
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode