Re: Re: Org-Babel - Clojure & Lazy Sequences Bug

From: Rick Moynihan <rick.moynihan@gmail.com>
To: Eric Schulte <schulte.eric@gmail.com>
Cc: Achim Gratz <Stromeko@nexgo.de>, emacs-orgmode@gnu.org
Subject: Re: Re: Org-Babel - Clojure & Lazy Sequences Bug
Date: Sun, 28 Nov 2010 23:23:38 +0000	[thread overview]
Message-ID: <AANLkTim5Ta1RYVLnsKAX=bhFVJQ1hCzRNE=7h4RSOGWP@mail.gmail.com> (raw)
In-Reply-To: <87mxoukd39.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

Hey Eric, thanks for the changes...  I tried them locally and they
didn't work as some of the pprint functions you were using weren't
fully qualified.  I've attached a small patch with the fixes.

Also it's worth noting for anyone else that clojure 1.2.0(+) is
required for this to work.

Thanks again for working on this,

R.

On 27 November 2010 15:20, Eric Schulte <schulte.eric@gmail.com> wrote:
> Fixed, Thanks -- Eric
>
> Achim Gratz <Stromeko@nexgo.de> writes:
>
>> "Eric Schulte" <schulte.eric@gmail.com> writes:
>>> I've just pushed up an implementation of this feature.
>>
>> I'm afraid byte-compile doesn't like it:
>>
>> In org-babel-expand-body:clojure:
>> ob-clojure.el:63:26:Warning: reference to free variable `result-params'
>>
>>
>> :-)
>>
>>
>> Achim.
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>

[-- Attachment #2: ob-clojure.patch --]
[-- Type: text/x-patch, Size: 894 bytes --]

From 4c05743905a1ab3970d7f5075440e67e1be9d7f3 Mon Sep 17 00:00:00 2001
From: Rick Moynihan <rick@wgrids.com>
Date: Sun, 28 Nov 2010 23:21:02 +0000
Subject: [PATCH] Fixed babel pretty printing, by fully qualifying function names

---
 lisp/ob-clojure.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/ob-clojure.el b/lisp/ob-clojure.el
index e41bf15..a5e8c72 100644
--- a/lisp/ob-clojure.el
+++ b/lisp/ob-clojure.el
@@ -63,7 +63,7 @@
     (if (or (member "code" result-params)
 	    (member "pp" result-params))
 	(format (concat "(let [org-mode-print-catcher (java.io.StringWriter.)]"
-			"(with-pprint-dispatch %s-dispatch"
+			"(clojure.pprint/with-pprint-dispatch clojure.pprint/%s-dispatch"
 			"(clojure.pprint/pprint %s org-mode-print-catcher)"
 			"(str org-mode-print-catcher)))")
 		(if (member "code" result-params) "code" "simple") body)
-- 
1.7.0.4


[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
