emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Michael Brand <michael.ch.brand@gmail.com>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: Gez <register@geekanddiva.com>, emacs-orgmode@gnu.org
Subject: Re: VISIBILITY property and C-u C-u <TAB>
Date: Sun, 24 Oct 2010 08:43:47 +0200	[thread overview]
Message-ID: <AANLkTikLkGP=5W2uBJDOb5rSQvJoX0Z1=cgTrPKpJ3=e@mail.gmail.com> (raw)
In-Reply-To: <E72AB359-311B-4703-A9E0-CD6DC45AE153@gmail.com>

> On Oct 17, 2010, at 5:41 PM, Gez wrote:
>> C-u C-u TAB also cycles when it's repeated.

I have also noticed this buglet and have used a workaround until now.

On Fri, Oct 22, 2010 at 18:14, Carsten Dominik
<carsten.dominik@gmail.com> wrote:
> I believe I have fixed this, please verify.

Thank you for this, it resolves both `C-u C-u TAB' and
`C-u C-u C-u TAB' except for the special case with the variable
org-cycle-global-at-bob. For this special case I suggest additionally:

============================================================
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -5772,7 +5772,8 @@ in special contexts.
   `org-cycle-emulate-tab' for details.

 - Special case: if point is at the beginning of the buffer and there is
-  no headline in line 1, this function will act as if called with prefix arg.
+  no headline in line 1, this function will act as if called with prefix arg
+  (C-u TAB, same as S-TAB) also when called without prefix arg.
   But only if also the variable `org-cycle-global-at-bob' is t."
   (interactive "P")
   (org-load-modules-maybe)
@@ -5798,7 +5799,7 @@ in special contexts.
                      (if nstars (format "\\{1,%d\\}" nstars) "+")
                      " \\|\\([ \t]*\\)\\([-+*]\\|[0-9]+[.)]\\) \\)"))
             (t (concat "\\*" (if nstars (format "\\{1,%d\\} " nstars) "+ ")))
-          (bob-special (and org-cycle-global-at-bob (bobp)
+          (bob-special (and org-cycle-global-at-bob (not arg) (bobp)
                             (not (looking-at outline-regexp))))
           (org-cycle-hook
            (if bob-special
============================================================

Michael

  reply	other threads:[~2010-10-24  6:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-17 15:41 VISIBILITY property and C-u C-u <TAB> Gez
2010-10-22 16:14 ` Carsten Dominik
2010-10-24  6:43   ` Michael Brand [this message]
2010-10-24 16:10     ` Carsten Dominik
2010-10-24 16:09   ` Gez
2010-10-24 17:54     ` Michael Brand
2010-10-24 21:24     ` Michael Brand
2010-10-26 11:46   ` Gez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTikLkGP=5W2uBJDOb5rSQvJoX0Z1=cgTrPKpJ3=e@mail.gmail.com' \
    --to=michael.ch.brand@gmail.com \
    --cc=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=register@geekanddiva.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).